Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 5 Nov 2022 16:34:05 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Pasha Tatashin <pasha.tatashin@soleen.com>
Cc:     corbet@lwn.net, akpm@linux-foundation.org, hughd@google.com,
        hannes@cmpxchg.org, david@redhat.com, vincent.whitchurch@axis.com,
        seanjc@google.com, rppt@kernel.org, shy828301@gmail.com,
        paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz,
        Liam.Howlett@oracle.com, ccross@google.com, willy@infradead.org,
        arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: anonymous shared memory naming
Message-ID: <Y2YuDfQbAwtLRLq4@debian.me>
References: <20221105025342.3130038-1-pasha.tatashin@soleen.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="FQfVBk6NiV0tGkMf"
Content-Disposition: inline
In-Reply-To: <20221105025342.3130038-1-pasha.tatashin@soleen.com>
Precedence: bulk


--FQfVBk6NiV0tGkMf
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 05, 2022 at 02:53:42AM +0000, Pasha Tatashin wrote:
> Since:
> commit 9a10064f5625 ("mm: add a field to store names for private anonymous
> memory")
>=20
> We can set names for private anonymous memory but not for shared
> anonymous memory. However, naming shared anonymous memory just as
> useful for tracking purposes.
>=20

Who are "we"?

Instead, say "Since commit <commit>, name for private anonymous memory,
but not shared anonymous, can be set".

> @@ -431,8 +431,10 @@ is not associated with a file:
>   [stack]                    the stack of the main process
>   [vdso]                     the "virtual dynamic shared object",
>                              the kernel system call handler
> - [anon:<name>]              an anonymous mapping that has been
> + [anon:<name>]              a private anonymous mapping that has been
>                              named by userspace
> + path [anon_shmem:<name>]   an anonymous shared memory mapping that has
> +                            been named by userspace
>   =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D              =3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> =20

The table above triggers Sphinx warning:

Documentation/filesystems/proc.rst:436: WARNING: Malformed table.
Text in column margin in table line 8.

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D              =3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
[heap]                     the heap of the program
[stack]                    the stack of the main process
[vdso]                     the "virtual dynamic shared object",
                           the kernel system call handler
[anon:<name>]              a private anonymous mapping that has been
                           named by userspace
path [anon_shmem:<name>]   an anonymous shared memory mapping that has
                           been named by userspace
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D              =3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D

I have applied the fixup:

---- >8 ----

diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems=
/proc.rst
index 8f1e68460da5cd..3f17b4ef307fe4 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -426,7 +426,7 @@ with the memory region, as the case would be with BSS (=
uninitialized data).
 The "pathname" shows the name associated file for this mapping.  If the ma=
pping
 is not associated with a file:
=20
- =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D              =3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
+ =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =
  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
  [heap]                     the heap of the program
  [stack]                    the stack of the main process
  [vdso]                     the "virtual dynamic shared object",
@@ -435,7 +435,7 @@ is not associated with a file:
                             named by userspace
  path [anon_shmem:<name>]   an anonymous shared memory mapping that has
                             been named by userspace
- =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D              =3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
+ =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =
  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=20
  or if empty, the mapping is anonymous.
=20

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--FQfVBk6NiV0tGkMf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY2YuCAAKCRD2uYlJVVFO
oz9oAPwKlsfNy7oaWuFtBZRtmLiAWjuEXXO/oYQ+eLkQNog6eQEAgqNvsaT5kEro
1QjKBz5gzd7Eh3lTYQX3y9Kbt/pH/QI=
=lgY4
-----END PGP SIGNATURE-----

--FQfVBk6NiV0tGkMf--