Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221105033623.259053-1-jqlhn@163.com>
In-Reply-To: <20221105033623.259053-1-jqlhn@163.com>
From:   Jassi Brar <jassisinghbrar@gmail.com>
Date:   Sat, 5 Nov 2022 10:24:01 -0500
Message-ID: <CABb+yY1moe2DmU9xJ0xR=U12ECmeHjN-cxfDYiw9ZBpcxRFp-g@mail.gmail.com>
Subject: Re: [PATCH] drivers:mailbox Using kfifo to store buffered message data
To:     jqlhn <jqlhn@163.com>
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 4, 2022 at 10:36 PM jqlhn <jqlhn@163.com> wrote:
>
> In current mailbox, a self implemented message array to be used
> as message fifo, I am replacing it with kernel kfifo,
> in order to make code cleaner.
>
> Signed-off-by: jqlhn <jqlhn@163.com>
> ---
>  drivers/mailbox/mailbox.c          | 33 ++++++++----------------------
>  drivers/mailbox/omap-mailbox.c     |  3 +--
>  drivers/mailbox/pcc.c              |  3 +--
>  include/linux/mailbox_controller.h | 10 ++++-----
>  4 files changed, 14 insertions(+), 35 deletions(-)
>
The circular buffer was implemented using an array because it is
simple enough and we wanted to keep tight control over the efficiency.
While you do manage to reduce 21 lines from 4 files, I am not sure
that is a reasonable tradeoff between readability and history plus
actual overhead of execution.

thanks.