Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp2645391rwl; Sat, 5 Nov 2022 09:29:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7qTpnfgCOWf9f7rR6I1JKDwKHjxOlNXBAKjy+Pp+AbeWE4Lsn5jZytmQJOPKaPrQ4/Blcs X-Received: by 2002:a17:906:5d10:b0:7ad:e132:bb85 with SMTP id g16-20020a1709065d1000b007ade132bb85mr28990766ejt.367.1667665757986; Sat, 05 Nov 2022 09:29:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667665757; cv=none; d=google.com; s=arc-20160816; b=sGPL/3tCXZOZdkMg5itHbv6Xv+4T3hvERfzHx4Ivm/TvEzsAAN8c0tSev5bN1pqd+7 YdpS6bYsA9mcMbANoEGaqRyhbhyeK9ehShovyRPK/OSZcZtNVXXc1316sLy25o561stz IIG+a1GldoLk+w4Ne2dm3waIIseKv8IrAg6E9YNAXqHYSlY9Zh/nQAomEkjzFCb78ZAr yxDzvQULmPZ/PsjpKzvhygt9QDAekxbWVdGw3YQe8Gl24jVgb+WDRqMKw4SSH+bBiFlt roL7N43BBeEy7goYXnKeV3wbJAPLOhaVUyQosKhQjPMAnyZ3jxDygLOpo4jgrF2UcM9f OFQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=u6qHbmDTzsFmp0X86fW394d4Fwkk/f/BlwJbwOKkJEU=; b=Xwe8QKbByQNoIf0u/DMbhKStWh4I19NCJy7P3NP0238ZR76UR3zBdFxti100g7W6vw aNccQGxmaNISeXxTlfXbzKMLiJ0To7gVVxaP1BFSiK+u1CeRlqTBvd5NxVjj6Ga6w9Ox p7Fb677OyR9mjJ8SszaEmCehLvT/xSnw0nMz7/ouxfkNLOy+/j3j+WvytluodVmGD2hW WmQDAuaUxvucgyecBHz9NkoeZrkQQ7ZZuhVrksAdRapl9qKX9Z+Zmy1Oco8SfDp79Vk2 6tVzG6rZmhWfEXu5BqkyEclk7TvfHHkaSmpqCQqM3ntqt8udyrA2fqgLk1F5piKvkf5X KlQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=i6jdgsdI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j8-20020aa7c0c8000000b0044f1b7b8713si2756088edp.281.2022.11.05.09.28.38; Sat, 05 Nov 2022 09:29:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=i6jdgsdI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbiKEPcC (ORCPT + 96 others); Sat, 5 Nov 2022 11:32:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229987AbiKEPcA (ORCPT ); Sat, 5 Nov 2022 11:32:00 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B73DDBCBB for ; Sat, 5 Nov 2022 08:31:59 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id b11so6947487pjp.2 for ; Sat, 05 Nov 2022 08:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u6qHbmDTzsFmp0X86fW394d4Fwkk/f/BlwJbwOKkJEU=; b=i6jdgsdIaozM/Ndg7HHs9a8asuJEhQrKcH7/ZbsijD/G5ocezII3lfuke4ykFge+kE uAuU8mZfBZUOwrLK74eJzJwnTk09emA/v/qI8aoqFRDxjjWKqxnJ6Dx3lPv3U8aFhp9d vijTSBBBDJfFB5TRvzYWVu92i3y+ejyi6E5lWjl2ahZE8tOUTx7JyAmE8k8WQGR+ZISu GIIC0nw8JFdXCS3aUsCedwnrUv0I64g7UV6Ir9vVES/msUmyxTDR350i9RlRzjHzCz+z 2qpvg3sItCrOJluRsUSWNXr4Rnvdja0HFBB0K0lFBXsMaG/gvubbyZH7hrYsBUs7eGLR u4HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u6qHbmDTzsFmp0X86fW394d4Fwkk/f/BlwJbwOKkJEU=; b=i/Pg4keH5mbHgtYSPphHQTG2A0rjdzo1i4fE9FE5+YXuWwhbeM2SfO+KUAw4WhI2Nz HP4JTWWAsQwZ0xS2HUkvUcM794Je5M0eKh/JDFfook2kdyBdCdU2rlsTwAAjtUqv3yJM zfTn/v/69MRfSH7HCHFAPmmv7dkfTV4485ORSt/+bAQgGdySexKjo8clCAAN6bAsTime J0cZG3qsJKfYiOV0Blqoyrmil2mm8pG2kmyJnEY8Zj2Tr3gvWAzw/tuir5RKW4GrZ39X L1CFQ5QugME/dKCJH5kaN3CRujosk27XoSLvC3Q+lNf+gYiWSkh5oOOj2+dN/vUOrJrt A87w== X-Gm-Message-State: ACrzQf1sLVVyp7QHGCXqgg4bzNjjyzHGuA6n//gaoh6hI5Ja2p4L+DO2 k/NCgHY4F2mp0mtOEzUmbSy2gA== X-Received: by 2002:a17:902:d48d:b0:186:cf83:4be3 with SMTP id c13-20020a170902d48d00b00186cf834be3mr40775011plg.22.1667662319226; Sat, 05 Nov 2022 08:31:59 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id z2-20020a17090a540200b0020af2bab83fsm1402635pjh.23.2022.11.05.08.31.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 08:31:58 -0700 (PDT) From: Jens Axboe To: korantwork@gmail.com, asml.silence@gmail.com Cc: kernel test robot , linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, Xinghui Li In-Reply-To: <20221102082503.32236-1-korantwork@gmail.com> References: <20221102082503.32236-1-korantwork@gmail.com> Subject: Re: [PATCH v2] io_uring: fix two assignments in if conditions Message-Id: <166766231805.14409.16784497219898130071.b4-ty@kernel.dk> Date: Sat, 05 Nov 2022 09:31:58 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.11.0-dev-d9ed3 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Nov 2022 16:25:03 +0800, korantwork@gmail.com wrote: > From: Xinghui Li > > Fixs two error: > > "ERROR: do not use assignment in if condition > 130: FILE: io_uring/net.c:130: > + if (!(issue_flags & IO_URING_F_UNLOCKED) && > > [...] Applied, thanks! [1/1] io_uring: fix two assignments in if conditions commit: c71afa164bfe91f0825c359940899e539abcb6b7 Best regards, -- Jens Axboe