Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp3186981rwl; Sat, 5 Nov 2022 18:59:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5GszcICt4laQz2JoPCLe2Tws3QOl4k2L1ZuCq5nal44lzsPsc4qVqEFRwxllf3mEw8lFbv X-Received: by 2002:a65:55c4:0:b0:46f:f932:fd39 with SMTP id k4-20020a6555c4000000b0046ff932fd39mr21410252pgs.251.1667699990087; Sat, 05 Nov 2022 18:59:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667699990; cv=none; d=google.com; s=arc-20160816; b=K/MkEQN2EJQn2uT8B4RZzGySXfbR4hHAOeMzBgOXBMwA4Ff4D3D00vdxpj8bWAbSv8 9H+Pmry5GQfCOvf5rqiPp7sOkahQlLc9zHcNCjvHlondChMynaKOs2OTRmRPF2DV1Mng q/H4P3fQ5CQ8mDqy48Z77c3e8xZgQYzna+HoTc909zMKNdMBUXE4A8bKvlZGtv72wZUB aNhIARAZmioMbBHXalDU/G12/tc54BRQ8CJkUdlVKenWHz1EyLMjY5C2phU3e7vP+Bh0 4vzQuWYxpq9SzWmSPxNev9XxyaGGdRHXjUvSnrYPduwmn7ymH5dCucwFAYtFsUenPfT1 ROaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id; bh=ZKwyqXP1xXzgyx+fVeImGykNljCEpKcmtVNE/ACdaeo=; b=goLFazLfBI4tWF5OWSC8xUhl5hxaZICMKjcaHfSUyYmSjI6O8/8kOx1RlTl5Q5aGgx qYEv80+/d9VE6w5FuzKOK3VJl/xbOb54I/VGfpdUioDFAlimVw42uzrXl9VpdAGTAT7Q D8/r61do+JNO9G6Loxg7BF8Wxz8Dqij2w5gPeoVS4AMX6QhqiaT7NFPCJZa5PyIDw+wO 0FW0oSWouCYj6a3iRgWD4mH+rocL/J5tl/GtyecEOzKa5e991nt8JJB2KW0OO+JKrX9f 40xXLRK3ovEA8jcXfR4QzUZ84qDgXvpG97HsvEN94i6OKOHcXJIk5ebJmSeSSPX1gGeF C9Jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d11-20020a056a00244b00b0056ca7c10cf2si5341900pfj.251.2022.11.05.18.59.37; Sat, 05 Nov 2022 18:59:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbiKFBSs convert rfc822-to-8bit (ORCPT + 96 others); Sat, 5 Nov 2022 21:18:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbiKFBSr (ORCPT ); Sat, 5 Nov 2022 21:18:47 -0400 Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A5C211448 for ; Sat, 5 Nov 2022 18:18:46 -0700 (PDT) Received: from omf04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4CB43A0968; Sun, 6 Nov 2022 01:18:45 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA id B045B20024; Sun, 6 Nov 2022 01:17:47 +0000 (UTC) Message-ID: <8fea8008f0ebb85d7e893513117347712e68fba5.camel@perches.com> Subject: Re: [PATCH v2 3/3] staging: rtl8192e: remove unnecesscary macro defines From: Joe Perches To: Jacob Bai , gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Sat, 05 Nov 2022 18:18:41 -0700 In-Reply-To: <6cdf838429ca9b553fb572f55a53ec25fa4e5f6a.1667694826.git.jacob.bai.au@gmail.com> References: <6cdf838429ca9b553fb572f55a53ec25fa4e5f6a.1667694826.git.jacob.bai.au@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, SPF_NONE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Stat-Signature: kx6q3pjzbf487pw7qw8q4b94uwbmijc6 X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: B045B20024 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19yKjAvG44W46awVvnMK0OggVPJz+h+ttU= X-HE-Tag: 1667697467-330742 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2022-11-06 at 12:11 +1100, Jacob Bai wrote: > remove useless macro defines [] > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > index eabb4187d907..aad1842857c0 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > @@ -307,12 +307,12 @@ void rtl92e_config_mac(struct net_device *dev) > struct r8192_priv *priv = rtllib_priv(dev); > > if (priv->bTXPowerDataReadFromEEPORM) { > - dwArrayLen = MACPHY_Array_PGLength; > - pdwArray = Rtl819XMACPHY_Array_PG; > + dwArrayLen = RTL8192E_MAC_ARRAY_PG_LEN; > + pdwArray = RTL8192E_MAC_ARRAY_PG; Perhaps use ARRAY_SIZE instead.