Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9981b20da995772efb0a8593982dbbe32e720355.camel@perches.com>
Subject: Re: [PATCH v2 3/3] staging: rtl8192e: remove unnecesscary macro
 defines
From:   Joe Perches <joe@perches.com>
To:     Jacob Bai <jacob.bai.au@gmail.com>, gregkh@linuxfoundation.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Date:   Sat, 05 Nov 2022 18:45:41 -0700
In-Reply-To: <Y2cOY/qq8hFrxV+m@jacob-Ubuntu>
References: <cover.1667694826.git.jacob.bai.au@gmail.com>
         <6cdf838429ca9b553fb572f55a53ec25fa4e5f6a.1667694826.git.jacob.bai.au@gmail.com>
         <8fea8008f0ebb85d7e893513117347712e68fba5.camel@perches.com>
         <Y2cOY/qq8hFrxV+m@jacob-Ubuntu>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2022-11-06 at 12:31 +1100, Jacob Bai wrote:
> On Sat, Nov 05, 2022 at 06:18:41PM -0700, Joe Perches wrote:
> > On Sun, 2022-11-06 at 12:11 +1100, Jacob Bai wrote:
> > > remove useless macro defines
> > []
> > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> > > index eabb4187d907..aad1842857c0 100644
> > > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> > > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
> > > @@ -307,12 +307,12 @@ void rtl92e_config_mac(struct net_device *dev)
> > >  	struct r8192_priv *priv = rtllib_priv(dev);
> > >  
> > >  	if (priv->bTXPowerDataReadFromEEPORM) {
> > > -		dwArrayLen = MACPHY_Array_PGLength;
> > > -		pdwArray = Rtl819XMACPHY_Array_PG;
> > > +		dwArrayLen = RTL8192E_MAC_ARRAY_PG_LEN;
> > > +		pdwArray = RTL8192E_MAC_ARRAY_PG;
> > 
> > Perhaps use ARRAY_SIZE instead.
> > 
> As the other drivers under rtlwifi are using ARRAY_LEN or ARRAY_LENGTH,
> maybe it's better to keep the same format?

Maybe it's better to use the typical kernel style.

$ git grep ARRAY_SIZE drivers/net/wireless/realtek/rtlwifi/
vs
$ git grep ARRAY_SIZE drivers/staging/rtl*