Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 06 Nov 2022 01:56:51 +0000
To:     "matt.ranostay@konsulko.com" <matt.ranostay@konsulko.com>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
From:   =?utf-8?Q?Alejandro_Concepci=C3=B3n_Rodr=C3=ADguez?= 
        <asconcepcion@acoro.eu>
Subject: [PATCH] iio: light: apds9960: fix wrong register for gesture gain
Message-ID: <EaT-NKC-H4DNX5z4Lg9B6IWPD5TrTrYBr5DYB784wfDKQkTmzPXkoYqyUOrOgJH-xvTsEkFLcVkeAPZRUODEFI5dGziaWXwjpfBNLeNGfNc=@acoro.eu>
Feedback-ID: 31930248:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Gesture Gain Control is in REG_GCONF_2 (0xa3), not in REG_CONFIG_2 (0x90).

Fixes: aff268cd532e ("iio: light: add APDS9960 ALS + promixity driver")

Signed-off-by: Alejandro Concepcion-Rodriguez <asconcepcion@acoro.eu>
---
 drivers/iio/light/apds9960.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
index b62c139baf41..38d4c7644bef 100644
--- a/drivers/iio/light/apds9960.c
+++ b/drivers/iio/light/apds9960.c
@@ -54,9 +54,6 @@
 #define APDS9960_REG_CONTROL_PGAIN_MASK_SHIFT=092
=20
 #define APDS9960_REG_CONFIG_2=090x90
-#define APDS9960_REG_CONFIG_2_GGAIN_MASK=090x60
-#define APDS9960_REG_CONFIG_2_GGAIN_MASK_SHIFT=095
-
 #define APDS9960_REG_ID=09=090x92
=20
 #define APDS9960_REG_STATUS=090x93
@@ -77,6 +74,9 @@
 #define APDS9960_REG_GCONF_1_GFIFO_THRES_MASK_SHIFT=096
=20
 #define APDS9960_REG_GCONF_2=090xa3
+#define APDS9960_REG_GCONF_2_GGAIN_MASK=09=09=090x60
+#define APDS9960_REG_GCONF_2_GGAIN_MASK_SHIFT=09=095
+
 #define APDS9960_REG_GOFFSET_U=090xa4
 #define APDS9960_REG_GOFFSET_D=090xa5
 #define APDS9960_REG_GPULSE=090xa6
@@ -396,9 +396,9 @@ static int apds9960_set_pxs_gain(struct apds9960_data *=
data, int val)
 =09=09=09}
=20
 =09=09=09ret =3D regmap_update_bits(data->regmap,
-=09=09=09=09APDS9960_REG_CONFIG_2,
-=09=09=09=09APDS9960_REG_CONFIG_2_GGAIN_MASK,
-=09=09=09=09idx << APDS9960_REG_CONFIG_2_GGAIN_MASK_SHIFT);
+=09=09=09=09APDS9960_REG_GCONF_2,
+=09=09=09=09APDS9960_REG_GCONF_2_GGAIN_MASK,
+=09=09=09=09idx << APDS9960_REG_GCONF_2_GGAIN_MASK_SHIFT);
 =09=09=09if (!ret)
 =09=09=09=09data->pxs_gain =3D idx;
 =09=09=09mutex_unlock(&data->lock);
--=20
2.34.1