Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 5 Nov 2022 23:35:52 -0500
From:   Bjorn Andersson <andersson@kernel.org>
To:     Johan Hovold <johan@kernel.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        konrad.dybcio@somainline.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org,
        quic_jprakash@quicinc.com, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        steev@kali.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v4 11/12] arm64: dts: qcom: sc8280xp-x13s: Add
 PM8280_{1/2} ADC_TM5 channels
Message-ID: <20221106043552.f5vrtpzd3en2lauc@builder.lan>
References: <20221103095810.64606-1-manivannan.sadhasivam@linaro.org>
 <20221103095810.64606-12-manivannan.sadhasivam@linaro.org>
 <Y2Om1N8X/Qkr9rYI@hovoldconsulting.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y2Om1N8X/Qkr9rYI@hovoldconsulting.com>
Precedence: bulk

On Thu, Nov 03, 2022 at 12:32:36PM +0100, Johan Hovold wrote:
> On Thu, Nov 03, 2022 at 03:28:09PM +0530, Manivannan Sadhasivam wrote:
> > Add ADC_TM5 channels of PM8280_{1/2} for monitoring the temperature from
> > external thermistors connected to AMUX pins. The temperature measurements
> > are collected from the PMK8280's VADC channels that expose the
> > measurements from secondary PMICs PM8280_{1/2}.
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 68 +++++++++++++++++++
> >  1 file changed, 68 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > index 7677fe5cf28e..bdaacf1abf9f 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > @@ -254,6 +254,74 @@ pmic-die-temp@403 {
> >  	};
> >  };
> >  
> > +&pmk8280_adc_tm {
> 
> Please try to keep the nodes sorted alphabetically (e.g. this one should
> go before &pmk8280_pon_pwrkey).
> 

Thanks for spotting that, I fixed up the order.

Regards,
Bjorn