Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 6 Nov 2022 01:01:55 -0700
From:   Brian Norris <computersforpeace@gmail.com>
To:     Christian Marangi <ansuelsmth@gmail.com>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Hendrik Koerner <koerhen@web.de>
Subject: Re: [PATCH] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1
Message-ID: <Y2dp8+2tfi2+nXNL@localhost>
References: <20221024233817.27410-1-ansuelsmth@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221024233817.27410-1-ansuelsmth@gmail.com>
Precedence: bulk

On Tue, Oct 25, 2022 at 01:38:17AM +0200, Christian Marangi wrote:
> It was reported non working mmc with this option enabled.
> Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't
> be run at 1.8v.
> Disable it to restore correct functionality of this SoC feature.
> 
> Tested-by: Hendrik Koerner <koerhen@web.de>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

Perhaps there's some board where this property makes sense, but it seems
like something that should be added when needed in the leaf DTS, and not
supplied in the base DTSI. So:

Reviewed-by: Brian Norris <computersforpeace@gmail.com>

This also fixes problems I've seen on my systems, so:

Tested-by: Brian Norris <computersforpeace@gmail.com>

Thanks!