Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp3575969rwl; Sun, 6 Nov 2022 01:09:57 -0800 (PST) X-Google-Smtp-Source: AMsMyM4t8BbvdHyoigKIBTV0BkxDPn0tuQMpYRc7WQBAUVJhJvvFAiObkJhXCOjYat/MPCUFPee6 X-Received: by 2002:a17:907:1c04:b0:7ad:8318:99aa with SMTP id nc4-20020a1709071c0400b007ad831899aamr41376656ejc.574.1667725797198; Sun, 06 Nov 2022 01:09:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667725797; cv=none; d=google.com; s=arc-20160816; b=Mk0/xRuMKXa5jWQFpYmNGIgZW38TNLnx10sIv56jEIcgDZrW0WnOebMbTyMVf5+SFW G9/9k3s77Uxp1ZC7MrfP2j776Fc2an13InuEwi3cQKtVunasa4dnqKqmGIERI6LuiuJA IIi5x9U7csxqUS6jfBjddmICyLbUJATuRdhCKZw8DPUGWKd+psLJ36qrf9HTEvuZrQ0X fqsJrJ+oY8shKPAw6UTNNjtbsSB8KAgk6d4QAbouzewxRrkYLnc0k2SrALBBCcZdiaBe a3HH62aI1lYzNcT1Cg33THTPirvg3clWkf0DXUWtL/2Hg0yNMlSo0myvo3gFEtlfFdp/ 3wng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=IedN9hGTjUJRM2QkZwLtvVtdrbrOyzLZkXMJyjsl+hA=; b=G4Kxa48qscTYYc0CJKFIq68JjqZmMAB0OsxdN4/lZcEf8Q6hCBEoJEIhXFY3IPR0In uRZ9vFyuL/47ZTu17XHJ9XxQAqERhvIjOlr1Phn5tQ7Q1EsOhWMbEQacTwadn0dlgOmg txNIGbTLzeZBwTjJjCapLyCizxVxHoXr/GizuaKHdWSCSllJcKjMhaIrOPlviHOighv0 yXiFj/Ofs5pj9y7NTQm+G7vvbadwum3TNOIzlc2TwbP74CRYWqflwGKNU6naKmZKU0eH Z4VmZCMY288KGJWYmoDEorIuziNFws6ocNaQyHTjHMxUjTUoIeBp9gbE5K4yEvrgfx7l EpZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=g+obRviE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn21-20020a05640222f500b00463153e5b14si5077480edb.517.2022.11.06.01.09.34; Sun, 06 Nov 2022 01:09:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=g+obRviE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbiKFImE (ORCPT + 96 others); Sun, 6 Nov 2022 03:42:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbiKFImD (ORCPT ); Sun, 6 Nov 2022 03:42:03 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0578DEE2 for ; Sun, 6 Nov 2022 01:42:00 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id y14so23018746ejd.9 for ; Sun, 06 Nov 2022 01:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IedN9hGTjUJRM2QkZwLtvVtdrbrOyzLZkXMJyjsl+hA=; b=g+obRviENN53QePdR7rWfD4VqexqHxi++mvPGoZHbL+JzhjrpwZB+cfV9C7azOCYch oCdxuPHJ36o+qQAieEMvvx6LImmFSdXdOkisTvvVLsmZ0LxwwWKnmkZ7R60AxX5Dc8/k 4BNFTXIJzG9513WV19xwuAyYwocdazDT8KhrFo94JK0fvwrA+Y3u/p7k1N7mytFts1Ze 5B91MphoyrQ+k8ha3pM5qSnDLNf+tQSUpby6CmJb74nskXo4tNHrUmBoBWFQdzpGigRf ei3GYKirviw/dZe9q4KYQkmEiOJla3fPe+hJdnY5BLl0NugVEkiWrdHJE1C/NxeqCBwe VS1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IedN9hGTjUJRM2QkZwLtvVtdrbrOyzLZkXMJyjsl+hA=; b=W9+SEldrSXBP57aTFC0bTHOgEtKX0nviHnfQN3Qsv03sh+rNYSZUojwQmcd8F1c2QQ 1B2Jd2k2L2Hqb/5njPOSk67ODw3zGwA+NXf/VRWoAA9Y0q+/CJFfFw6fwI3OcRJmlMLc WtywKQK0r5NNTxsi7r76Ual5f2hp+h3g/h6+6+yafnzpE0BiyLZj2PBAi/v2hRZ1Do4G WMCYvypckAUDICm7860NCZKrnOQr2AHlG/TkQJf2sXBVkgZEfgi9MFBLyQogIMT+tkI6 fLC5XIj82pxp8O7D+kpNSmakDJjHWLg3LR6n8YoahhXC4rrk9jhxWuOosbhgPnv8xb2X MOTw== X-Gm-Message-State: ACrzQf2ciJH9hbsl4XGwrcC2mlWVTpPDeYNt3K8vx3aQvYrCK13yMG9Y VfS6fQG/me1XpSR2F3sOwY7PmhmJt/o= X-Received: by 2002:a17:907:1ddd:b0:7ad:8371:b59c with SMTP id og29-20020a1709071ddd00b007ad8371b59cmr41935954ejc.429.1667724119358; Sun, 06 Nov 2022 01:41:59 -0700 (PDT) Received: from [192.168.1.101] (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id ku15-20020a170907788f00b007ae1ab8f887sm1918549ejc.14.2022.11.06.01.41.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Nov 2022 01:41:59 -0700 (PDT) Message-ID: Date: Sun, 6 Nov 2022 09:41:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 0/3] staging: rtl8192e: trivial code cleanup patches Content-Language: en-US To: Jacob Bai , gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: From: Philipp Hortmann In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/6/22 09:31, Jacob Bai wrote: > Rename few variables and source files to make it align with other > rtlwifi drivers. > The patches are required to be applied in sequence. > > Changes in v4: > 1. missing vision number in the v3 > > Changes in v3: > 1.Patch 3: use ARRAY_SIZE() to replace macros, feedback from > joe@perches.com > > Changes in v2: > 1. Patch 2: modify r8192E_firmware.c to include table.h instead of > r8192E_hwimg.h. > > Jacob Bai (3): > staging: rtl8192e: rename tables in r8192e_hwimg.c > staging: rtl8192e: rename r8192E_hwimg.c/h to table.c/h > staging: rtl8192e: replace macro defines with ARRAY_SIZE > > drivers/staging/rtl8192e/rtl8192e/Makefile | 2 +- > .../rtl8192e/rtl8192e/r8192E_firmware.c | 2 +- > .../staging/rtl8192e/rtl8192e/r8192E_hwimg.h | 33 ------------ > .../staging/rtl8192e/rtl8192e/r8192E_phy.c | 54 +++++++++---------- > .../staging/rtl8192e/rtl8192e/r8192E_phy.h | 20 ------- > .../rtl8192e/{r8192E_hwimg.c => table.c} | 34 +++++++----- > drivers/staging/rtl8192e/rtl8192e/table.h | 33 ++++++++++++ > 7 files changed, 84 insertions(+), 94 deletions(-) > delete mode 100644 drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.h > rename drivers/staging/rtl8192e/rtl8192e/{r8192E_hwimg.c => table.c} (91%) > create mode 100644 drivers/staging/rtl8192e/rtl8192e/table.h > Tested-by: Philipp Hortmann