Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp10212rwb; Sun, 6 Nov 2022 01:38:09 -0800 (PST) X-Google-Smtp-Source: AMsMyM6hvVEF67zwe6xgScwhbFi6dSQGhWA+2qs7aRjfZQviHjB6u0J+AjdN0lSbkq+JmwdIwfA/ X-Received: by 2002:a17:90b:118a:b0:213:bbbc:8f09 with SMTP id gk10-20020a17090b118a00b00213bbbc8f09mr40950682pjb.64.1667727488799; Sun, 06 Nov 2022 01:38:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667727488; cv=none; d=google.com; s=arc-20160816; b=Otxne047J0TVKm6cEty7PifiRlIntdxUeVfZCDUxjPFV3Su5Wm5jSb+u+TmxIeJqWq OwuKQJQE4p4CXexzgJRP4WxiBN9pZ1pEhP2ESgSaxLYU11aXVD10QvQNcBETfequoxbx nGwEJ3EbloZLaOOL2f+HJqhOBd7jjWJx+tiEFvG0LrduCEk6a50hwKBTw7CWUalIwNRL vJ2t8ZfYejdF8qGihB/l4IcQ5axjl7kDzCEAsSCEooUHaOMkvWdrVlw3RxvO8J4Re8LT 0pKfkCcf8SJ4qJHD/Yq6uswq81PMBxOGJEaUEHY2ZiSU4ik1XtCF6cw7hnKRYeW9kpq/ ekwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kB5x5Lb8Br6d/Jeea8bVOt5eSs5IgdDtxZC3hRWWkBA=; b=khE76VuZcl8rA3gnXm+shIidKpbmthpBPodOmOiAjHMKM+WoYjbYJ02nLL4ageuZCg dMnoHkxKOqB5Lqf4otuFrysBn5uIB+fr6dg5IhZPlPhhK70QRwAWLfPoxVGrW1ZIhSyY SOp2Z531ttyZvAzfpihCvjgo0K8X+eBiBVBNBXy6sjMc7qIWCA3XxGKBt2qcoC+B8jBp yPwFH2ysvGM/dw/x0duF9svqhqZCO9U9jT14Xl0LrKw46pqLnsAjvVRVko+Qf/9+nYpF eK82L4tkBhtoQ3Tt3I1WNlFyXUgRgmRwTZZx0SiwQOfXx+OQRttHQw2mv4Rl0IE/Srie /6hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=U8zWoIus; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pb17-20020a17090b3c1100b002024f3f1f8bsi6018410pjb.70.2022.11.06.01.37.56; Sun, 06 Nov 2022 01:38:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=U8zWoIus; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229754AbiKFJNQ (ORCPT + 97 others); Sun, 6 Nov 2022 04:13:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbiKFJNP (ORCPT ); Sun, 6 Nov 2022 04:13:15 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7648FFC6; Sun, 6 Nov 2022 01:13:14 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id d26so23079298eje.10; Sun, 06 Nov 2022 01:13:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kB5x5Lb8Br6d/Jeea8bVOt5eSs5IgdDtxZC3hRWWkBA=; b=U8zWoIusLivflIrhe/QqeEUiTBHp0weDQtpu7a3iD1sc9QTKpwALpgF1vtgRfCzikb 37wK32SeseS2JESpp01aC/H0tP0qOFSyd2ZFLVWP+RvfWoyE1KbjxaH3rxX0jkxtrlgJ D6USi7yXUC6kWqFuNsQzUPJaqoT9qZlwHyH2mQA4rILUJwQh3tpZaZbOgdAsquswiD1L p2ZpctsvirMCFQ/3saaqaii0fPnzKCyGC/7aHR+enUeY8lG7bv/DW4W44BETId09iXoa RX3yDYau3yE4BILllMhrojO6TJGi2PlX34S51wpMGtyy5OCxFuyQPOtqjporW0oe+YLD 5mpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kB5x5Lb8Br6d/Jeea8bVOt5eSs5IgdDtxZC3hRWWkBA=; b=xbdMp6R1mhqS7JgA7QdnUEdh8hZVYfJ+gPUHNvDXRPD+1L1dxgQnBG8qA37KVjheJb Ic+r+Rxtrqah1ZpHFuzSB8ju5mOAFp5PrsyqFJe0MooSIPc2AbzhcBxKTBexxgMk1R9n emmpr610qDinWpVvu0wtXQJdrjb8JX+DuZZV12S2mKIeeS4kZlxQQSBVquuFK6uj53Id Mu8BqkgIMfEoQ0v8+jJZmNsfDTrUKFlPKVl1YmcN65IaJnzVna1qd0GJOGTur6cTI1vG P26KOTBvFI+hV5pB/t/mE+QBOJuNUOR17HV1JvLxU3despJlwssZddIoBPBp2zacu7Ml ONJA== X-Gm-Message-State: ACrzQf0d1pKnM0bwxxLCI60FlDHPm0ilxmZ/m0qBv2E2FTUFqAom13a+ J/WoqSgJD1tRfeQjmHVa8Eg5wKlmtuAUfA== X-Received: by 2002:a17:907:a4e:b0:77d:94d:8148 with SMTP id be14-20020a1709070a4e00b0077d094d8148mr40810136ejc.607.1667725992932; Sun, 06 Nov 2022 01:13:12 -0800 (PST) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id r23-20020aa7d597000000b004638ba0ea96sm2301896edq.97.2022.11.06.01.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 01:13:12 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Paul Kocialkowski Cc: Paul Kocialkowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v8 6/6] media: sun6i-csi: Add support for hooking to the isp devices Date: Sun, 06 Nov 2022 10:13:11 +0100 Message-ID: <2085642.OBFZWjSADL@jernej-laptop> In-Reply-To: <20221103163717.246217-7-paul.kocialkowski@bootlin.com> References: <20221103163717.246217-1-paul.kocialkowski@bootlin.com> <20221103163717.246217-7-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne =C4=8Detrtek, 03. november 2022 ob 17:37:17 CET je Paul Kocialkowski=20 napisal(a): > In order to use the isp and csi together, both devices need to be > parented to the same v4l2 and media devices. We use the isp as > top-level device and let the csi code hook to its v4l2 and media > devices when async subdev registration takes place. >=20 > As a result v4l2/media device setup is only called when the ISP > is missing and the capture device is registered after the devices > are hooked. The bridge subdev and its notifier are registered > without any device when the ISP is available. Top-level pointers > for the devices are introduced to either redirect to the hooked ones > (isp available) or the registered ones (isp missing). >=20 > Also keep track of whether the capture node was setup or not to > avoid cleaning up resources when it wasn't. >=20 > Signed-off-by: Paul Kocialkowski Acked-by: Jernej Skrabec Best regards, Jernej