Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3d25a0b4-6957-d070-db11-69ec9e0132ba@oracle.com>
Date:   Sun, 6 Nov 2022 15:53:32 +0000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: [PATCH v2 9/9] KVM: x86: remove exit_int_info warning in
 svm_handle_exit
To:     Maxim Levitsky <mlevitsk@redhat.com>, kvm@vger.kernel.org
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org,
        Chenyi Qiang <chenyi.qiang@intel.com>,
        Yang Zhong <yang.zhong@intel.com>, x86@kernel.org,
        Shuah Khan <shuah@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Colton Lewis <coltonlewis@google.com>,
        Borislav Petkov <bp@alien8.de>, Peter Xu <peterx@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Jim Mattson <jmattson@google.com>,
        linux-kselftest@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Wei Wang <wei.w.wang@intel.com>,
        David Matlack <dmatlack@google.com>, stable@vger.kernel.org,
        Liam Merwick <liam.merwick@oracle.com>
References: <20221103141351.50662-1-mlevitsk@redhat.com>
 <20221103141351.50662-10-mlevitsk@redhat.com>
Content-Language: en-US
From:   Liam Merwick <liam.merwick@oracle.com>
In-Reply-To: <20221103141351.50662-10-mlevitsk@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mmg1OWJwRGpmZ0xQVXpYemtJY2d6Z281NEUyZkdjam8vL3pUZjI5ZlFCZ0ls?=
 =?utf-8?B?bTRmOS9GSVFFZnZKMjBGZkJmb3F0UVNKL2Z1TFkvbTgrVHJoNWRiWjRIL2px?=
 =?utf-8?B?YTlJdXAyQXpIYWo4ekFEd1FEemRpTktoOWNGckJ3ZWdjQlhYRWhldWpkWGtI?=
 =?utf-8?B?MWljOENlWk02TmNyR3NkbURrU3lGUFpaTXFWd3Qzd0Vxend3R3JYTDhDZWwv?=
 =?utf-8?B?REtUS2dJd0VyOGVLTk1wMlhJRFpqeTM4a1A2Y2thVnlja3V3NEF3NElyTUF3?=
 =?utf-8?B?ejdzckRNU3pDeFc1dU00QlZTdmtFbExLdFltYmpsaStES3Z3VzAvT2pzRjBq?=
 =?utf-8?B?d3FLY1M2cDhnYmFGUVNHc1c0VVppd1hnd2pUSXpvbTdycFUvMU1yKzJqL1I4?=
 =?utf-8?B?aDBZcnhMdkYwckZqN2hZTzNYcklHMlpRSk83b2hYVEJTUzBZdWhITlpyZENi?=
 =?utf-8?B?SnJHSzZGSEQvdHoyV1M3L292VExOVlZyaGVIYStyclFiTTNxdzJyUlVnVnoz?=
 =?utf-8?B?aS9sR0RhdkpwOUtDMU5xMHZ3U1RoM2FEbU9vUDRhRUl0TU1RV0d2WnpzQ1Rr?=
 =?utf-8?B?Nis0ajFCUUhxY05RdWVDVHR2aUVvbTdOZ2pKYmM4MklUY1RiaTFWZHhRUnhl?=
 =?utf-8?B?eHlWcklYSTczRG02UUdpN1JSSzZ0YzJNMnRrTytrQ0hiNEUvK1oxWVdXa0R0?=
 =?utf-8?B?MlRlczg2ZmY2MmRQL2t6NlVRSFhMd3I0ck5SQlZoRFVHa0lZMWEwNVhFenk5?=
 =?utf-8?B?OUNVU1g1bWpOVFZ4NG1td1VFNGc2YVN1djU2dGhLNXRvb2FJTEZOaS9BeGxu?=
 =?utf-8?B?MFY2b2I2OXA3SXg2b0c3Vzd1V20xTmYrYi9RdzJMbXVDRzcvVVJmaElhRTRQ?=
 =?utf-8?B?VHIybU9mb1BpNmY2cWxlTGphd3hHaHBnRVZvN2JpTWc3WFJtZVhpRDNuS2hS?=
 =?utf-8?B?YjR1NGpqR2Y2WEM0U1Y1aHhDbWhZU0VvMXMzTk96YTROZ3BwVWxhWmJka3ZF?=
 =?utf-8?B?d3hHNlcrVXBCY1VEMzhsMlVHcktKT01SS2ZYOHYyQnJCV2xqT21TRzRZWERY?=
 =?utf-8?B?MzV2T1hlQjBoN3ZqeWw0WUg1bXhDMzNhYmlwQ212OFFFdzdOLys4SnFoWG44?=
 =?utf-8?B?Mm42RkorSlhXZmxSNVhSeHJnUDJIT2ExUFllTUkzQlFlVE1uYnhGV2NsMWpD?=
 =?utf-8?B?Z0NDa1pLT0pSNU5IZ0tnOE1ZU05qTFJRZmZRM2hJbnhqSTVLODY1clcvVjV4?=
 =?utf-8?B?ek02dkZtdVU5VTZ1Ykx6YmlEVnZjdmpTWlRYR0IyVEh5dmxYeXZaZkRqdFZo?=
 =?utf-8?B?MHg2M0ZsYUJ4TSsySWhpbnJid24xRjR4UGU2Y2h2a1pkd0pZdkt3RDl0eU4z?=
 =?utf-8?B?Zk8wZHpSS2tnTmdKTko1ZHlZSVhLV1ZPMkNpYkJQZ2hJMVkzYUFCL1RId1VJ?=
 =?utf-8?B?N25LUkFPYzdLM3hEY0l3K0c0QnJQWVE1ckpXUGRyZ3JQcitDK0NvUTdOM1hE?=
 =?utf-8?B?Si9YQStTR3NNV0MrTjRlcFpPSFZsclB1aGs4NEw2RkNCNVhjcGpvZmpXM2xY?=
 =?utf-8?B?b05nMVRYajM4OWliREtnaWh5R2ZoWGlkRndWMzI2K2lXTzFBSUFBeXZSTzk5?=
 =?utf-8?B?T29jcG8renNtdFlNNDZSSjJVYlc4b3UwME9zckR2YUladlZmU1p3QXljaWpX?=
 =?utf-8?B?RTRtajZXQVcxeVpzTXFQQ3VJcEQxUkxZWEttME5IQTdrWHdaTHdyZHpIdTRE?=
 =?utf-8?B?WDI4RDN2RGNyNjYzR3RFcGJqWFpOa0RSZWNDamNKWDViMjBxeFhZUmEwb2h5?=
 =?utf-8?B?YmRidTB1WjFCV0JMQTJpZ2pBbmNHbFJZR3Z0NEVacHhzN2NMRFp6SWZ2eTh6?=
 =?utf-8?B?dDVZQlhzbjZBTThqcXBvaVJZcHZvdGZTcndnaGJTTmlDbzRxM1BRMTBYVkdj?=
 =?utf-8?B?V3ozTEErY25jMmZVeVVjRTRSVmVBSWdHWS9EeG5GN3M3WDVydzl0SVUzdE1m?=
 =?utf-8?B?Q0NxSGNCNDVVRGNZRjBrUGdORmlnVDJibi9MWU5lNzE3OS90ZU1lQkI4MCtD?=
 =?utf-8?B?MXZsb3AyMm9XaGV1S0JNSkxyTDlOeTErTjNlTk1aNklOSU41NElZall3VkVR?=
 =?utf-8?Q?TIgb8u5bxxhY0LdwTJIyeguDs?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02f79a65-7c92-43d4-9440-08dac00f1362
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5030.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2022 15:53:41.1271
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 82V6OFqi1bO7DRJvzc6M/90FDWySRclyWaL6rxYyhFTwNmb1RoXQgEMfulbDyinc27Y5ar/PHjCtyqCgAuV5Eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB6433
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-06_09,2022-11-03_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0
 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211060146
X-Proofpoint-ORIG-GUID: 2kAgiid6Ag2mVxo2lMWdZlukFPqEuE6h
X-Proofpoint-GUID: 2kAgiid6Ag2mVxo2lMWdZlukFPqEuE6h
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/11/2022 14:13, Maxim Levitsky wrote:
> It is valid to receive external interrupt and have broken IDT entry,
> which will lead to #GP with exit_int_into that will contain the index of
> the IDT entry (e.g any value).
> 
> Other exceptions can happen as well, like #NP or #SS
> (if stack switch fails).
> 
> Thus this warning can be user triggred and has very little value.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
>   arch/x86/kvm/svm/svm.c | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index e9cec1b692051c..36f651ce842174 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -3428,15 +3428,6 @@ static int svm_handle_exit(struct kvm_vcpu *vcpu, fastpath_t exit_fastpath)
>   		return 0;
>   	}
>   
> -	if (is_external_interrupt(svm->vmcb->control.exit_int_info) &&
> -	    exit_code != SVM_EXIT_EXCP_BASE + PF_VECTOR &&
> -	    exit_code != SVM_EXIT_NPF && exit_code != SVM_EXIT_TASK_SWITCH &&
> -	    exit_code != SVM_EXIT_INTR && exit_code != SVM_EXIT_NMI)
> -		printk(KERN_ERR "%s: unexpected exit_int_info 0x%x "
> -		       "exit_code 0x%x\n",
> -		       __func__, svm->vmcb->control.exit_int_info,
> -		       exit_code);
> -
>   	if (exit_fastpath != EXIT_FASTPATH_NONE)
>   		return 1;
>   

This was the only caller of is_external_interrupt() - should the 
definition be removed also to avoid a 'defined but not used' warning?

Regards,
Liam