Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 6 Nov 2022 16:51:09 +0100
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     wangkailong@jari.cn
Cc:     w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
        gregkh@linuxfoundation.org, speakup@linux-speakup.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] speakup: Fix warning comparing pointer to 0
Message-ID: <20221106155109.wh5ivhk2zc7cumn5@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        wangkailong@jari.cn, w.d.hubbs@gmail.com, chris@the-brannons.com,
        kirk@reisers.ca, gregkh@linuxfoundation.org,
        speakup@linux-speakup.org, linux-kernel@vger.kernel.org
References: <1de9cab8.c1.1844d7bdf4b.Coremail.wangkailong@jari.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1de9cab8.c1.1844d7bdf4b.Coremail.wangkailong@jari.cn>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

wangkailong@jari.cn, le dim. 06 nov. 2022 23:07:54 +0800, a ecrit:
> Fix the following coccicheck warning:
> 
> drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing
> pointer to 0

You're replacing it with the contrary of what it should be...

> ---
>  drivers/accessibility/speakup/utils.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac246..5803b521df2b 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
>  	else
>  		snprintf(filename, sizeof(filename), "%s", name);
>  	infile = fopen(filename, "r");
> -	if (infile == 0) {
> +	if (infile) {
>  		fprintf(stderr, "can't open %s\n", filename);
>  		exit(1);
>  	}
> -- 
> 2.25.1