Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <72d228fc27951a7ba9e607d9fc433b3c64a801e3.camel@perches.com>
Subject: Re: [PATCH] EDAC: altera: Remove unnecessary print function
 dev_err()
From:   Joe Perches <joe@perches.com>
To:     wangkailong@jari.cn, bp@alien8.de, mchehab@kernel.org,
        tony.luck@intel.com, james.morse@arm.com, rric@kernel.org
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Sun, 06 Nov 2022 08:26:04 -0800
In-Reply-To: <cf4581a.ba.1844d24fef3.Coremail.wangkailong@jari.cn>
References: <cf4581a.ba.1844d24fef3.Coremail.wangkailong@jari.cn>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2022-11-06 at 21:33 +0800, wangkailong@jari.cn wrote:
> Eliminate the follow coccicheck warning:
> 
> ./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because
> platform_get_irq() already prints an error
> ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because
> platform_get_irq() already prints an error
[]
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
[]
> @@ -2150,7 +2150,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>  
>  	edac->sb_irq = platform_get_irq(pdev, 0);
>  	if (edac->sb_irq < 0) {
> -		dev_err(&pdev->dev, "No SBERR IRQ resource\n");
>  		return edac->sb_irq;
>  	}

Should delete now unnecessary braces too

>  
> @@ -2185,7 +2184,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>  #else
>  	edac->db_irq = platform_get_irq(pdev, 1);
>  	if (edac->db_irq < 0) {
> -		dev_err(&pdev->dev, "No DBERR IRQ resource\n");
>  		return edac->db_irq;
>  	}
>  	irq_set_chained_handler_and_data(edac->db_irq,