Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a859e4c2-69b3-5531-2e96-4debe236e44a@wanadoo.fr>
Date:   Sun, 6 Nov 2022 16:56:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] recordmcount: Fix warning comparing pointer to 0
Content-Language: fr
To:     wangkailong@jari.cn, linux-kernel@vger.kernel.org
References: <10ee62bd.c2.1844d7ee28a.Coremail.wangkailong@jari.cn>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <10ee62bd.c2.1844d7ee28a.Coremail.wangkailong@jari.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 06/11/2022 à 16:11, wangkailong@jari.cn a écrit :
> Fix the following coccicheck warning:
> 
> scripts/recordmcount.c:142:13-14: WARNING comparing pointer to 0.
> 
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
> ---
>   scripts/recordmcount.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index cce12e1971d8..750f5196608c 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -139,7 +139,7 @@ static ssize_t uwrite(void const *const buf, size_t const count)
>   static void * umalloc(size_t size)
>   {
>   	void *const addr = malloc(size);
> -	if (addr == 0) {
> +	if (addr) {

Hi,
this change looks incorrect.

	if (!addr)

maybe?

CJ

>   		fprintf(stderr, "malloc failed: %zu bytes\n", size);
>   		file_append_cleanup();
>   		mmap_cleanup();