Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 6 Nov 2022 17:36:43 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Yauhen Kharuzhy <jekhor@gmail.com>
Cc:     linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH] HID: hid-sensor-custom: Allow more than one hinge angle
 sensor
Message-ID: <20221106173643.5b4f2a0b@jic23-huawei>
In-Reply-To: <20221105223422.417316-1-jekhor@gmail.com>
References: <20221105223422.417316-1-jekhor@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun,  6 Nov 2022 00:34:22 +0200
Yauhen Kharuzhy <jekhor@gmail.com> wrote:

> Some devices has two sets of accelerometers and the sensor hub exports
> two hinge angle 'sensors' based on accelerometer values. To allow more
> than one sensor of the same type, use PLATFORM_DEVID_AUTO instead of
> PLATFORM_DEVID_NONE when registering platform device for it.
> 
> Checked on the Lenovo Yoga Book YB1-X91L tablet.
> 
> Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>

Purely for curiosity sake, but where are the two sets of sensors?
Doesn't look like it has two hinges at first glance!

Jonathan

> ---
>  drivers/hid/hid-sensor-custom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c
> index 32c2306e240d6..a6fc89ee1287c 100644
> --- a/drivers/hid/hid-sensor-custom.c
> +++ b/drivers/hid/hid-sensor-custom.c
> @@ -862,7 +862,7 @@ hid_sensor_register_platform_device(struct platform_device *pdev,
>  		return ERR_PTR(-ENOMEM);
>  
>  	custom_pdev = platform_device_register_data(pdev->dev.parent, dev_name,
> -						    PLATFORM_DEVID_NONE, hsdev,
> +						    PLATFORM_DEVID_AUTO, hsdev,
>  						    sizeof(*hsdev));
>  	kfree(dev_name);
>  	return custom_pdev;