Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp593729rwb; Sun, 6 Nov 2022 10:27:32 -0800 (PST) X-Google-Smtp-Source: AMsMyM5zRbt31k7bVFjZG3kWx+yCgNbgUEMqkhpBL4epO4BM1YXq0Zo6bq7ndPHCGls6Y/VzmOe1 X-Received: by 2002:a17:907:a4e:b0:77d:94d:8148 with SMTP id be14-20020a1709070a4e00b0077d094d8148mr42505597ejc.607.1667759252098; Sun, 06 Nov 2022 10:27:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667759252; cv=none; d=google.com; s=arc-20160816; b=YSLlbLj3jIe6TkqQmZsR0He41nrwKr8i+nXAXDaoKtAswsq/rGf+uFW50GP3V+l2dn rjI3xnNeXsC6fPygsiAXMxvBNXEjQa2QOhh3o6RIiLVHxlg+vG3/MHJ9vvjMM2EvAnbC zzB0QW5MXHmYQ396ct0nvShRpziiTGMgZ45Arb7BBBdeP3NVl6lJjv9ntHNvRYKOTadp hGFYLSfEiNL0JuANQFq5PHhEVof3YL6/MtjXpbhMVJHFRkIxB8WI6L6YnxRQc0P25UDf cPGeWiiYzTsvepJDAjbemhYL74tJe4jSs4t2NGlR6J4euS/et0X7KSHTLZ4FEyF9j8mS tafw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dORDGE2aRdkqRzPdGEYY5pkivft7kNUEWudB+nkhZbE=; b=fYQzrxgbtWzpAGNDrJvc5LbIeUSFNBNoSSIsb2ysa6eNnKJNA03tN0XCl8AGo/dQQw j4NzaVjdLXfgPuP6OFG7O5IKTu6tmFH+2c67NDvT7fsWciRyjy/4Q860kl1xKBv2s3v2 GKZOK6yuaRtxFJ+wxOhqdO9pnCF1tzruVDCo22tesM+kNoy7LIb6zXgbHgmPKmzZIqI8 7Eu4Lla+lLxlbn4kuc6jlaoUhQTXknRXX0FQoTWDb2eYCERy/a32xQle9iV1NocdWPiz yU1L9/A17KXJkoC83Gebs6twf77XaJZ/3yu4niRO0bgaomxyV5dYYUMc7WAyWlbCxeB9 GVYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="jMSEztp/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a170906728300b0078d550c0272si5784033ejl.269.2022.11.06.10.27.08; Sun, 06 Nov 2022 10:27:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="jMSEztp/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231295AbiKFRKw (ORCPT + 96 others); Sun, 6 Nov 2022 12:10:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231174AbiKFRKR (ORCPT ); Sun, 6 Nov 2022 12:10:17 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1F7D13F72; Sun, 6 Nov 2022 09:06:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C5D9860D2C; Sun, 6 Nov 2022 17:06:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16762C433D6; Sun, 6 Nov 2022 17:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667754403; bh=vczTo+3PmWL+4BALxrRkYT1pHu2q6iwT5EFYiSxxAF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jMSEztp/vsaP4t5itGy/Bk8LiJ99K0owQ52ttJQ9g3V17bcQkWmOf7dWONLE5xdjN mTQEUQdeLGoL3N6mv1Zwp1RhyX/3NQ0lLW/wN70BfnKrJx0aO+jV/CaKSFIxuuSR3s Jbi38R8iVZL6ES6/y/broHfiZ9YqIkVKktASc5/KXCaFJ98wsGdWrSIT+sZkClepmj fIUSENga6MMZ5R4eu+pVSLKMIzvCppuD9BD2HsZilntxS5bUJYQ8GQ9RkNiFPZTabH iTLNR07MX3Qexr2V2mI7LgrQ4bULhBh+YlZXSj+rM+IgBA7+MzqZMeAz3TDJvupraa y6jWEdEhMgGNw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhang Qilong , Charles Keepax , Mark Brown , Sasha Levin , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, patches@opensource.cirrus.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.4 02/12] ASoC: wm5110: Revert "ASoC: wm5110: Fix PM disable depth imbalance in wm5110_probe" Date: Sun, 6 Nov 2022 12:06:26 -0500 Message-Id: <20221106170637.1580802-2-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221106170637.1580802-1-sashal@kernel.org> References: <20221106170637.1580802-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhang Qilong [ Upstream commit 7d4e966f4cd73ff69bf06934e8e14a33fb7ef447 ] This reverts commit 86b46bf1feb83898d89a2b4a8d08d21e9ea277a7. The pm_runtime_disable is redundant when error returns in wm5110_probe, we just revert the old patch to fix it. Signed-off-by: Zhang Qilong Acked-by: Charles Keepax Link: https://lore.kernel.org/r/20221010114852.88127-3-zhangqilong3@huawei.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wm5110.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm5110.c b/sound/soc/codecs/wm5110.c index bbe9fdfb423c..06ec3f48c808 100644 --- a/sound/soc/codecs/wm5110.c +++ b/sound/soc/codecs/wm5110.c @@ -2452,6 +2452,9 @@ static int wm5110_probe(struct platform_device *pdev) regmap_update_bits(arizona->regmap, wm5110_digital_vu[i], WM5110_DIG_VU, WM5110_DIG_VU); + pm_runtime_enable(&pdev->dev); + pm_runtime_idle(&pdev->dev); + ret = arizona_request_irq(arizona, ARIZONA_IRQ_DSP_IRQ1, "ADSP2 Compressed IRQ", wm5110_adsp2_irq, wm5110); @@ -2484,9 +2487,6 @@ static int wm5110_probe(struct platform_device *pdev) goto err_spk_irqs; } - pm_runtime_enable(&pdev->dev); - pm_runtime_idle(&pdev->dev); - return ret; err_spk_irqs: -- 2.35.1