Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6b8bd5b63a69390a7facba39339c75255f57f2c4.camel@gmail.com>
Subject: Re: [PATCH v2 1/2] i2c: core: Introduce i2c_client_get_device_id
 helper function
From:   Angel Iglesias <ang.iglesiasg@gmail.com>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Wolfram Sang <wsa@kernel.org>, linux-i2c@vger.kernel.org
Date:   Sun, 06 Nov 2022 18:50:40 +0100
In-Reply-To: <20221106172249.30241713@jic23-huawei>
References: <cover.1667750698.git.ang.iglesiasg@gmail.com>
         <bb8d7f33c6b9e960d542c3951101587b4ddfaef6.1667750698.git.ang.iglesiasg@gmail.com>
         <20221106172249.30241713@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.1 (by Flathub.org) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2022-11-06 at 17:22 +0000, Jonathan Cameron wrote:
> On Sun,=C2=A0 6 Nov 2022 17:42:24 +0100
> Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
>=20
> > Introduces new helper function to aid in .probe_new() refactors. In ord=
er
> > to use existing i2c_get_device_id() on the probe callback, the device
> > match table needs to be accessible in that function, which would requir=
e
> > bigger refactors in some drivers using the deprecated .probe callback.
> >=20
> > This issue was discussed in more detail in the IIO mailing list.
> >=20
> > Link:
> > https://lore.kernel.org/all/20221023132302.911644-11-u.kleine-koenig@pe=
ngutronix.de/
> > Suggested-by: Nuno S=C3=A1 <noname.nuno@gmail.com>
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Suggested-by: Jonathan Cameron <jic23@kernel.org>
> > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>=20
> Trivial comment inline - otherwise lgtm
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>=20
> Thanks,
>=20
> >=20
> > diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> > index b4edf10e8fd0..920676e62c22 100644
> > --- a/drivers/i2c/i2c-core-base.c
> > +++ b/drivers/i2c/i2c-core-base.c
> > @@ -2236,6 +2236,21 @@ int i2c_get_device_id(const struct i2c_client
> > *client,
> > =C2=A0}
> > =C2=A0EXPORT_SYMBOL_GPL(i2c_get_device_id);
> > =C2=A0
> > +/**
> > + * i2c_client_get_device_id - get the driver match table entry of a de=
vice
> > + * @client: the device to query. The device must be bound to a driver =
or
> > + *=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 the function oopses=
.
>=20
> Maybe don't state what happens otherwise if something changes to make it
> instead do something else unfortunate, this comment will need updating.
> "The device must be bound to a driver."

Sure, sorry for the trouble. I'll wait a bit for more comments and then sen=
d v3
fixed.

Thanks for your time,
Angel

>=20
> > + *
> > + * Returns a pointer to the matching entry if found, NULL otherwise.
> > + */
> > +const struct i2c_device_id *i2c_client_get_device_id(const struct
> > i2c_client *client)
> > +{
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0const struct i2c_driver *drv=
 =3D to_i2c_driver(client->dev.driver);
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return i2c_match_id(drv->id_=
table, client);
> > +}
> > +EXPORT_SYMBOL_GPL(i2c_client_get_device_id);
> > +
> > =C2=A0/* ----------------------------------------------------
> > =C2=A0 * the i2c address scanning function
> > =C2=A0 * Will not work for 10-bit addresses!
> > diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> > index f7c49bbdb8a1..d84e0e99f084 100644
> > --- a/include/linux/i2c.h
> > +++ b/include/linux/i2c.h
> > @@ -189,6 +189,7 @@ s32 i2c_smbus_read_i2c_block_data_or_emulated(const
> > struct i2c_client *client,
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 u8 *values);
> > =C2=A0int i2c_get_device_id(const struct i2c_client *client,
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct i2c_device=
_identity *id);
> > +const struct i2c_device_id *i2c_client_get_device_id(const struct
> > i2c_client *client);
> > =C2=A0#endif /* I2C */
> > =C2=A0
> > =C2=A0/**
>=20