Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp881388rwb; Sun, 6 Nov 2022 15:36:26 -0800 (PST) X-Google-Smtp-Source: AMsMyM4lUMwshY4suUyazrKmBFmEdGPcXzksytdtYafHm50mnN3cfz+ZMOW54FGbP6v973LZYcHF X-Received: by 2002:a17:907:1b09:b0:7ac:db30:2cf0 with SMTP id mp9-20020a1709071b0900b007acdb302cf0mr45116121ejc.679.1667777786187; Sun, 06 Nov 2022 15:36:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667777786; cv=none; d=google.com; s=arc-20160816; b=Da2i7WURkeHFNdY7n+wtjdGQ90wYGmHFEHXExdf9ayukytuEicxvBXjk6iNgqO7hq4 MnPYcLgQ0hYvOqb+4ZE/uevMhcvEzR1tkO09Tf3R8l7cTBHSpVvppHsqk3mNYnD/FfQe nN8qYb9PaeawQRP9PeuXt2YLRtKgnOVXFm51TNlJSVg8feqHRDa1Pzast3WEIMFUXu7K +iouVbBFbH1pSPgIhGUqnYtWoAcuEad/rqBFFeN7XOZM9vK2Q8rrA0EomF+0vXACa8h/ lw6QD3H74Y1IwpvN/yFZoSr4F0LTCRoxdUqPMFVTIgoIEHkYZYwtWEBNbRaYOUpF4mr3 BjoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=YMwhUdD7bJqhRjq/0+VFQ/maKpbXWuQ3pjGXc4TlIco=; b=viTorWvHqk9eA2cvxJT+NO9LG2ApSKYFMuUz5KCuXHLvj2YFSCStqP0EbEz6kAEAw7 bwYUhG8Sb8At2HxgKYHemXrPnNaUwV3kJYe3TXnV17gFNPpGBSxhstgIad+xxUSyfw0x YyKQwmMHRvQkawTa51/QIIo/Shaww2m7IdlOZhwY3R+eU0cmdLkm+wJpeqbqtvOPxtlL 57LyHucWTd5GNECNJf923zBHojC8kcv0y01am9Lzaor2pQR/zD7UKSoG6dC23/z+03Tb n8XN8TZOA/TLuDDR5ZUGIQkjU0Jti9vCla3tFkpdrkFYmqOVB8NbkiakiVbUKZeFwTu3 +EAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=t2Hn6iF0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kz16-20020a17090777d000b007a65a87f839si5976222ejc.114.2022.11.06.15.35.57; Sun, 06 Nov 2022 15:36:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=t2Hn6iF0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229993AbiKFXOW (ORCPT + 96 others); Sun, 6 Nov 2022 18:14:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiKFXOU (ORCPT ); Sun, 6 Nov 2022 18:14:20 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32BED6555; Sun, 6 Nov 2022 15:14:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9817160DF0; Sun, 6 Nov 2022 23:14:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04B42C433D6; Sun, 6 Nov 2022 23:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1667776459; bh=HOqaI7ArwDGzuQ5p7MrsUrsps/fJVCnEkG8E4CJJdxY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t2Hn6iF051vqTzh/OW0vMOekHbmoVvG+Iep+IuHA4FsMgfctc6LAsxbfYWPKtY8hG 8VRmEWE4hnLBKhfArvuvdxLtXldGFFFTm/F01YdJWQ7pTMFyHvwYkaKxtcv8yfyYgl 4K76072ETaMOid7a/pVXQTV6RsFv1lVjQwEq9R1g= Date: Sun, 6 Nov 2022 15:14:16 -0800 From: Andrew Morton To: Linus Torvalds Cc: Hugh Dickins , Johannes Weiner , Stephen Rothwell , Alexander Gordeev , Peter Zijlstra , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Nadav Amit , Jann Horn , John Hubbard , X86 ML , Matthew Wilcox , kernel list , Linux-MM , Andrea Arcangeli , "Kirill A . Shutemov" , Joerg Roedel , Uros Bizjak , Alistair Popple , linux-arch Subject: Re: mm: delay rmap removal until after TLB flush Message-Id: <20221106151416.bc2f942f237de31b6c577e70@linux-foundation.org> In-Reply-To: References: <140B437E-B994-45B7-8DAC-E9B66885BEEF@gmail.com> <8a1e97c9-bd5-7473-6da8-2aa75198fbe8@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 6 Nov 2022 14:34:51 -0800 Linus Torvalds wrote: > > mm-unstable (bad) > > ----------------- > > Aside from that PageAnon issue, mm-unstable is in an understandably bad > > state because you could not have foreseen my subpages_mapcount addition > > to page_remove_rmap(). page_zap_pte_rmap() now needs to handle the > > PageCompound (but not the "compound") case too. I rushed you and akpm > > an emergency patch for that on Friday night, but you, let's say, had > > reservations about it. So I haven't posted it, and while the PageAnon > > issue remains, I think your patchset has to be removed from mm-unstable > > and linux-next anyway. > > So I think I'm fine with your patch, I just want to move the memcg > accounting to outside of it. > > I can re-do my series on top of mm-unstable, I guess. That's probably > the easiest way to handle this all. > > Andrew - can you remove those patches again, and I'll create a new > series for you? Yes, I've removed both serieses and shall push the tree out within half an hour from now.