Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
 CMU_FSYS1 mmc card clock
Reply-To: chanho61.park@samsung.com
Sender: CHANHO PARK <chanho61.park@samsung.com>
From:   CHANHO PARK <chanho61.park@samsung.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Inbaraj E <inbaraj.e@samsung.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        "tomasz.figa@gmail.com" <tomasz.figa@gmail.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        CHANHO PARK <chanho61.park@samsung.com>
CC:     "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        PANKAJ KUMAR DUBEY <pankaj.dubey@samsung.com>
In-Reply-To: <8f026f38-ef09-788e-7bd8-45683b074075@linaro.org>
Message-ID: <20221107000401epcms2p3eeeecbfb2b1cdfb30dcee99bbb48780c@epcms2p3>
Date:   Mon, 07 Nov 2022 09:04:01 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <8f026f38-ef09-788e-7bd8-45683b074075@linaro.org>
        <20221104090019.88387-1-inbaraj.e@samsung.com>
        <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcms2p3>
Precedence: bulk

> > Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
> >
> > This fixes make dtbs_check warning as shown below:
> >
> > arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
> controller@17040000:
> > clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From schema:
> > /home/inbaraj/mainline/linux/Documentation/devicetree/
> > bindings/clock/samsung,exynosautov9-clock.yaml
> 
> I don't understand:
> 1. Why bindings are wrong not DTSI?
> 2. What is "gout"? "dout" had a meaning as clock divider output.

"gout" is output of a gate clock, AFAIK.
Unlike any other clocks, the fsys1 mmc top clock does not have a divider. So, it should be "mout -> gout" instead of "mout -> gout -> dout".

> 
> >
> > Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for
> > cmu_fsys0/1")
> > Signed-off-by: Inbaraj <inbaraj.e@samsung.com>

Reviewed-by: Chanho Park <chanho61.park@samsung.com>

Best Regards,
Chanho Park