Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 6 Nov 2022 20:17:07 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        LKML Mailing List <linux-kernel@vger.kernel.org>,
        X86-kernel <x86@kernel.org>, Tony Luck <tony.luck@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Arjan van de Ven <arjan.van.de.ven@intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        "Jacon Jun Pan" <jacob.jun.pan@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "Kai Huang" <kai.huang@intel.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [v2 01/13] x86/microcode/intel: Prevent printing updated
 microcode rev multiple times
Message-ID: <Y2iGw8U8JGMJ+aKq@a4bf019067fa.jf.intel.com>
References: <20221103175901.164783-1-ashok.raj@intel.com>
 <20221103175901.164783-2-ashok.raj@intel.com>
 <Y2e4PgwAEXuFzoMd@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y2e4PgwAEXuFzoMd@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nijy5ySB38mnDTIHxSGWVEEe/TrwKfisj7Vz2IB/hHYZyR3WAhfD9WHnHcsj?=
 =?us-ascii?Q?hSXG+vnJkITSj2sz5sZNTSDb8LwkabLJIKeuJfnRO+k+lKJtZ8hF1TRyiEhL?=
 =?us-ascii?Q?peG1wMV61duykCvvV9t3uDK0iseVvr6Rc7iSN3CaXQdEHVFyh895IDjOeWcy?=
 =?us-ascii?Q?oh3gRuylgekULnxxunby9/Z7dKgcQ93wyIp0/b5JiJoiqpTblWSXHHE5vqKt?=
 =?us-ascii?Q?9dOaGgns7HBe/7L/C7GSKCTT7keB5QNuCu+z0w2b+U21yP51rNxnJDHXzK4v?=
 =?us-ascii?Q?fNujunnZY+BJjVnlr1EOZb2ykCdcrurSjeyBu8S/nKHpS2uF4MCjzryigdiE?=
 =?us-ascii?Q?3KCcLC1VmMvnzHf8YLvAHTt3gMwyN1ZcXLoGdly7+Ib/iFqwFV/JvRncWOay?=
 =?us-ascii?Q?25t4rZTi6r7PATY4u/MsPGjs5Rv1RwnRybdn6Bhy/2gCffHiEtE0KJIYxNIY?=
 =?us-ascii?Q?7o0S0z1aWlHKHefCxtxL/FBEQhyH7ZNtfRN1m8WoC2aJk5ExLcg5ENPPsOik?=
 =?us-ascii?Q?Xw6iyvaEGF1Zf0cmz/2qieyWxHywCHRGq8UKEga4OK7cjFkMwhybn3I5mjdK?=
 =?us-ascii?Q?aYlw/btlg5su1ktiu+YOIGwskcWno76GjLH5WUjvXTz1ZJtnuYmZ64LjxH0s?=
 =?us-ascii?Q?DKLWPC1NLT+E5xzcamP17y7fOjDYmSImnMI41r0Mvpj1c9PvE2c10DdU0doi?=
 =?us-ascii?Q?yD4TVb7qzByJF9qVfOYd6xkgu5xczGoOjjvvsssQDv1YnurHHwwoIQUnLnvT?=
 =?us-ascii?Q?lH/GAjq8IXkc5orL0PwJHfro+pxKcvsRTaQt3gWEEf4kv5QcA7dVp9lgjhKu?=
 =?us-ascii?Q?3SifuRa0EcgsqINBb3aBb+lLP13MAy7CV9IAXoRgA3qmIHejOC30hpH+Hrik?=
 =?us-ascii?Q?2hjNYJS9Tkyvd32308+GtirLmaGD/YgYjmWgxsGQWJ/2f+8CmmWds1/6/5EK?=
 =?us-ascii?Q?OrD7VeyqY6FwHOXekUXZfqjiw2diVb/zP7Lyx7yQXyBmpPuwJ7e4sGUIuGHb?=
 =?us-ascii?Q?rj85Xzy3idBOSiAswJBeSEbAn3WbrWC5KoBL41Rjzzx8rSuiNerDci4n9edx?=
 =?us-ascii?Q?TPHwSWWS1JnDUNK3DyJuWtaYkUZdKvvFwh6Nw7sha74rAa01581OdLXgSvlw?=
 =?us-ascii?Q?mpOuxyoq2hL2S2FutNdMgZ777FE6OHFvY4Qi0bp/5Uu1UxgVqz9pSXJ94Dzy?=
 =?us-ascii?Q?rM9FBFk5DrUdTTI+FYVqtQlbvCEW1LmsAIGIWWxtUIeMUBZSZng4kPDoaJah?=
 =?us-ascii?Q?7q6+qRLNqgP+0WDZlsGgEUXWGweKjcnRhwVloxTDO5AUcIBBDOrwB85CFBBT?=
 =?us-ascii?Q?cH3+6L8sz4A12kx91u8LXS2rA283v5j9ik1YFiYRTqTTXaWjO71WSnUq1gmT?=
 =?us-ascii?Q?PnWlU/0pURIol04jHDP57+esMXtoRCirkKAv8V5OQakvvXxHykHj7y+4Wmc2?=
 =?us-ascii?Q?WQ4SFc608ezB2CyUScGDvL71HHqpTkbmDdKXKojasT7FYvzC6YwD4WT6E6fs?=
 =?us-ascii?Q?9ZZ5YZ7Mg3GRdUTU5Jbenj6K8ctbg9jXxnQeEXMBhO7sFqWDAjsJCpHhjFdn?=
 =?us-ascii?Q?QLP8hbwbXdK9gZUF87szBR4it8gKF1cv1ZGXtFrwRk2N+sIbFmp8VEx1mmVa?=
 =?us-ascii?Q?xw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82c656c8-1510-4991-6e8f-08dac076f0c3
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 04:17:10.5609
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nERRkVCR9zB82g5Pn+eHccgAnoui2X3B5Er+LeMi3F/4CpyhKXP0QBMIh1bn9OOx+EEobGYEl+9L/DB15c1xCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5218
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 06, 2022 at 02:35:58PM +0100, Borislav Petkov wrote:
> On Thu, Nov 03, 2022 at 05:58:49PM +0000, Ashok Raj wrote:
> > @@ -696,8 +697,7 @@ static int collect_cpu_info(int cpu_num, struct cpu_signature *csig)
> >  
> >  	csig->rev = c->microcode;
> >  
> > -	/* No extra locking on prev, races are harmless. */
> > -	if (csig->sig != prev.sig || csig->pf != prev.pf || csig->rev != prev.rev) {
> > +	if (bsp && csig->rev != prev.rev) {
> >  		pr_info("sig=0x%x, pf=0x%x, revision=0x%x\n",
> >  			csig->sig, csig->pf, csig->rev);
> 
> And now that we've established that we don't do mixed steppings anymore
> and the microcode revision is the same system-wide, you should simply
> drop this pr_info(), in your next patch you're adding
> 
> +static u32 early_old_rev;
> 
> That thing should simply be
> 
> /* Currently applied microcode revision */
> static u32 microcode_rev;
> 
> and you simply update that one each time you update microcode and print
> it as the previous and the new one and then write the new one into this
> var and that's it. Simple.
> 

I thought about it... Since microcode/core.c already provides this
information. Only missing part is the microcode date which the common
function doesn't seem to get this. Thought it might be useful. But I can
certainly drop it, if you think this isn't much value.