Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1256169rwb; Sun, 6 Nov 2022 22:27:34 -0800 (PST) X-Google-Smtp-Source: AMsMyM52OOi0SfysXLKEVzy9qSgSlr7FoPtt6WEBL0di4pc1nPUTxsRDCtstzmcoJZtAHJpD3ayV X-Received: by 2002:a05:6402:c07:b0:461:87ab:78aa with SMTP id co7-20020a0564020c0700b0046187ab78aamr49456242edb.258.1667802454276; Sun, 06 Nov 2022 22:27:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667802454; cv=none; d=google.com; s=arc-20160816; b=GW+o6miDjlbtSGV+MZBhalW1J7iHL7humMVa7iYGtjMFHPMSIdvljAedP5qok2+4Pt WWcqeVzaQ1ufs9ynfR3qbIHTIjqkjG3t8mCBPsr+wLu0Xtt/Hgk2rO7NR7+Fj3VruPcO +Mzg9P88EqbETuGoeHkEc/OOptshnPdFhHPtduL0MpYel+FLqfMmg+QSx1OZNAkJ+3x7 XSIoXjjyQOG50zVgSPCtUEPZsNWs9cSMCC/aNlUK1ya2/te0mxIt7WWzm8mYGAUkatkU gML/Z6pZS60kfFWzqE8oErehPpAKDND4TvO4QOyL6/1jM8RA92H0lMxFBBWdeImeRFOg r0Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=mL+bF2JAOIThySdRAYwZKCo8/3AMsLdhB0aTu5BUkLok7ZToBZV+JeVXVROCp4GKGG LFN8ZHuonv6N1vlftnAxkLJru2pgCIDPd32nVUmOrX2x2gA82ybrghXja4RimN2CXIyx 8xfz/t6C4a4PTGTd7IIBrDGtpjPJ1f/M8l/WGHSVHUo7B7wNzV0l4uQWKvJ3d3hX/pRH 8oZFCoa9yzjsyAGLWuaJCCTuU2UndC2T6gxHa6RLlFwdWwXn63/XCD0c8q63qK5pMOY4 IpLMxQR7rOyOfCmMFxFvrow6kCdK8WMA0uoDbPtjgtigpnR4TQhpi3xtIzDF7t//bkjq qBUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z8-20020a05640240c800b00462dee0d6bfsi10160342edb.556.2022.11.06.22.27.11; Sun, 06 Nov 2022 22:27:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231172AbiKGF4w (ORCPT + 95 others); Mon, 7 Nov 2022 00:56:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231177AbiKGF4u (ORCPT ); Mon, 7 Nov 2022 00:56:50 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8CA1BCBF; Sun, 6 Nov 2022 21:56:49 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 5615B68BFE; Mon, 7 Nov 2022 06:56:47 +0100 (CET) Date: Mon, 7 Nov 2022 06:56:47 +0100 From: Christoph Hellwig To: Yu Kuai Cc: hch@lst.de, tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, yukuai3@huawei.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH v2 5/5] blk-iocost: read params inside lock in sysfs apis Message-ID: <20221107055647.GH28873@lst.de> References: <20221104023938.2346986-1-yukuai1@huaweicloud.com> <20221104023938.2346986-6-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221104023938.2346986-6-yukuai1@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig