Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Nov 2022 08:41:27 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc:     andrew.gospodarek@broadcom.com, davem@davemloft.net,
        edumazet@google.com, jgg@ziepe.ca, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
        michael.chan@broadcom.com, netdev@vger.kernel.org,
        pabeni@redhat.com, selvin.xavier@broadcom.com
Subject: Re: [PATCH v3 5/6] bnxt_en: Use auxiliary bus calls over proprietary
 calls
Message-ID: <Y2iol/ypwVMqrpQT@unreal>
References: <CACZ4nhtmE9Dh9z_O9-A934+q0_8yHEyj+V-DcEsuEWFbPH6BGg@mail.gmail.com>
 <20221104162733.73345-1-ajit.khaparde@broadcom.com>
 <20221104162733.73345-6-ajit.khaparde@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221104162733.73345-6-ajit.khaparde@broadcom.com>
Precedence: bulk

On Fri, Nov 04, 2022 at 09:27:32AM -0700, Ajit Khaparde wrote:
> Wherever possible use the function ops provided by auxiliary bus
> instead of using proprietary ops.
> 
> Defined bnxt_re_suspend and bnxt_re_resume calls which can be
> invoked by the bnxt_en driver instead of the ULP stop/start calls.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/main.c          | 102 +++++++++++-------
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c |  40 ++++---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h |   2 -
>  3 files changed, 87 insertions(+), 57 deletions(-)

<...>

>  void bnxt_ulp_sriov_cfg(struct bnxt *bp, int num_vfs)
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h
> index 26b7c627342b..e96f93d38a30 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h
> @@ -29,8 +29,6 @@ struct bnxt_msix_entry {
>  struct bnxt_ulp_ops {

Once you convert to use AUX bus, this struct should go too.

>  	/* async_notifier() cannot sleep (in BH context) */
>  	void (*ulp_async_notifier)(void *, struct hwrm_async_event_cmpl *);
> -	void (*ulp_stop)(void *);
> -	void (*ulp_start)(void *);
>  	void (*ulp_sriov_config)(void *, int);
>  	void (*ulp_shutdown)(void *);
>  	void (*ulp_irq_stop)(void *);
> -- 
> 2.37.1 (Apple Git-137.1)
>