Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1411942rwb; Mon, 7 Nov 2022 01:05:33 -0800 (PST) X-Google-Smtp-Source: AMsMyM7OA72rFyiNvxj2KDPykPF81lETkIF07hr7yQ+C3sru0B7E26fjO4yBusYolE/FOOsAa6Ol X-Received: by 2002:a17:907:7d8f:b0:78e:2cba:560f with SMTP id oz15-20020a1709077d8f00b0078e2cba560fmr47134416ejc.173.1667811933567; Mon, 07 Nov 2022 01:05:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667811933; cv=none; d=google.com; s=arc-20160816; b=J58uPbpt0kK7yzC9gFJXx5zBIqJ1D83e8FLanoP4HsbxRIjKxrmPx4z6UrMXCaTfAG DeFJlaqa4bbIGvBpzSlUdaxfvHU+TZhZCiphin39Lg63GCyRHffrP8xw8ZDbyKUtOj8B YqQUBPw7RZ93Zjc21bloJVj4dAHqW+caw9Q7EYlfnn1peiHyUs3PzHrZ4ONeunfHR/ZG Xc/72FboIADepBgR0IyhzwTphuqWorgvUecGkwQv6Ho5Dvju5k6HLsW5Gggy3UNXhqUX 2ONscG0rnipOrM8beZu6h+Hn5VRlxxnR3dwu6wWvMp/GIhSfAqe60vptiKoLujVkNlly 5t9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vgdFZIM9usLbUHOfcyw4uubYpBcgbom4JPVldXuy06E=; b=VVbFvAiV7E6SxBFhxRpKZGvakTlR/j+R69vbp73WLTH23C5KUELg+TF4VamqModKTx XSMl1nZFt7UbP94HvEQGz3RecYTXuKpisXM5VUbzrj/D6BHp8fTSsx2zKvhZwwFMsOqb mjxmU2URxkxtNKtA7vgj4hj5wt9CIQDwmbdYVKqthfsZxMoxEWlQnOVYNLg84qdHSmWl 2S0trT9fbgQEj7lWBUlCBtY4nl9P6qJthCk3xLMlgYjeoymN/paRdVXaORqh+sg0yLje IyHjaCsuA2QMiLeTX2KeU3LsxVeQdClupEDSfQotmHcsWVDskiAIzVptEcdmxb/uUv4p X/0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=P73ZNbub; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e20-20020a170906c01400b007891fd9179bsi7038095ejz.150.2022.11.07.01.05.10; Mon, 07 Nov 2022 01:05:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=P73ZNbub; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231484AbiKGI4z (ORCPT + 96 others); Mon, 7 Nov 2022 03:56:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230470AbiKGI4t (ORCPT ); Mon, 7 Nov 2022 03:56:49 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 540C41408B; Mon, 7 Nov 2022 00:56:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 07BCEB80E71; Mon, 7 Nov 2022 08:56:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CA46C433D7; Mon, 7 Nov 2022 08:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667811405; bh=vgdFZIM9usLbUHOfcyw4uubYpBcgbom4JPVldXuy06E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P73ZNbubEi3IVs6LMykRCDzv2dlKafrHUhWQi3OsgTA8kyxjldwX2WE8hPOAGrb8f bPoIM7+JIabgErIwe5H1f9KXivSR6jCpicLPrYgkc4l0jTvLW8wpFAefvNbQfmE7RW ov+fRzzlJ0wJwZrX7qDKDae9HfNh6Qmy8QkCzrIA= Date: Mon, 7 Nov 2022 09:56:42 +0100 From: Greg KH To: Jonas Rabenstein Cc: stable@vger.kernel.org, Jiri Olsa , Song Liu , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Steven Rostedt , Masami Hiramatsu , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bpf: mark get_entry_ip as __maybe_unused Message-ID: References: <20221103150303.974028-1-rabenstein@cs.fau.de> <20221103153247.zal3czlsxvanfnc3@kashyyyk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221103153247.zal3czlsxvanfnc3@kashyyyk> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 03, 2022 at 04:32:47PM +0100, Jonas Rabenstein wrote: > Hi again, > after sending this out, I noticed this is only a problem in the stable > versions (starting from v6.0.3), as c09eb2e578eb1668bbc has been applied (as > 03f148c159a250dd454) but not 0e253f7e558a3e250902 ("bpf: Return value in kprobe > get_func_ip only for entry address") which makes always use of get_entry_ip. > I therefore think, 0e253f7e558a3e250902 needs to be added to the stable v6.0 > series as well as otherwise it can't be compiled with -Werror if > CONFIG_X6_KERNEL_IBT is set but CONFIG_FPROBE isn't. Ok, now queued up, thanks. greg k-h