Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Mon, 7 Nov 2022 09:26:30 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Cc:     emma@anholt.net, airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: hdmi: Fix pointer dereference before check
Message-ID: <20221107082630.tjebvwt4hevhdsos@houat>
References: <20221029093413.546103-1-jose.exposito89@gmail.com>
 <20221102090153.tujblkvd3jlhdtxr@houat>
 <20221102111003.GA3233@elementary>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20221102111003.GA3233@elementary>
Precedence: bulk

On Wed, Nov 02, 2022 at 12:10:03PM +0100, Jos=E9 Exp=F3sito wrote:
> Hi Maxime,
>=20
> Thanks a lot for looking into the patch.
>=20
> On Wed, Nov 02, 2022 at 10:01:53AM +0100, Maxime Ripard wrote:
> > Hi,
> >=20
> > On Sat, Oct 29, 2022 at 11:34:13AM +0200, Jos=E9 Exp=F3sito wrote:
> > > Commit 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link on hotplug") introduc=
ed
> > > the vc4_hdmi_reset_link() function. This function dereferences the
> > > "connector" pointer before checking whether it is NULL or not.
> > >=20
> > > Rework variable assignment to avoid this issue.
> > >=20
> > > Fixes: 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link on hotplug")
> > > Signed-off-by: Jos=E9 Exp=F3sito <jose.exposito89@gmail.com>
> > > ---
> > >  drivers/gpu/drm/vc4/vc4_hdmi.c | 10 +++++++---
> > >  1 file changed, 7 insertions(+), 3 deletions(-)
> > >=20
> > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4=
_hdmi.c
> > > index 4a73fafca51b..07d058b6afb7 100644
> > > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> > > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> > > @@ -319,9 +319,9 @@ static int reset_pipe(struct drm_crtc *crtc,
> > >  static int vc4_hdmi_reset_link(struct drm_connector *connector,
> > >  			       struct drm_modeset_acquire_ctx *ctx)
> > >  {
> > > -	struct drm_device *drm =3D connector->dev;
> > > -	struct vc4_hdmi *vc4_hdmi =3D connector_to_vc4_hdmi(connector);
> > > -	struct drm_encoder *encoder =3D &vc4_hdmi->encoder.base;
> > > +	struct drm_device *drm;
> > > +	struct vc4_hdmi *vc4_hdmi;
> > > +	struct drm_encoder *encoder;
> > >  	struct drm_connector_state *conn_state;
> > >  	struct drm_crtc_state *crtc_state;
> > >  	struct drm_crtc *crtc;
> > > @@ -332,6 +332,10 @@ static int vc4_hdmi_reset_link(struct drm_connec=
tor *connector,
> > >  	if (!connector)
> > >  		return 0;
> > > =20
> > > +	drm =3D connector->dev;
> > > +	vc4_hdmi =3D connector_to_vc4_hdmi(connector);
> > > +	encoder =3D &vc4_hdmi->encoder.base;
> > > +
> >=20
> > I don't think that's right. Connector shouldn't be NULL to begin with,
> > how did you notice this?
> >=20
> > Maxime
>=20
> This issue was reported by Coverity. At the moment this function is not
> invoked with a NULL connector by any code path. However, since the NULL
> check is present, in my opinion, it makes sense to either remove it or
> make it usefull just in case the preconditions change in the future.

Yeah, it makes sense

I'd ask for a small cosmetic change then, could you add the assignments
where they are actually needed instead of at the top of the function?

Something like

 if (!connector)
 	return 0;

+drm =3D connector->dev;
 ret =3D drm_modeset_lock(&drm->mode_config.connection_mutex, ctx);

=2E..

+vc4_hdmi =3D connector_to_vc4_hdmi(connector);
 if (!vc4_hdmi_supports_scrambling(vc4_hdmi))

=2E..

Changing the prototype of vc4_hdmi_supports_scrambling to take a struct
vc4_hdmi pointer would also help, it's much more convenient.

Maxime