Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0e929d35-2a90-94fb-49d6-7f6a0f0a3ed0@linaro.org>
Date:   Mon, 7 Nov 2022 10:12:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
 CMU_FSYS1 mmc card clock
Content-Language: en-US
To:     chanho61.park@samsung.com, Inbaraj E <inbaraj.e@samsung.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        "tomasz.figa@gmail.com" <tomasz.figa@gmail.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>
Cc:     "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        PANKAJ KUMAR DUBEY <pankaj.dubey@samsung.com>
References: <8f026f38-ef09-788e-7bd8-45683b074075@linaro.org>
 <20221104090019.88387-1-inbaraj.e@samsung.com>
 <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcms2p3>
 <20221107000401epcms2p3eeeecbfb2b1cdfb30dcee99bbb48780c@epcms2p3>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20221107000401epcms2p3eeeecbfb2b1cdfb30dcee99bbb48780c@epcms2p3>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07/11/2022 01:04, CHANHO PARK wrote:
>>> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
>>>
>>> This fixes make dtbs_check warning as shown below:
>>>
>>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
>> controller@17040000:
>>> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From schema:
>>> /home/inbaraj/mainline/linux/Documentation/devicetree/
>>> bindings/clock/samsung,exynosautov9-clock.yaml
>>
>> I don't understand:
>> 1. Why bindings are wrong not DTSI?
>> 2. What is "gout"? "dout" had a meaning as clock divider output.
> 
> "gout" is output of a gate clock, AFAIK.
> Unlike any other clocks, the fsys1 mmc top clock does not have a divider. So, it should be "mout -> gout" instead of "mout -> gout -> dout".

OK, then this should be in commit msg.

My question about full legal name remains, as here in replies I see
"Inbaraj E".

Best regards,
Krzysztof