Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Nov 2022 18:01:44 +0800
From:   Fei Li <fei1.li@intel.com>
To:     <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <peterz@infradead.org>
CC:     <dave.hansen@intel.com>, <gregkh@linuxfoundation.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <hpa@zytor.com>,
        <Yu1.Wang@intel.com>, <conghui.chen@intel.com>,
        <fengwei.yin@intel.com>
Subject: Re: [PATCH v2] x86/acrn: Set X86_FEATURE_TSC_KNOWN_FREQ
Message-ID: <Y2jXiHMtR+4jDB1n@louislifei-OptiPlex-7090>
References: <20221101053019.174948-1-fei1.li@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221101053019.174948-1-fei1.li@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/Fa+24RHERvUa9cTfF/HQqokswVOdmsLDiIkULh+QVhT0+ak4aTL5D7jzw/D?=
 =?us-ascii?Q?+fLHeNisWrBa/DBuFMz0/NzR1edPOk1gvu8Bwh7yBBaQQKC66exAqmNHc42t?=
 =?us-ascii?Q?MOKZCQBq2RTIwI797c6WGjPtOl0JjZunPslQOowfnLRBjs4EPCjmptDaxNK+?=
 =?us-ascii?Q?um0Fjx6ktA0a0RO3rjeUa6fasIXFJuS/5mJVAledCjNU5WI6o97g/b5OKFDu?=
 =?us-ascii?Q?QSAqoyUX3fFgYV/sGtnnraHkKfHaEPLaGPLD8770+O/f5NeqT3mE1EBZzXTk?=
 =?us-ascii?Q?nCP1b2gffBLabVrxXgQop+Gu0odNviKvi83E+06l0/AkCVuCiq6qIqxK2GHB?=
 =?us-ascii?Q?kyVZoLpJscbbQfU6hNSAuPWDrASGnars7x1yEER4JL+FxMXQYYAgzmhaNeAC?=
 =?us-ascii?Q?wMgXEaGYei/PMXwKzT0VTIb1CWxQmgtx7nh6ko87LxuXD+M8Oby93mMOg9Tw?=
 =?us-ascii?Q?x7EGMo6b0yrc0VQ06AWliis5WDc9OiPh6TdXRGSwpCu2x84dX+Cm5RybPToj?=
 =?us-ascii?Q?ibxGky4Q6+LLMRYmY+bx8Wqh/RcTJk1H2ThjWN1pBJpeh9wRsJzrEDdBtMb+?=
 =?us-ascii?Q?etAjkl2X4raX7po6cpD6Rady+XMue79E3hjHVT/weWp5Z6NxzjDSBkpp3YPc?=
 =?us-ascii?Q?IpbnYa/UrAs71sE7bQXGRzZ8PxDF3SYCEVd5nNKPpc7OXgq+V0b+J8GBeSrp?=
 =?us-ascii?Q?0xkG+yQ4elJB5ZJ5svvaUtQ+7a9MnxmY9Moc23O61Om8hIQCG0Fw/30jyx5j?=
 =?us-ascii?Q?xFFvdFij8OZykkWHfMy1kxfn2cfY7mAg73zQr1HC7zw1avk/Q1foOsym6lu6?=
 =?us-ascii?Q?jaW6aE0UTKpHO6mhqW1MOxCvsIF9YHdHx+21arUJboclAj9OYRu91OMlqKhy?=
 =?us-ascii?Q?t98UTMkc4aN1f+yRMcEhxTaQR5A9jR14w7yHj9ydumzUaROgd+zYTk3ue2g6?=
 =?us-ascii?Q?wBeYU9YIawmL4n9gre6GZg1bbp/5caTj33TFBfA75i0FKai8tjPEUDegPmfZ?=
 =?us-ascii?Q?EbKdFv5gEwy+Gov3xLmqOzfi9iEtXWWAmn/AXGaBoEGuMft6DX+Q/9vfNNaV?=
 =?us-ascii?Q?boZITGbO+d65izIkg7n4zZAq4CXP7IIh+umnmDEDPTxtrKwDN4zCylWWLHMN?=
 =?us-ascii?Q?gIaA6CcmMDnJ4ScjXrCwQzWSnyvIxb7MyvgeOY46yRKjsStGReKMOnglRsoF?=
 =?us-ascii?Q?8gbMBaM2iL6q3lW9ASEewB44PhhxOzaqChbG1b4XZEQ6UPPiRDukMYGw/LHW?=
 =?us-ascii?Q?6SsawcVThqxAXTpL/Hmtq/inru9J+jzVBg/Es3ODJNKOFiPhu/DRcnL3fF3+?=
 =?us-ascii?Q?3e8TS628vGGYOibjgjnpG1LS7d9iWpP8Y+4Lm+r4MhPVEI4/pDLk40DtqzWS?=
 =?us-ascii?Q?spx32G1K4itMSNm+2RTZh6Ugj+kCN1dpfn9Mcwz9yCYMgJJI/UcOoY6KlaxN?=
 =?us-ascii?Q?VgaaJFor5Yay0ybjOgPeC6COPDj7BuP+p5QhmDPQDNV5yPQH9EjDXD214b5R?=
 =?us-ascii?Q?q2F/waP8lgAw+iCPNgL3SIOtzGFcXxxJMdF3iy2KGU8CuXmJ98AQ5BC0Ahn5?=
 =?us-ascii?Q?v1nqZdnqpu7BLSL/qZ9XcDezlklyYoXSrSX6cR6T?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 05d86da0-8ab3-458d-3074-08dac0a5c741
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6153.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 09:52:27.2514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jj10mNgYinGDDRRJ+B9ySF6bILpPzk1Cde2uRPMH4G0GtPJKeS23j2tKyZmSJlfBqphNUc2XwLmdBJLxgG9QAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7171
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-11-01 at 13:30:19 +0800, Fei Li wrote:
> If the TSC frequency is known from the acrn_get_tsc_khz(),
> the TSC frequency does not need to be recalibrated.
> 
> Avoiding recalibration by setting X86_FEATURE_TSC_KNOWN_FREQ.
> This patch also removes `inline` for acrn_get_tsc_khz() since
> it doesn't make sense.
> 
> Signed-off-by: Fei Li <fei1.li@intel.com>
> Reviewed-by: Yin, Fengwei <fengwei.yin@intel.com>
> 
> ---
> v2:
> - Detail the commit message

Ping ...

> ---
>  arch/x86/include/asm/acrn.h | 5 -----
>  arch/x86/kernel/cpu/acrn.c  | 6 ++++++
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/include/asm/acrn.h b/arch/x86/include/asm/acrn.h
> index 1dd14381bcb6..aa12c74ea959 100644
> --- a/arch/x86/include/asm/acrn.h
> +++ b/arch/x86/include/asm/acrn.h
> @@ -30,11 +30,6 @@ static inline u32 acrn_cpuid_base(void)
>  	return 0;
>  }
>  
> -static inline unsigned long acrn_get_tsc_khz(void)
> -{
> -	return cpuid_eax(ACRN_CPUID_TIMING_INFO);
> -}
> -
>  /*
>   * Hypercalls for ACRN
>   *
> diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c
> index 485441b7f030..c5ff75b6a949 100644
> --- a/arch/x86/kernel/cpu/acrn.c
> +++ b/arch/x86/kernel/cpu/acrn.c
> @@ -24,6 +24,12 @@ static u32 __init acrn_detect(void)
>  	return acrn_cpuid_base();
>  }
>  
> +static unsigned long acrn_get_tsc_khz(void)
> +{
> +	setup_force_cpu_cap(X86_FEATURE_TSC_KNOWN_FREQ);
> +	return cpuid_eax(ACRN_CPUID_TIMING_INFO);
> +}
> +
>  static void __init acrn_init_platform(void)
>  {
>  	/* Setup the IDT for ACRN hypervisor callback */
> 
> base-commit: 5aaef24b5c6d4246b2cac1be949869fa36577737
> -- 
> 2.34.1
>