Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1573265rwb; Mon, 7 Nov 2022 03:18:59 -0800 (PST) X-Google-Smtp-Source: AMsMyM738AsuwbzTF8YAxLuNDZhwe9IcnhPvnAlaTNJfDrF2BrbRhu1bIynGjkguq6P+T7Z5Jma1 X-Received: by 2002:a17:907:7805:b0:780:24fd:c4e8 with SMTP id la5-20020a170907780500b0078024fdc4e8mr47950513ejc.78.1667819939079; Mon, 07 Nov 2022 03:18:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667819939; cv=none; d=google.com; s=arc-20160816; b=GMM16KP313WsdSnWMuVRVzCaIyRrgcPodlbahT4CA/kcE5Ta/bmP6r+r9BjFEjEJLq nw1vwbrwrxAr0D4nmSCdsBQW5lqDrP7MJIzRNGDtNgRBuajbdGTKmhGRE3wwNCG7TTST TC6RW5Uyxt5KRSzYQ4OIidJyD6d/gJ/fK7rX2dWqse0K6YAFVr4NVbrS5BaYUTopULaH RZYMrhuUAg60slC8uRGyyeV5Pl5TvyqihRjtp631chaYLPQhXdxBfV2rwNNfBBa73eyM fdwDMt+/REOFwXb8Ji48G6iEJ7PeZi512FT0Vkmcd35p7rwwPZj50RHoqlDpIvp4Ctmf 7GUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=W4ig8W5pzngbxp7sUAaNCRWLphNj78HmsgMSAcQTiIU=; b=twhxcdDUeauQ/SbK5thB3WlTnjP49Nd8m4CdC/JxNsGYaL0YtSGnHQyJA+9CXpnjZY pTp+tDNPyF6+v8hn66nDLb07FUS5tjW4IGSVWfuzzuGjDhs7sohuoDN8sRbD+AUUq3oF G0AMIvMtgm/3W1YQUmG9qFU+fJuDzLuFJImQL9LmXrTYVkUSi0e+ZzI44LTUDCsr+TSG esueSHBbAYTwwVMfR1ow0USkoZb7t23udObKEdvGA9dq6FXSKvDnDaGatVBN9eUmj/h2 tDJCwGsypH3AwNgUnavrruyHsUQwG9/JMizAr+T3ebItY+Nijrzcy5pYRKvn6d7QTCVq RI4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ToJOeuoX; dkim=neutral (no key) header.i=@linutronix.de header.b=TPxcoSqU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o21-20020a170906975500b00797670441desi10883998ejy.911.2022.11.07.03.18.36; Mon, 07 Nov 2022 03:18:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ToJOeuoX; dkim=neutral (no key) header.i=@linutronix.de header.b=TPxcoSqU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231550AbiKGK1z (ORCPT + 93 others); Mon, 7 Nov 2022 05:27:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230141AbiKGK1w (ORCPT ); Mon, 7 Nov 2022 05:27:52 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 004AE167CE for ; Mon, 7 Nov 2022 02:27:51 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1667816870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W4ig8W5pzngbxp7sUAaNCRWLphNj78HmsgMSAcQTiIU=; b=ToJOeuoXQqapHghob71VdvXHy7FXzsyECQIu6mQpZT/cZsRg29T912FmMiTreHjRnRlLzt C4fGSMTbxc09VMZB3s5ZcdkymcnLkCEbGqZWFX3xgvHMJlZ42+CIbm5YfN5H5RFyAHSxY0 3GZp1icyPFwvti6qBqTKy8D0RKEVr+IjdXRQLXeoXrCt42yRc6oiA1vJfP0mk4WAXyFdZJ wjQdgsKSiYjuOerzbD+kkxZsKCGKL28UqyneqxlCCTPgtJ4tB9VxVdB5C6vkD6CKiD8s16 dSZ/mQIvHNFkZmEi9lShdDzp1+C9vDpH6ByES4iZtRj6dNPkTZIRncvHeWar/Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1667816870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W4ig8W5pzngbxp7sUAaNCRWLphNj78HmsgMSAcQTiIU=; b=TPxcoSqU7chW3+snTy/ipS/OcTzw5fWDwczmCV+QQtewfnjIhH+CLdaVsdj81LnzFD2b0X DI9kY8NrlKVjllBA== To: Steven Rostedt , linux-kernel@vger.kernel.org Cc: Linus Torvalds , Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Julia Lawall Subject: Re: [for-linus][PATCH 4/5] timers: Add timer_shutdown_sync() and timer_shutdown() to be called before freeing timers In-Reply-To: <20221106233434.425162916@goodmis.org> References: <20221106233037.815236769@goodmis.org> <20221106233434.425162916@goodmis.org> Date: Mon, 07 Nov 2022 11:27:49 +0100 Message-ID: <87v8nrvz2y.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 06 2022 at 18:30, Steven Rostedt wrote: > -#if defined(CONFIG_SMP) || defined(CONFIG_PREEMPT_RT) > /** > - * del_timer_sync - deactivate a timer and wait for the handler to finish. > + * __del_timer_sync - deactivate a timer and wait for the handler to finish. > * @timer: the timer to be deactivated > + * @free: Set to true if the timer is about to be freed > * > * This function only differs from del_timer() on SMP: besides > deactivating How is this comment still correct? Thanks, tglx