Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Nov 2022 13:25:54 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Janne Grunau <j@jannau.net>
Cc:     linux-usb@vger.kernel.org, Sven Peter <sven@svenpeter.de>,
        stable@kernel.org, Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrey Smirnov <andrew.smirnov@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: dwc3: Do not get extcon device when
 usb-role-switch is used
Message-ID: <Y2jrQgj53z/mhHmm@smile.fi.intel.com>
References: <20221106214804.2814-1-j@jannau.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221106214804.2814-1-j@jannau.net>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Sun, Nov 06, 2022 at 10:48:04PM +0100, Janne Grunau wrote:
> The change breaks device tree based platforms with PHY device and use
> usb-role-switch instead of an extcon switch. extcon_find_edev_by_node()
> will return EPROBE_DEFER if it can not find a device so probing without
> an extcon device will be deferred indefinitely. Fix this by
> explicitly checking for usb-role-switch.
> At least the out-of-tree USB3 support on Apple silicon based platforms
> using dwc3 with tipd USB Type-C and PD controller is affected by this
> issue.

We don't care about out-of-tree modules, do we?

OTOH, the problem you are trying to workaround is probably in a (mis)use of
deferred probe somewhere.

Btw, does it prevent the system boot or you just see the extcon in the list of
deferred devices after booting?

-- 
With Best Regards,
Andy Shevchenko