Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1712005rwb; Mon, 7 Nov 2022 05:03:55 -0800 (PST) X-Google-Smtp-Source: AMsMyM59HcvnUNmG2pMwZyO7yw+47Iqg17fOXsE+bDLkyABHxVXgYLKAKtG2P+KLgORQaayNQo1+ X-Received: by 2002:a17:906:2543:b0:7ad:d164:bc73 with SMTP id j3-20020a170906254300b007add164bc73mr39652136ejb.210.1667826235179; Mon, 07 Nov 2022 05:03:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667826235; cv=none; d=google.com; s=arc-20160816; b=Irx4Z2W7/0bWpsrSHNtSXY1LqTOYt5o3PFfEELRCLv6x8pfVYOJJ5B2zZ4aN8iEofD CfXa/6v+Rqt27jgV33xKE0INXL0VtXbaFiWNEOpws+LJByVRrs0NVbzKh7I9m/cmraZr +HXtQ3s3zZTICfMKS+oLPmAL5sU20KO7ckek7Zi95oJeaN73MYMqQtAIHljwj18j1Umo 4jLaZitSncfMnQRPlQC4qwqMEe9iqETyGd3FNfnC1MJAG3cdC7VwOTUAhwMrqL9lPjzE lS7vXiIh5S0k/3K5Ra/tnckd2OLHOlVT9CRqisRH5CbWxL2GhnvUzLkE2Vy+M5fzX9Rf FgWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gemN1/mEvDZpQ8Kbg1Rlns5FoT8Z/qDyDJIq8lmhQ4U=; b=A+DodzDO5npybGDIPApoJoKZw084w7P3ji2fKdKv0bDbqSCAQSsfiY/rOaGXuCDTMQ yz++SpyTlbrqxCPUiwTLt4ItM55JjctoYcu1W3coxloxiiPwt5sbhNXQWalVaa+0N5I+ 9fYFk/55Pga7CRqccZK+ASbVhbY+4gfX6Uub0b8zW/T3SFNUSDb1J8M2ivFa5aTKkfa+ NNpU3YVHvkFcbYzaoms7SmE0yDFJA2iGjs02uqLt62dEeT4HUCQqLq57E9ZQk+E+N2Xh zIgDAcxqcJkHX9rz8wDhkYurn7wDs/Zjk/w7/gnxWyEUChMmdwtT0nx5aUs4vxJks43B oq+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CTKRrZWc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs25-20020a170906d1d900b0079330b37fb5si6063428ejb.564.2022.11.07.05.03.27; Mon, 07 Nov 2022 05:03:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CTKRrZWc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231781AbiKGMlM (ORCPT + 93 others); Mon, 7 Nov 2022 07:41:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232255AbiKGMlJ (ORCPT ); Mon, 7 Nov 2022 07:41:09 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E2B11B7AF; Mon, 7 Nov 2022 04:41:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667824868; x=1699360868; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JrFUNJUR+xfBmaFKXTf1XB9n1c5qjS+akAmoKJWoy8o=; b=CTKRrZWcjIFUT/nYqSTFt6GzEXbBA0wKj7SswhMGSAxolaL8Ldkx41Sj +avB/Vfaks6OJf6CmZ/GVyAnB2H9DUF2PoIE+hZLgra6AaycwWhhl5Le/ zwdnbLIoCk53JWl6Ypzd/xhyjPZtwF0PwLBnHr4vmgx2b48rIhtRYjYd4 /SpcHazLDp4dNK4bR7B5mXNUKQbjUoOkamFR+qXYMJekkmmPA5Cp5GCA2 XXCF/3yNrv7rX2mHJo/dHI2wBegpzJJNCE8eANt4IOpIVdp66Qq3xtOgi jkM0vCIR7YrkVzk+C5hWdtvHoAMEfuRMnc047N295es8Uv1Il/MsI1WHJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="311533783" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="311533783" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 04:41:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="669123382" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="669123382" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 07 Nov 2022 04:41:05 -0800 Received: by black.fi.intel.com (Postfix, from userid 1001) id 59A19155; Mon, 7 Nov 2022 14:41:29 +0200 (EET) Date: Mon, 7 Nov 2022 14:41:29 +0200 From: Mika Westerberg To: Rajat Khandelwal Cc: michael.jamet@intel.com, YehezkelShB@gmail.com, andreas.noever@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] thunderbolt: Add wake on connect/disconnect on USB4 ports Message-ID: References: <20221101115042.248187-1-rajat.khandelwal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221101115042.248187-1-rajat.khandelwal@intel.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2022 at 05:20:42PM +0530, Rajat Khandelwal wrote: > Wake on connect/disconnect is only supported while runtime suspend > for now, which is obviously necessary. It is also not inherently > desired for the system to wakeup on thunderbolt/USB4 hot plug events. > However, we can still make user in control of waking up the system > in the events of hot plug/unplug. > This patch adds 'wakeup' attribute under 'usb4_portX/power' sysfs > attribute and only enables wakes on connect/disconnect to the > respective port when 'wakeup' is set to 'enabled'. The attribute > is set to 'disabled' by default. > > Signed-off-by: Rajat Khandelwal > Reviewed-by: Mika Westerberg Applied to thunderbolt.git/next, thanks!