Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Nov 2022 13:42:05 +0100
From:   Frederic Weisbecker <frederic@kernel.org>
To:     Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        John Stultz <jstultz@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Eric Dumazet <edumazet@google.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Arjan van de Ven <arjan@infradead.org>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Rik van Riel <riel@surriel.com>
Subject: Re: [PATCH v4 09/16] timer: Split out "get next timer interrupt"
 functionality
Message-ID: <20221107124205.GC4588@lothringen>
References: <20221104145737.71236-1-anna-maria@linutronix.de>
 <20221104145737.71236-10-anna-maria@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221104145737.71236-10-anna-maria@linutronix.de>
Precedence: bulk

On Fri, Nov 04, 2022 at 03:57:30PM +0100, Anna-Maria Behnsen wrote:
> forward_and_idle_timer_bases() includes the functionality for getting the
> next timer interrupt. To reuse it, it is splitted into an separate function
> "get_next_timer_interrupt()".
> 
> This is preparatory work for the conversion of the NOHZ timer
> placement to a pull at expiry time model. No functional change.
> 
> Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
> ---
> v4: Fix typo in comment
> ---
>  kernel/time/timer.c | 93 +++++++++++++++++++++++++--------------------
>  1 file changed, 51 insertions(+), 42 deletions(-)
> 
> diff --git a/kernel/time/timer.c b/kernel/time/timer.c
> index 680a0760e30d..853089febf83 100644
> --- a/kernel/time/timer.c
> +++ b/kernel/time/timer.c
> @@ -1704,6 +1704,46 @@ static unsigned long next_timer_interrupt(struct timer_base *base)
>  	return base->next_expiry;
>  }
>  
> +static unsigned long get_next_timer_interrupt(struct timer_base *base_local,

So perhaps forward_and_idle_timer_interrupt() could stay as
"get_next_timer_interrupt()" and the new get_next_timer_interrupt() above could
become fetch_next_timer_interrupt().

Just an idea.

From a functional POV:

     Reviewed-by: Frederic Weisbecker <frederic@kernel.org>

Thanks.