Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Nov 2022 08:56:16 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Oded Gabbay <ogabbay@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, Arnd Bergmann <arnd@arndb.de>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        John Hubbard <jhubbard@nvidia.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
        Jiho Chu <jiho.chu@samsung.com>,
        Daniel Stone <daniel@fooishbar.org>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Jeffrey Hugo <quic_jhugo@quicinc.com>,
        Christoph Hellwig <hch@infradead.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
        Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>,
        stanislaw.gruszka@intel.com
Subject: Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a
 new major
Message-ID: <Y2kAcCu4z2LUMN7u@nvidia.com>
References: <20221102203405.1797491-1-ogabbay@kernel.org>
 <20221102203405.1797491-2-ogabbay@kernel.org>
 <Y2MMCIe5wND2XPqE@kroah.com>
 <CAFCwf13uLj=P6u6FAcY8M5qAXoaBdb+Ha-TYj0j2FAZnFAPFYg@mail.gmail.com>
 <CAFCwf12yRUG4593ozJMEwaaJBKyWqXTTCjef9O_fzWdQBxVrtw@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFCwf12yRUG4593ozJMEwaaJBKyWqXTTCjef9O_fzWdQBxVrtw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sVgXKt+CrtvbWqrgNUaUYQFN1pN88g5czUrmppHIDMOB5tzIC9wGa1pCrnta?=
 =?us-ascii?Q?sOsq5avPN33SeT6PlopFqjpt0wCLErYlVD1FAPur4SlsDmjHdVdDa57cilaV?=
 =?us-ascii?Q?omkNzior6G+aj0pgpkyqWIBzs2EowmGsRj0Q8jruVK5D/E0Xd6YpEozIkIfU?=
 =?us-ascii?Q?X8VczBLWoaDOn0Qz9SmzJcj9fhbZeOLJ8uF4ncPlez2JIcNeUgStDNiBLojR?=
 =?us-ascii?Q?Tn7sO16JbNyRlZojSkTYtkr+dByU0HIsaHHVIkwqL/5vRUx+BFSZ8rH9ZyNM?=
 =?us-ascii?Q?fLCRahARmoxXhx2HPegipDtU2HNYwvO7gEtVByYhxpXIYWYM6HRUiBejYlXF?=
 =?us-ascii?Q?l1YO8RiRadHhsmooyNocx7STcyaah2sCViQMdD0FkBaIxPC/bnNqnQwJFOGe?=
 =?us-ascii?Q?/+IIlGOkTkpebyLrQobGcyJKz6INeCyf2ac8CjAfoPmfrAk1uzHoPDtxeAmI?=
 =?us-ascii?Q?HYaJetZTdpnO7J6nMtRkXmD+i9pALmB3AoGR1xqtfZw9AlqdOJz+w2EX6eiq?=
 =?us-ascii?Q?sxLixqJUjCEDFsEUk2t7GGRYiHJE8omluA4q8tru5vrM4VQSJLDei+iIZA84?=
 =?us-ascii?Q?DbBMQNoJWXmPaWpgOCD5aRjo/WMYseg9BD3tnXMA9dYgw4rMG+eHwwaIcqKI?=
 =?us-ascii?Q?Xs4dPGe6HQWjaDYa5ktP5MiCcr+Aganq2jpeJkQC1m9aQoMiwpWsFsWGRjMd?=
 =?us-ascii?Q?JiKRxMQn0siwV0rWaWa//+10K8BDS4wzqSOismoLi5qVZl+IczXcQyNBxl/n?=
 =?us-ascii?Q?qMPHMHlQ1aAI23Besudic3I3McutQzhHgypkqSYCCCGbBnrtqthVYGPL6a4H?=
 =?us-ascii?Q?pB358BKuZ2pBgJKE51ZslQSSHSyKOH817dzPXiwhhwrOepYkw4jJ1iyMUJDG?=
 =?us-ascii?Q?b4DLIyiL9jxPttoYVRTzWIpzI0YjOg2qtOnU56g5FQR/CvK2WAySP0hR5kt+?=
 =?us-ascii?Q?vlptGqVUJg+Kq6ZSpOeQNtxMSpCFcX+HtyTy+sYEcdhV38nXvOieuSJsm4JX?=
 =?us-ascii?Q?uB5D8JQhRcQFRTvlJqVQC/KzdYC4JRW05L525onj+84fGGacLsv+ViUuabgH?=
 =?us-ascii?Q?gOR2IxntykaYtrd+cBg5Oqha+yl42V8WmlHY73xDEjNJHLShp2yMhZZQKA7F?=
 =?us-ascii?Q?Pz5zqjEPepLDTaB/gNnsSSyJ4ZAAfsVxqjwaslqyFCWPgADw9hF8KXXsTg/o?=
 =?us-ascii?Q?Sr4Q32rDFNZZ5SkEhIMc9DdIUEWlUU6+Neb6CEEk3XeG9MgRy1rbX8DCA/4h?=
 =?us-ascii?Q?43QK1xShsZQJNOAyb1hWNPqXnChXirkjKLMXYGYn9/v7wFYMfyY8tlLP8jIP?=
 =?us-ascii?Q?0iIwvem1w4QVGP9L0MU9iuFyXal21RJgMwv3zbfETYqxn53Q7pAbYQQjC5if?=
 =?us-ascii?Q?S8GBxyWDWgp4u9BYTxB1bMnqZZ73qsOq6EX9ETUkRcN/PJCA3rmz8uzJPzow?=
 =?us-ascii?Q?B0vBc/isY0d6tzncAfCAhEVhVgfqzGSMqrFG9J4vVsvrnQbC2dq/FDEXBbJO?=
 =?us-ascii?Q?G+sE9SCneVfUCCWbHFWuEIKydClbejiYMSKTLSyNqJBiRpb7qEGKi40g4MVx?=
 =?us-ascii?Q?xhKzctWlxi6IldUQYMftP9bjkqQjbtQHqptUM2th?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa6e3214-adbf-4ab6-eb68-08dac0bf7593
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 12:56:17.3073
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ef0KuyMsIMxv5MKNgjtYxVnqnwAEKqlYPZibh6qN1zyJquFZ/YTSfMvkP4BzNyHG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5334
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 03, 2022 at 10:39:36PM +0200, Oded Gabbay wrote:
> On Thu, Nov 3, 2022 at 3:31 PM Oded Gabbay <ogabbay@kernel.org> wrote:
> >
> > On Thu, Nov 3, 2022 at 2:31 AM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Wed, Nov 02, 2022 at 10:34:03PM +0200, Oded Gabbay wrote:
> > > > --- /dev/null
> > > > +++ b/drivers/accel/Kconfig
> > > > @@ -0,0 +1,24 @@
> > > > +# SPDX-License-Identifier: GPL-2.0-only
> > > > +#
> > > > +# Compute Acceleration device configuration
> > > > +#
> > > > +# This framework provides support for compute acceleration devices, such
> > > > +# as, but not limited to, Machine-Learning and Deep-Learning acceleration
> > > > +# devices
> > > > +#
> > > > +menuconfig ACCEL
> > > > +     tristate "Compute Acceleration Framework"
> > > > +     depends on DRM
> > > > +     help
> > > > +       Framework for device drivers of compute acceleration devices, such
> > > > +       as, but not limited to, Machine-Learning and Deep-Learning
> > > > +       acceleration devices.
> > > > +       If you say Y here, you need to select the module that's right for
> > > > +       your acceleration device from the list below.
> > > > +       This framework is integrated with the DRM subsystem as compute
> > > > +       accelerators and GPUs share a lot in common and can use almost the
> > > > +       same infrastructure code.
> > > > +       Having said that, acceleration devices will have a different
> > > > +       major number than GPUs, and will be exposed to user-space using
> > > > +       different device files, called accel/accel* (in /dev, sysfs
> > > > +       and debugfs)
> > >
> > > Module name if "M" is chosen?
> > Will add
> So, unfortunately, the path of doing accel as a kernel module won't
> work cleanly (Thanks stanislaw for pointing this out to me).
> The reason is the circular dependency between drm and accel. drm calls
> accel exported symbols during init and when devices are registering
> (all the minor handling), and accel calls drm exported symbols because
> I don't want to duplicate the entire drm core code.

I really don't think this is the right way to integrate with
DRM. Accel should be a layer over top of DRM, not have these wakky
co-dependencies.

The fact you are running into stuff like this already smells really
bad.

Jason