Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Nov 2022 09:10:36 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Oded Gabbay <ogabbay@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, Arnd Bergmann <arnd@arndb.de>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        John Hubbard <jhubbard@nvidia.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
        Jiho Chu <jiho.chu@samsung.com>,
        Daniel Stone <daniel@fooishbar.org>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Jeffrey Hugo <quic_jhugo@quicinc.com>,
        Christoph Hellwig <hch@infradead.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
        Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>,
        stanislaw.gruszka@intel.com
Subject: Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a
 new major
Message-ID: <Y2kDzPswkKyZyRpS@nvidia.com>
References: <20221102203405.1797491-1-ogabbay@kernel.org>
 <20221102203405.1797491-2-ogabbay@kernel.org>
 <Y2MMCIe5wND2XPqE@kroah.com>
 <CAFCwf13uLj=P6u6FAcY8M5qAXoaBdb+Ha-TYj0j2FAZnFAPFYg@mail.gmail.com>
 <CAFCwf12yRUG4593ozJMEwaaJBKyWqXTTCjef9O_fzWdQBxVrtw@mail.gmail.com>
 <Y2kAcCu4z2LUMN7u@nvidia.com>
 <CAFCwf10K-dTu455QfOK8i6thismY-FUN2Rws830EGiqOcGWFgA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFCwf10K-dTu455QfOK8i6thismY-FUN2Rws830EGiqOcGWFgA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZO0Y1LtClZqf/Jj8n37kfcnL5PODN7NRzf9GufEzZaBTHbeYaOfMNlfgvMfC?=
 =?us-ascii?Q?E2BikF3l4wDrr3nsXFPyYEtMlPj3yjp9Tx4+QzjAGBBblAdhnt8H3g47brsN?=
 =?us-ascii?Q?jpQl7sTzRKdxHwKUrc2Fht9HdL3xG7Y+PvNSIFZAThtXiWWsbaUyZX3d9hGx?=
 =?us-ascii?Q?qKo0jVgtTAvneDW9JcelaHRhpwPOyLKVEeSPE0ssoi2sm3+FsmIPZ53y9Hqi?=
 =?us-ascii?Q?4K7IlvTlF0nAYzeQt+ZWgysioM446C7azFaWyxeZZPVodetZmI4Wy2MljyHf?=
 =?us-ascii?Q?ugcXI25L4jgzprgefwokC/gov7dvuIf5FSYMH2PTwaEBgHsHE+6Rjk1V08WV?=
 =?us-ascii?Q?PploRNeJAwGbv0Ml0RW7TsD9+Nl9Fg3/2g8geSga/S96iEE7eA7mu7J1WGXK?=
 =?us-ascii?Q?5qtm4dm4X/UyeNIP9tJRFkBIk8BowtMnDCji2P9gGYesbYJIz2TGf6u7+wty?=
 =?us-ascii?Q?lafND9jf77QFIxRGDjzDJt6QTiZh/PBLAgp+/20MWA/VqNjO1uPcYPbZ0pvw?=
 =?us-ascii?Q?iJWQzGk1lGkMk9vUmMB9LcsSICSG2WtB5lGsnOvCAKAMPulSCWBPkLjfXNIw?=
 =?us-ascii?Q?pvusL9sjhVUJ7UzN7kwGVCvEecTkmHnNMja9pPhNk+5jEy7peAzCEXIJsRuh?=
 =?us-ascii?Q?lpiOsMNtErWuJPnAkp+fTPyB3BaFPdXbN8UGCUGhbKqgmUqw87hpbGYwVve4?=
 =?us-ascii?Q?qdCcD7B0ILVmeJAQFcGerb+8owt5ezlSgexgMY7zSgjn68aJxD6aLhQjV9Te?=
 =?us-ascii?Q?QctMvPzEJZ6c4gmzww1FcaEb7Sl5d4dz+pSurbm71kytyKFkwsCjB+r9Psjg?=
 =?us-ascii?Q?m/HTalYaRUq2Mw3PcgCzlqAHSqN+aax5xEgmNwKF/aVdRH/L9qLlV0bjrL4U?=
 =?us-ascii?Q?4Nqed0Do1LVVKX8NNqzxkpbSeseC+/nf6gR6D9WLtJUFh9kdTwrwAQK0hR3u?=
 =?us-ascii?Q?NHQMlL7xaCweKhtpvsqF2giUjyMBqktyI1AvV0WmUvoJC+cH7uagBlIHzmOj?=
 =?us-ascii?Q?35IkE3woHdLHqX78YZ1zWXXsfrgFM46UjCI4nCIfV8yXiShHzqEgCZE57PzM?=
 =?us-ascii?Q?Ouqx+4V1X5Cxg7ereK1Tta3fFbZjGtfHl5m7dmqauGLQODsv+lbcub7zC31W?=
 =?us-ascii?Q?h2K8fJ4Jsxr4rNbrjA1OMHZFPvjnt9hE8sMC36YiA2MIPjfijSLRjGVdOHuL?=
 =?us-ascii?Q?2yxL4Wxj1dJG4CqNSqCnlR+v+2HFjBxqwm1TZbP8raAsJMVZNjqrWKpD34LM?=
 =?us-ascii?Q?NU0DCXV0MiM0BfxIsRP5wvs9TGODjU9Idl8wvHjQBMwWDpKPxVvshfyakG+G?=
 =?us-ascii?Q?zu2N9SNKO8t729418rw5L25VbHR9WjlqeFtTeWMRHe+mlDC4cD1sf9DPDLX+?=
 =?us-ascii?Q?nx8bo/um5Gf4nIL93QcOzvyMCH7DliU/FbGoIGKaYB+nUwa0a/r59WOsAyxg?=
 =?us-ascii?Q?pJpoJz+n3glNQ5L6nyrlhaLrtVe1PMDYDBVnUObqj+tr7Hsx0fTYsVL4WAED?=
 =?us-ascii?Q?dDpTrO0xSlf0D8UYb8nLiDI8Vl++sd443cqDzHQ2jEqNx42s2quIhhsPJKR1?=
 =?us-ascii?Q?DwLU7RG+Bx9OtTljPso=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a7c7b5c-bbf5-4d32-de09-08dac0c1766c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 13:10:37.6757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1gfFOii9Xqs7sykpBsFA7ywoCoGIjaxVGipfNPT2x0VsATY4AV6Svp3azNiXuIaf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5899
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 07, 2022 at 03:01:08PM +0200, Oded Gabbay wrote:
> I don't agree with your statement that it should be "a layer over top of DRM".
> Anything on top of DRM is a device driver.
> Accel is not a device driver, it is a new type of drm minor / drm driver.

Yeah, I still think this is not the right way, you are getting almost
nothing from DRM and making everything more complicated in the
process.

> The only alternative imo to that is to abandon the idea of reusing
> drm, and just make an independant accel core code.

Not quite really, layer it properly and librarize parts of DRM into
things accel can re-use so they are not intimately tied to the DRM
struct device notion.

IMHO this is much better, because accel has very little need of DRM to
manage a struct device/cdev in the first place.

Jason