Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <721f6a1a-1144-4fe4-e722-2ba2d7200680@amd.com>
Date:   Mon, 7 Nov 2022 06:27:52 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/1] platform/x86/amd: Fix pmc compile dependency errors.
Content-Language: en-US
To:     Hans de Goede <hdegoede@redhat.com>,
        Yupeng Li <liyupeng@zbhlos.com>, Shyam-sundar.S-k@amd.com,
        markgross@kernel.org
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        caizp2008@163.com
References: <20221026072531.346013-1-liyupeng@zbhlos.com>
 <0910bcc4-d55f-6f3a-b2df-4e30d164aeeb@redhat.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <0910bcc4-d55f-6f3a-b2df-4e30d164aeeb@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkYxZHdST1lZNUxjNE0zdzJiamllMmZ3K09YN0Z4dkJHZzYwU0ZGK2djZTRL?=
 =?utf-8?B?VEttRGxEcks5dVVaM2FneUEzMGFpbkd2VGNPOXpuY0RkRUpPOC9yZG1aWW5n?=
 =?utf-8?B?UW9XY0o0ZnZVM1N1eTFRNVpwTWhzWkNPTUo1Q3FRZWp2UTRDK1NRZWR0cVh3?=
 =?utf-8?B?dE9NR2tVWXRHTGI2UUdIZTFHQzczREk2eW5TMUtMam9tTEIwM0I5WUxZWGp4?=
 =?utf-8?B?a3BCcmV5TWFWUUpLUWxickZRZTZ2V21LblRPYjJ4VWpCRDdDZldESVhGeUEv?=
 =?utf-8?B?S1RXYUgxTzAvZDBnL2pkL241Yi9BTU1EWUJWSkdYS0RsalZaUHBTc0wyUzVR?=
 =?utf-8?B?cHpFQXlHUC9nWmZSa3VqZlU3eGEwWnAybk9maGxEL2ZwaCt4cXpIa214dTR0?=
 =?utf-8?B?cld5T1pSWDlkZnR2RE1TN0JSNmV4NlpmeFFUeXJPUnBXNVdDeENzZk9aQWor?=
 =?utf-8?B?WS9sem1rbFRFa05XZjhFYkhuS1Zha1FNNXRWc3MwbkRKUDdPWEhLMXBsNWJk?=
 =?utf-8?B?TnJhR3lhV2k0NnorQUpkek9aSURLRk4yTkNyWWRWWTNsS2RWOTZmQzR5SERO?=
 =?utf-8?B?Z2p2eFB5ZmZETTRUSjhWeWtVTmFpZXRLTmVhVUlsT2gwd01Lc3ZvdXY5MEdE?=
 =?utf-8?B?eGVJT1FaNk9HSkwvelNUNEVWcHBBUUUvMGhBWTJEc3ozR1NvbjhqYTVSTWRv?=
 =?utf-8?B?cjd3b25aRVFJR3ROdzRqWTZQNVdOc2dZdm1rNlpHNHhiNVpRL1dMeG0wSDcy?=
 =?utf-8?B?bUQ3c3dma0wwZCtvM04rZGowUDc1TnBZN24wZG84aGg5QU50K0NxYkRSRTdz?=
 =?utf-8?B?NElhQzRLZUpDR3hpTUQxMENEcFNVRjlXZHhPK0FUV0wydkJCU1JYU1FLNVox?=
 =?utf-8?B?ODJPREVSVmxGNng1S0V0TmkxblZZbWM4bU11ZzZCMXNYa2ZLV0FVcUlaNlJr?=
 =?utf-8?B?Y0RpdzVyaXk3bHFkbFZra0ZjU013TTlqZ1VtYW5HemtvL1JoUk9sOXlteFFM?=
 =?utf-8?B?KzFkdGRBaTRVNVgreHVhM0phS2RYQ3d6TE9EblZDS0xRUEJwSTdYbFJsTHUv?=
 =?utf-8?B?bzlHT2lPUzRsVm9zcStURGlGaDdZT3MwZEorNVJJQU9DeEZwUjJ1VytsT0Zs?=
 =?utf-8?B?ZFJQZGMraU92SmhJSUR0aHlEek1aREsrTXVNMjhwUlZqaHErTFAwODdrdk0v?=
 =?utf-8?B?WjVaNHBBblh3Q2FHY1U2cVRsZnhORWRTTWlwWkZ0V2NzQ25pc0ptc1hyaTNR?=
 =?utf-8?B?SS9QSDhBUTBCbUQ1cUd2VzRVdWoveHBWMWV6VmZVekMxRlZIUklOM2E0S2pC?=
 =?utf-8?B?S3o0dG1mTW5pRjM0R0MrV3RHa3M2RmdwNFVzYkJGcW8yV3ZjY0dYTkdrUEJa?=
 =?utf-8?B?NnYxcUZTbkZnUVJtektUN0RMaUVOU1RkYzRaajhFZUw1TXlvVGNjempIY284?=
 =?utf-8?B?UHNFcHNjUGpJaUpPZ2FMZ1JseWx2bkZIcGdmeE9JRDFvZkxhMzlIRS94RytB?=
 =?utf-8?B?OEFlWDIrSlMxK0I0anN5cG15eW9MVEptaU56T056S25yTnl4eWdXTkdJZzdU?=
 =?utf-8?B?SFVmVWdpcWM2UTdUMysxZXF3NUo5RStCN0VJTjYvNXRRUW15S3JMU2pudS9Q?=
 =?utf-8?B?WDB5QnJhU2FVUjNVWk5mbTFrTGJCZnRwcFRJRHhmaCtiVUdrTU53aW43dFdM?=
 =?utf-8?B?UlVsbWcydUNBaEpDRWVqZXRnaGsxbjF4dnh2eTh5QVVNYks1Q1hUcHBJRjdp?=
 =?utf-8?B?cjJ3QVVCcmpVeEVJS1l6RDVTNlRsdWFrcXJTS09nYTh4ckMvSkZJQzJ1UWVu?=
 =?utf-8?B?MWRSZysrd1A3M285YUxiZ2o3QUZwUmdEWUtwUDYweUQ0RUVocEVYM090VDNK?=
 =?utf-8?B?czJlcHdzanY0MHAzajI5WmxLck1xK1dnNWowQWMrc3NCS1dodjV4ajg3VS84?=
 =?utf-8?B?UFdISmJGMkVPZmFFWE5jQTVDYko3d2JsWXhGdlhRZHFMck9rcGNxWTRub3Ir?=
 =?utf-8?B?dUk3ZkU4dnZieEoxcXRpL2phOHpSQTUwWU9MWDBvYzlsZzdNOHJNeG4rRlRK?=
 =?utf-8?B?OTNGWDc3Smc2S3FFbktiTmc3UExLWUR2VjlpMmtiN0dPRUsrdCthb0tpQnQy?=
 =?utf-8?B?TlE4Q3BuTDluMXp4MStwWExLNTBrK2sxMXpTK2tkZDdsWERTT0NmSWViaDFT?=
 =?utf-8?Q?bt8MC6prPC3gHFF7TYDk3i/+Wvc03vzrRO8nhTB7NJGw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53553c2a-3ae0-434b-e4ee-08dac0bb7e56
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 12:27:53.8949
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jPdL5g+4eLQnDdkD9gc+89riPYfjAXAyFkwkrtdD+U4gM1toXlis8MN/lBNKWkMnB71GsAvFx+6pEqenzv9Q2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8029
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/22 04:28, Hans de Goede wrote:
> Hi,
> 
> On 10/26/22 09:25, Yupeng Li wrote:
>> When disabled CONFIG_SUSPEND and CONFIG_DEBUG_FS, get_metrics_table
>> and amd_pmc_idlemask_read is defined under two conditions of this,
>> pmc build with implicit declaration of function error.Some build error
>> messages are as follows:
>>
>>   CC [M]  drivers/platform/x86/amd/pmc.o
>> drivers/platform/x86/amd/pmc.c: In function ‘smu_fw_info_show’:
>> drivers/platform/x86/amd/pmc.c:436:6: error: implicit declaration of function ‘get_metrics_table’ [-Werror=implicit-function-declaration]
>>    436 |  if (get_metrics_table(dev, &table))
>>        |      ^~~~~~~~~~~~~~~~~
>> drivers/platform/x86/amd/pmc.c: In function ‘amd_pmc_idlemask_show’:
>> drivers/platform/x86/amd/pmc.c:508:8: error: implicit declaration of function ‘amd_pmc_idlemask_read’; did you mean ‘amd_pmc_idlemask_show’? [-Werror=implicit-function-declaration]
>>    508 |   rc = amd_pmc_idlemask_read(dev, NULL, s);
>>        |        ^~~~~~~~~~~~~~~~~~~~~
>>        |        amd_pmc_idlemask_show
>> cc1: some warnings being treated as errors
>>
>> Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
>> Reviewed-by: Caicai <caizp2008@163.com>
> 
> Thank you for your patch, however I do not believe that this is the correct fix:
> 
>> ---
>>   drivers/platform/x86/amd/pmc.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c
>> index ce859b300712..2b08039921b8 100644
>> --- a/drivers/platform/x86/amd/pmc.c
>> +++ b/drivers/platform/x86/amd/pmc.c
>> @@ -433,8 +433,10 @@ static int smu_fw_info_show(struct seq_file *s, void *unused)
>>   	struct smu_metrics table;
>>   	int idx;
>>   
>> +#if defined(CONFIG_SUSPEND) || defined(CONFIG_DEBUG_FS)
>>   	if (get_metrics_table(dev, &table))
>>   		return -EINVAL;
>> +#endif
>>   
>>   	seq_puts(s, "\n=== SMU Statistics ===\n");
>>   	seq_printf(s, "Table Version: %d\n", table.table_version);
> 
> The table variable gets used here, but now it no longer has been initialized by
> get_metrics_table() so just #ifdef-ing out the get_metrics_table() call is wrong.
> 
>> @@ -503,11 +505,12 @@ static int amd_pmc_idlemask_show(struct seq_file *s, void *unused)
>>   		if (rc)
>>   			return rc;
>>   	}
>> -
>>   	if (dev->major > 56 || (dev->major >= 55 && dev->minor >= 37)) {
>> +#if defined(CONFIG_SUSPEND) || defined(CONFIG_DEBUG_FS)
>>   		rc = amd_pmc_idlemask_read(dev, NULL, s);
>>   		if (rc)
>>   			return rc;
>> +#endif
>>   	} else {
>>   		seq_puts(s, "Unsupported SMU version for Idlemask\n");
>>   	}
> 
> Same thing except now nothing gets send to the struct seq_file *s,
> so this is wrong too.
> 
> Shyam / Mario, can you take a look at the reported compile errors please?
> 
> Regards,
> 
> Hans
> 

What kernel is this?  Shyam removed CONFIG_DEBUGFS in b37fe34c83.  So is 
this failure still happening in 6.1-rc4?