Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Nov 2022 08:53:20 -0500 (EST)
From:   John Kacur <jkacur@redhat.com>
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
cc:     Steven Rostedt <rostedt@goodmis.org>,
        linux-trace-devel@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>,
        Clark Williams <williams@redhat.com>,
        Chang Yin <cyin@redhat.com>
Subject: Re: [PATCH] rtla: Fix exit status when returning from calls to
 usage()
In-Reply-To: <b4639b19-94e3-2128-643e-6a3a44a1d944@kernel.org>
Message-ID: <ca3dce1a-98d0-109a-f4d-d35b6ee2399a@redhat.com>
References: <20221103135742.9523-1-jkacur@redhat.com> <b4639b19-94e3-2128-643e-6a3a44a1d944@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


On Fri, 4 Nov 2022, Daniel Bristot de Oliveira wrote:

> On 11/3/22 14:57, John Kacur wrote:
> > rtla_usage(), osnoise_usage() and timerlat_usage() all exit with an
> > error status
> 
> missing .
?

> 
> > However when these are called from help, they should exit with a
> > non-error status.
> > 
> > Fix this by passing the exit status to the functions
> 
> missing .
?

> 
> > Note, although we remove the subsequent call to exit after calling
> > usage, we leave it in at the end of a function to supress the compiler
> 
> suppress?
Of course, thanks for the spelling check!

> 
> > warning "control reaches end of a non-void function"
> 
> missing .
?

> 
> Yep, that is a problem, and agree with the solution (I am already doing it
> in the rv cmd line).
cool

> 
> -- Daniel
>