Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c40b0b21-2a48-ffff-6568-fb55e8f9a15c@amd.com>
Date:   Mon, 7 Nov 2022 08:09:08 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] virt: sev-guest: Add MODULE_ALIAS
To:     Cole Robinson <crobinso@redhat.com>, Borislav Petkov <bp@suse.de>
Cc:     linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org,
        brijesh.singh@amd.com
References: <ff480c5e688eb0a72a4db0a29c7b1bb54c45bfd4.1667594253.git.crobinso@redhat.com>
 <Y2V7w6PCUV/IxLBl@zn.tnic> <91c2eaad-92fc-4251-f9e9-7d73cf2b5da5@redhat.com>
Content-Language: en-US
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <91c2eaad-92fc-4251-f9e9-7d73cf2b5da5@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUZ0dThnVjFOMktwS2pSNGZ1RHFzaG5wSlZhK2pHb2UvR05yZ1NqZCtnS1d6?=
 =?utf-8?B?ZU4xR0FlMjlvWFBSV20vTmxJRWZyUTN4OHJTcjZsTkhhOEJtZlhtQUhNYnV1?=
 =?utf-8?B?NHVvbndQSDBKVEsvcXltMmViVmFaVFByaDdjQlJWSDNhSVQ4bzJzTXNTU3N5?=
 =?utf-8?B?RzBQRGRzYTB2cnZ0SEovRGlaUzJ2Y2lOZ2JJTTNLMGlxdmdxcXNkVW5xWEhQ?=
 =?utf-8?B?WnZuZngzeW15Y3pSQm8vWDJuUG9pVmdOSGxLVnE4TXVSaW03cXpxTjc3MGt1?=
 =?utf-8?B?UW40QnpHL0JTckM2WU8yMy9WSVl3UVdxWXVDYnBvVEtCSGxCZm5JRExjMDU3?=
 =?utf-8?B?VHNOTEtxcnU4QXRtSkxhZ1JJTzBxRkF5Tk9mY2k4S2l4Rzg4clFCb3luZ0Ji?=
 =?utf-8?B?UndFeW03QVMxQzNreDEvQm1KdXFWOVdkV0tHTWJFZ1I2Y3Q1Sm91ekhVbEx4?=
 =?utf-8?B?VDV2ZnhqNWt5YTYrcmRVTW5nU3VsOHMvVnZDYXBXTW9tNk9DamRCUHYwcUQ2?=
 =?utf-8?B?VFQvQjV2QTl3YmhuU1FSdVNLRU0zOVp3NnREZUc5TnVIVEFzdjVVVWxvMk9K?=
 =?utf-8?B?NjRneEhubzJvZG5DWGFkY0JucnV5YXdCVS94cFdqUlRaMmpmWUhXSUg4Qmhm?=
 =?utf-8?B?Sm9pMjRvbGhDYnVRT0x4V1dQcHVVMms3WFNRcktoeFo4bCtMMlZxMk10dGVj?=
 =?utf-8?B?eXJtOEp3K3pOWjE0OVRTUTBDL3dYZ3MzUE1WaVF1UkpqR3NKZUFRQms0dTJP?=
 =?utf-8?B?ZjNZZnBFWUxzNTk0WVJ1dmk2aTFsU2ZyaEFTc0thK1FvMEN1UkU5S3NYNWpy?=
 =?utf-8?B?cXRXQkVYU0hNS1p3N2JmRElZdlVnSXVtMk5UakVwQ2MyM3ZZOXZEUjM0a05X?=
 =?utf-8?B?UWRSWXdxTFYyajJaU0RuTlltNHJKTHZnSm5zZ0dTdGRPd2V0T3Fwd1BKZytV?=
 =?utf-8?B?SlhIUncxZ2s2NmVxTStYQTJpRnpCRnVDdFNvcEhGWEUzMlNISVFxZUVUTGhE?=
 =?utf-8?B?aFVnODBuWGlsOHBFV1M0YUFUM08zS3ZOMDJMODNaSHFNQkkyY2VGbTBCOWtB?=
 =?utf-8?B?M0pHU01aKzRIWVE5cnQ4MW55V3RONmsrWXEzekJFSHp6TjRNTG1LWllyVUh5?=
 =?utf-8?B?SllXQzF4Vm9MUmxOTEJWc2YwTUdQUFN6ZzZyamJnZno0SENidVRHbEExZDc3?=
 =?utf-8?B?dnNJSzNpTkY4ZWdTQXFJWU1UYW1HRDkzTFc5ZnM1bkVtLzBWMXREMU5PTXpp?=
 =?utf-8?B?SmtJTU56TVZoNEMrUDQvMEtKalRtM3R2ckJXM1FpNU13K29ncDlvd3gvemov?=
 =?utf-8?B?OUduVWtOZzRwN3c4STdBUnR0cWJsK3NVL1B5UFdoUjhtSlBPZmFvMFBUdExr?=
 =?utf-8?B?RkFuc1dyekRWdWZqeEtmK3dKQ2JvQ3V0dWZNVDZqd1VITGd3ZVRBVW16dk1p?=
 =?utf-8?B?bnRGRDRYalRLN056SHAvNnMxMXZYNExDU2g0NUs3N3hHZktoYjYvcmU5OXl3?=
 =?utf-8?B?N0xWZDRlNnpZc3ZqSjltZTE1VytPdHBGYWk2SzIwWm9WZTAyTXlPTmFtZXcr?=
 =?utf-8?B?QUkweWFJNWM5TGNLdU84YjZBdGE4a09JdjZZSW1KMEdXY29PYm10bXNtOTJp?=
 =?utf-8?B?clJGMlA3RUFmR0dVZEdtUlAyUmRMekNHTWdWVkxkeHNjWUorUW00ZlhZZnoz?=
 =?utf-8?B?aURiT202SldzdlMvNkd2UlJtQXZoWk9mN2pFY3Z1eTJOOHRIeU1nNnZTbE1h?=
 =?utf-8?B?YThjejNkRjkyREF2N1hpNStlMWwyVVE5NFExSGFUWUtuMUxvTXBxd3ZlR05a?=
 =?utf-8?B?QjRIeXhDdFB1TWc5WjNxZ2gvM0VRcE9QcUs3NEJISFBjelpQMXl1cVFoSEZr?=
 =?utf-8?B?SzFRSGxyYUVIUy8wRmlCa2U3a2dEZ3hydTA2TDF2L2txSWJBUEtNYVIvekhG?=
 =?utf-8?B?TFUvbVpKNmduQnIwODF4U1Z0eUFXTXEvWHRkR2o5dFpDUmpFMjMzeUpuQXN1?=
 =?utf-8?B?OFRrUGxCMEFtN2VweG9maGpQV0ZqV0huR3o0SmtrTm5lRUlxd0hkWk52dXQ1?=
 =?utf-8?B?bDdCejFRYk5GbFFGbHlXT0RIWHZLa2t5MENNYW5XZzBPdTM5SFlZZjNyQTM4?=
 =?utf-8?Q?Bw2RkV+dmvZygHwTbuHAojfjW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67480747-9488-44cd-5df0-08dac0c9a418
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 14:09:10.1929
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s1Zkxxigg/dCsxjsJ1xdYOMEfXGT/V4/AevF/MU7BWmAb06JaYTl06/aTFEUEnAQfphaoaQQA23m4+rSxMIvmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5504
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/5/22 11:08, Cole Robinson wrote:
> On 11/4/22 4:53 PM, Borislav Petkov wrote:
>> On Fri, Nov 04, 2022 at 04:42:45PM -0400, Cole Robinson wrote:
>>> This fixes driver autoloading
>>
>> What is the scenario where this needs to be autoloaded?
>>
> 
> Any use case that needs /dev/sev-guest, I guess. Saves software from
> having to do the modprobe manually. For example, nothing I can find in
> https://github.com/AMDESE/sev-guest loads the driver, it expects
> /dev/sev-guest to be there already
> 
> Mostly I assumed lack of autoloading was an oversight. Was it
> intentionally omitted?

It probably was an oversight. To me, it makes sense to auto-load the 
module if the SNP support created the platform device as part of SNP 
initialization.

Thanks,
Tom

> 
> Thanks,
> Cole
>