Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c7b5a907-1e1f-46ba-ec1a-dd40c33dab37@amd.com>
Date:   Mon, 7 Nov 2022 15:12:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v4a 30/38] timers: dma-buf: Use timer_shutdown_sync() for
 on stack timers
Content-Language: en-US
To:     Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@kernel.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Anna-Maria Gleixner <anna-maria@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org
References: <20221105060024.598488967@goodmis.org>
 <20221105060200.357061890@goodmis.org>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20221105060200.357061890@goodmis.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnlVMkIyRUovbTdJd0JkY2Z0ZHp0OGlGa0Z1YmVsVC9tNFIreCtrOStYcXhp?=
 =?utf-8?B?YnFsTlV1bFEyNmR3MHhTM1pRSkRac1NiMTdwTEtUZGpQRUZNWUZsVzFIQkZI?=
 =?utf-8?B?OU1yTldiQkFTU2UzK3k1NllKVUVnaENzYXlCcXRFK2lQa29tT0g1OTUzb0hE?=
 =?utf-8?B?cmU4clFiaE9RODhrMHVsaE5DZUlOazZyRVBDd3BRSjc2RERZMHRDZXZSeDhl?=
 =?utf-8?B?WWFWbWVLNnFQVFVxdTRQV01vSTJGOEI4YkR6bU9HU3Z6ZWF5MFA5REJqYW5l?=
 =?utf-8?B?SjZsVi9nelIzcHRjdWVDY2wzQXRzZGdkY25vMm9ralBEbWdCU3VUc3IvMjhP?=
 =?utf-8?B?aWh0WVpGVkNmcnFSL3FJdVV6OFpEWmVYWmdqOHp2MWo1V01EVDQ0RWJXdUV6?=
 =?utf-8?B?ZEpTZFpFT2ZyZmNUczJydGxyVEM1UW04cG04OTVwRnVUN24yalY0K3RTMTBN?=
 =?utf-8?B?S1ROTVpKMEwyTXF4ZFBJSzZGelNxOTFBazd4OFgyayt5N043NnIvVU1NUXJp?=
 =?utf-8?B?NXphTzBCQUw1VytQc1JPUWNnQ09GWmpCWk9iQkU4dklvQXRDZ3Vram1zTVkr?=
 =?utf-8?B?THNKbEROckpWMURxcmFtOHJKYUNSL3VQVDFHREEyV2Nib0RNU3E3TW5PczRy?=
 =?utf-8?B?RVp3QWUwU1k5YjNxeEpHWncvMlFvSFBwK2ZGb2R1NmxJUFJxNUJPWW5RSEpW?=
 =?utf-8?B?ekd4RnJDZ21uRVJBbHV2dUxmWWJHdGJMUlBLaVE4ZzJFMGFzTHN4UmNHMUw0?=
 =?utf-8?B?Z0tPYXNTTmZwdjRXK3pLZXpGNU1Oak1EeWl2NklxOGh2NXFFQWd1OUxQV1Nu?=
 =?utf-8?B?NE9XRlQ2b2tWYUw1N0RlREdKTTQ0bDh3Vk9mTmVXNm5JOElTM2tRSVA4NUdC?=
 =?utf-8?B?bENpNTd1R2lWY0N2TDNvNU9wdFhyZWEwTjd3b05kRTVPcjNqQmY0RUVBUThJ?=
 =?utf-8?B?Y0t2anlYZS9CRGtJa0QvRjRyOUVSQ1BraXVvM044Zm9vbmRoYjNxZUkxZmVj?=
 =?utf-8?B?cGM1b2NBODg2WkxudlI4cGt1N25mbjM4d212ZmphMCsvNDhXWk9pb3JnbU5s?=
 =?utf-8?B?SHkvSllGbGdTOStvN3VNTjFvZkdhVWVtQTRPNWt4c1U5NkNxaGlnb2ZIc0No?=
 =?utf-8?B?ekNxRkNPOElwUm1FYlhYR0d6SDVBa0hrWno5SnpkOHdETDF3ZWRqZHJGRWdF?=
 =?utf-8?B?dTlmSkp5M1Nyb0M4SEtPWE5kbEtyVHZZc3A3VUdPN0xLMkt2cnFYclk5eDQx?=
 =?utf-8?B?TGlKdzdFNFg1WnllNEp1SVJWekpQZmVQcWFITThQbElTM3dRQ0Z2SGtPN2ZC?=
 =?utf-8?B?NXVSMTQxcUM0bkY5OEpBRHNRVGU5NjBveGNORFBqKzhGL0Z3UzVkWGczN0Vj?=
 =?utf-8?B?THA3WUsyRzBVWUswTHBXRDF0ME9KWTgxTjZLcFMvMHZKTjR2OHl1N1lEQUpX?=
 =?utf-8?B?NE00N3ZoUm93OHZPNE1YaVN4MmFCa1ljYjYwWmJ2U3l1cDlycmw3OFFFWGpO?=
 =?utf-8?B?QjF5c29QNXdGVk9QdVYvYzJoWUd1UDYvazNsVDdPdWF1MldjdzQrUTc5WkJI?=
 =?utf-8?B?VzdFMGpZd2Z5bXlGcU9jMHpaUTBCN0NNdzJWaEJZR1ZMQUtXUTBWRFZYR2pj?=
 =?utf-8?B?TnNob0NQdGV3Um1IK2R3Z1NINk5KeWFUaE5iZTJrZjJrcjJ2dW12djFmWUNS?=
 =?utf-8?B?ZGxZZ1lCR3pIbksvYk9YUXkwZkRIL2VyTnNFTkFMTFVWaDRyMjEwZDFLbVRG?=
 =?utf-8?B?eThXU1ZRZzVSaElOTVViQ3dxc3E3SFZONlA3cU1sNFovcU8vRVZaK0xBWDRK?=
 =?utf-8?B?R1grSnlZdFVEbXZ4UUVWbitPRmk4cXJ6RXdEL2RLNStJTmpCelBiQUNNRE1I?=
 =?utf-8?B?eEdiLzBFcHdUR21MMHV5T1FmSWhkRVZrdjFJTVcrU25NWG9NTE5nOFZaNGZZ?=
 =?utf-8?B?d3lZc244RCs3NUs0SUZhcms4d3JNU1FqNzgrNkJDMllSb2taUVJBcXMvQmZh?=
 =?utf-8?B?eHlOMk05Sm80TzlId2k0ZHZaMmgxYkpDNnR2akpQNkdRM1V1THlwOVhxNGV3?=
 =?utf-8?B?KytLSHR5N09pbCtuVDRxSit4ZlU1aFVncnpndVN4UlJhSUV1SkVLV25wdEUr?=
 =?utf-8?Q?e02Q=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0afc4d13-d90b-4e92-a6ed-08dac0ca2f3c
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 14:13:03.7433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4gvJIo1JOyHcnEFohV9OttjXZMlQVuClPW6K0L3xPOgLt5xe9RlJBnWY9ybMQl3d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4531
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 05.11.22 um 07:00 schrieb Steven Rostedt:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> Before a timer is released, timer_shutdown_sync() must be called.
>
> Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20221104054053.431922658%40goodmis.org%2F&amp;data=05%7C01%7Cchristian.koenig%40amd.com%7Cfdadde8d801e48fecafa08dabef330f4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638032248997820518%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=mEL3bFU7fZ7kSrz3vv96opdAyt7Ew4UeY2nNF%2BhDmfc%3D&amp;reserved=0
>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: linux-media@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linaro-mm-sig@lists.linaro.org
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/dma-buf/st-dma-fence.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> index fb6e0a6ae2c9..5d3e7b503501 100644
> --- a/drivers/dma-buf/st-dma-fence.c
> +++ b/drivers/dma-buf/st-dma-fence.c
> @@ -412,7 +412,7 @@ static int test_wait_timeout(void *arg)
>   
>   	err = 0;
>   err_free:
> -	del_timer_sync(&wt.timer);
> +	timer_shutdown_sync(&wt.timer);
>   	destroy_timer_on_stack(&wt.timer);
>   	dma_fence_signal(wt.f);
>   	dma_fence_put(wt.f);