Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Inbaraj E" <inbaraj.e@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <chanho61.park@samsung.com>,
        "'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
        <tomasz.figa@gmail.com>, "'Chanwoo Choi'" <cw00.choi@samsung.com>,
        "'ALIM AKHTAR'" <alim.akhtar@samsung.com>,
        <mturquette@baylibre.com>, <sboyd@kernel.org>, <robh+dt@kernel.org>
Cc:     <linux-samsung-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        "'PANKAJ KUMAR DUBEY'" <pankaj.dubey@samsung.com>
In-Reply-To: <0e929d35-2a90-94fb-49d6-7f6a0f0a3ed0@linaro.org>
Subject: RE: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
 CMU_FSYS1 mmc card clock
Date:   Mon, 7 Nov 2022 18:07:42 +0530
Message-ID: <001201d8f2a5$bcb8e870$362ab950$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQC1phSFSdu+vla0SFvWf4cJPX/nGQGqLtLGAhvc4qsBWKVYVQHZlEqXsEI86EA=
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <8f026f38-ef09-788e-7bd8-45683b074075@linaro.org>
        <20221104090019.88387-1-inbaraj.e@samsung.com>
        <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcms2p3>
        <20221107000401epcms2p3eeeecbfb2b1cdfb30dcee99bbb48780c@epcms2p3>
        <0e929d35-2a90-94fb-49d6-7f6a0f0a3ed0@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
> Sent: 07 November 2022 14:42
> To: chanho61.park=40samsung.com; Inbaraj E <inbaraj.e=40samsung.com>;
> Sylwester Nawrocki <s.nawrocki=40samsung.com>; tomasz.figa=40gmail.com;
> Chanwoo Choi <cw00.choi=40samsung.com>; ALIM AKHTAR
> <alim.akhtar=40samsung.com>; mturquette=40baylibre.com;
> sboyd=40kernel.org; robh+dt=40kernel.org
> Cc: linux-samsung-soc=40vger.kernel.org; linux-clk=40vger.kernel.org;
> devicetree=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; lin=
ux-
> kernel=40vger.kernel.org; PANKAJ KUMAR DUBEY
> <pankaj.dubey=40samsung.com>
> Subject: Re: =5BPATCH=5D dt-bindings: clock: exynosautov9: fix reference =
to
> CMU_FSYS1 mmc card clock
>=20
> On 07/11/2022 01:04, CHANHO PARK wrote:
> >>> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of
> dout.
> >>>
> >>> This fixes make dtbs_check warning as shown below:
> >>>
> >>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
> >> controller=4017040000:
> >>> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From
> schema:
> >>> /home/inbaraj/mainline/linux/Documentation/devicetree/
> >>> bindings/clock/samsung,exynosautov9-clock.yaml
> >>
> >> I don't understand:
> >> 1. Why bindings are wrong not DTSI?
> >> 2. What is =22gout=22? =22dout=22 had a meaning as clock divider outpu=
t.
> >
> > =22gout=22 is output of a gate clock, AFAIK.
> > Unlike any other clocks, the fsys1 mmc top clock does not have a divide=
r.
> So, it should be =22mout -> gout=22 instead of =22mout -> gout -> dout=22=
.
>=20
> OK, then this should be in commit msg.
>=20
> My question about full legal name remains, as here in replies I see =22In=
baraj
> E=22.
>=20

I have address your review comment, and posted v2.=20
Thanks for review.

> Best regards,
> Krzysztof