Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02a0dfa6-fb6a-25cf-4111-fb609b9b6b68@amd.com>
Date:   Mon, 7 Nov 2022 20:32:07 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] CHROMIUM: ASoC: amd: acp: Add tdm support for codecs in
 machine driver
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Mark Brown <broonie@kernel.org>
Cc:     alsa-devel@alsa-project.org, Sunil-kumar.Dommati@amd.com,
        ssabakar@amd.com, Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        Basavaraj.Hiregoudar@amd.com, Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Venkata Prasad Potturu 
        <venkataprasad.potturu@amd.corp-partner.google.com>,
        Vijendar.Mukunda@amd.com, vsujithkumar.reddy@amd.com,
        Akihiko Odaki <akihiko.odaki@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20221028103443.30375-1-venkataprasad.potturu@amd.corp-partner.google.com>
 <Y1u1vj0K3m33wCTd@sirena.org.uk>
 <b384e012-31c5-8412-8b05-cd026c5d6a0f@amd.com>
 <Y2EttkwUvMReQcqg@sirena.org.uk>
 <ca006546-9b0c-34df-2a33-a4f10b68f815@amd.com>
 <Y2JVWmJsprt0xnKH@sirena.org.uk>
 <7b97682d-5cf1-8be1-9c62-41c9fbd89018@amd.com>
 <dff6e7af-6a07-587e-79d0-706fe7ec6504@linux.intel.com>
From:   Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
In-Reply-To: <dff6e7af-6a07-587e-79d0-706fe7ec6504@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVJDck9rZ2tFbXIyZE4zbDhrYWJ5bDE2QkFHUitONWcrNks5bWFRNERJRkE1?=
 =?utf-8?B?MGJSSXJzMFErb2N0a3lOazgwMjhXdHpDVERzdDhXT0x6eEw5RXpuSE4venlO?=
 =?utf-8?B?bzAxNnRiVGd1OUxZWnBzeURSb1FTbUpnSW5HeEFadGpqOUg3c25PWndkU2VC?=
 =?utf-8?B?OGxhSWRZTU4xN1IxcTFUc3hmV2J2WXpTZ1pvSi9pWDBNaEt6THlsY0NOOHJV?=
 =?utf-8?B?VXBHK05KbnRsMWpDN0FqL3c0Y0JvcUhmK3loN2lPLzQ1Q1VvN1gxVDlYZlNw?=
 =?utf-8?B?U29NaWpQUUNIWGk3cTNSL0ZuWmVqbS9samRyYUJqRllZWVlUVW9GY1A2dWNC?=
 =?utf-8?B?aU1tUHZTblczcDhMYWY1NjJBZjhMRHZRQXdFMDYvWVFlSlorVUxJT3MrZkgw?=
 =?utf-8?B?VE44aXdPN3RIT1A0UVVqMEtkVjE0Ymd6RlZGSys5dlBDai9GUlBLSVluanRT?=
 =?utf-8?B?K1A2RTc3dFJZbFFkOTNTL3JWZWxsaDlXakQrNXpFOWlRcGFQMVp0R0cxOU1J?=
 =?utf-8?B?eDdqanhVZXVFM1J1ZTJqWTQrWmNCQ0NOaGgwUnNSdW1ieGZpOS91b0UxdTZn?=
 =?utf-8?B?U0UxT3NhUnhIZVp2YWpVRWllaUJOQTY5eFB2ZWFvSTZueXM0TjhhYVFVTktW?=
 =?utf-8?B?MTMrc3l3eXgwY1lKOEhlaEJ3OEdRZDhTaHYvUFQxUWxDNE9UU1MvdmZpbWgz?=
 =?utf-8?B?bUY0SGpUZld1T1pWVThuWUpmQXBaV1pPWlNkMS9vbElVNEI5alcrdFVndkhZ?=
 =?utf-8?B?c284OVY3UUl2Z1lKWnh1Mi9wN0FtWHJ2aXJNVHJOak5ldi9HMU83ZWFxOUNu?=
 =?utf-8?B?OUJZSHZsaW5NcEJvL3ptVmNBTFF0VE9jUGZQRmx1V0h0RDlTL0JzREdGWERy?=
 =?utf-8?B?KzNDanJoSXcrWTRpa1BDNyt1SVR1S1NwS2gxK1ZXY1habHFIUUwrSTFZeDVw?=
 =?utf-8?B?cDB3cW9aczltUkdLWTQ1TWVMcXJuRzVpV2JhQzNoc2Vza2FSNkVUUXo5OCtD?=
 =?utf-8?B?ajQxTzBZNERBR3NjQUdLd1RuNnVWbnYwUWJLdWQ0aG4zOTNwd2E5RVhKRVFZ?=
 =?utf-8?B?VU5FUjlXRVYxSVczeVVHVS9QTElhY2ViRU84UWZnS3BhT2dPV1gra0lZM2Zx?=
 =?utf-8?B?ZzIzQVhZOGwrLzJWMVpzQjc5bnJUSVBna3haMHNTK2xJdkt6alA0M295NWpV?=
 =?utf-8?B?Y1A1bjVDblQ1TzQvRFU1TzBmb1pVeEEyWEwzbFdhTkw0SndPVUp2cExrSmVo?=
 =?utf-8?B?NEEwZTNxNTRKR0xJS3E4S21adG42cEVVMFZWdXpPSHFDbkZLcVNhaTVRY1py?=
 =?utf-8?B?V1RFTmJtclArb0M2Y1NyMG1CZWhhU0dGRTdTbVNSWStRVDQxL1RYMGFsQVBU?=
 =?utf-8?B?YUZWbWFmWWs5dGpZTXhwWGJSVjBVZVFMaUY2UGErWEhqZmtHWHpoNGJZT0Iv?=
 =?utf-8?B?amZvK25rblNndG92UWtrbjh4UDhmbmNUdHJXK1ZUK0syMWI4N2N0ZTA2ZzdJ?=
 =?utf-8?B?bmJiMWliT25GNHc5MjdodE5jZVYyL2dNOERMQjJ5M2ZkMFhUazU3MURFUktF?=
 =?utf-8?B?L2gzMzZ4WmxQZEFkN0d0VVJ0Q0ZDQ2JtREJhODhIdXNDNC95WENvV1pCRXYx?=
 =?utf-8?B?TWh0UFUrajY1MWY5VVlRQ3dMV1N1OC9ZUGNuTGh4dnliZnlObk1iQ0dabXlz?=
 =?utf-8?B?V0FpMFJCdVhZMGJtN2o4T0RjVHlpZjIxb29VbzVEU2hWdVZuNERvYnlablZH?=
 =?utf-8?B?NGVuRERDNm9iMkpib2VTeENDeG1RZkFjQlVtRnVKSTYzV2xQQWxGcFY2Q0dJ?=
 =?utf-8?B?OTZUUm9Eb3hwc0ZoS1JWY0VmVXNwT2w1ellSWFYvcnlBaHVHN0UzMkd1Q0tj?=
 =?utf-8?B?bmY0QTN4NlkzZmpENDc2UWZLVVVjVGxiamtwZ2xVVnhwQUQ4clYzaGJLWjBI?=
 =?utf-8?B?SlFhQ1JZMGc3UmpPMlRFMkh2MTQwc29TdmJFQ0lLQThmZGtEY295MlhtSjdI?=
 =?utf-8?B?VjRIRjMwbHF5NVpvNk1sWkxSSnBIeC9vWEVqeGpuK2lNU0krL3RxbUJMd3VS?=
 =?utf-8?B?SnBna2xNMVR3Y1MzRGkrUnZVTzAyblVKVmxxNW1ENVIzSUpXYzE5SDRFUWJm?=
 =?utf-8?Q?M8YzPWPZV2z/JPPIR+Ry3kXDm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06434253-875a-4f9f-c921-08dac0d0825d
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5951.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 14:58:20.0198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ecHOeg3zJ3z4lmS7E1v1i4i+7eOCHZdtcUIuXbXRHb3ItMiQchFKp0yFqndWDLe+Eotr39vvUHXxrBFyfSqpHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7284
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/7/22 19:44, Pierre-Louis Bossart wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On 11/7/22 04:34, Venkata Prasad Potturu wrote:
>> On 11/2/22 17:02, Mark Brown wrote:
>>>> On 11/1/22 20:01, Mark Brown wrote:
>>>>> On Tue, Nov 01, 2022 at 03:15:08PM +0530, Venkata Prasad Potturu wrote:
>>>>> Right, that's what the code does but why is this something that should
>>>>> be controlled in this fashion?
>>>> This machine driver is common for TDM mode and I2S mode, user can
>>>> select TDM
>>>> mode or I2S mode.
>>> Why would the user choose one value or the other, and why would this
>>> choice be something that only changes at module load time?  If this is
>>> user controllable I'd really expect it to be runtime controllable.
>>> You're not explaining why this is a module parameter.
>> Different vendors/OEM's use the same hardware as one need I2S mode and
>> other need TDM mode, using common driver  to support  I2S and TDM mode
>> with this parameter.
>>
>>
>> static int tdm_mode = 0;
>> module_param_named(tdm_mode, tdm_mode, int, 0444);
>>
>> And this can be runtime controllable by setting permissions as 0644, we
>> will change and send next version patch.
> kernel parameters are difficult to manage for distributions using a
> single-build. Either all platforms use the kernel parameter or none of
> them do. That would not allow a per-platform choice of parameters.
> Using DMI quirks or ACPI identifiers would be a lot less problematic, no?

All platforms use the kernel parameter to select the I2S/TDM mode.
Runtime parameters are not required here, by default it is in I2S mode and
when the platform needs to enable TDM mode then pass tdm_mode module 
parameter as 1.