Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 07 Nov 2022 18:02:34 +0300
From:   Yassine Oudjana <yassine.oudjana@gmail.com>
Subject: Re: [PATCH] extcon: usbc-tusb320: Call the Type-C IRQ handler only if
 a port is registered
To:     Marek Vasut <marex@denx.de>
Cc:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Alvin =?iso-8859-2?q?=A9ipraga?= <alsi@bang-olufsen.dk>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yassine Oudjana <y.oudjana@protonmail.com>
Message-Id: <AGGZKR.PDKF4SHFJVZC3@gmail.com>
In-Reply-To: <49a553b3-bd79-7845-41c4-2b8a3a3d4932@denx.de>
References: <20221107144810.588755-1-y.oudjana@protonmail.com>
        <49a553b3-bd79-7845-41c4-2b8a3a3d4932@denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Precedence: bulk


On Mon, Nov 7 2022 at 15:51:55 +01:00:00, Marek Vasut <marex@denx.de> 
wrote:
> On 11/7/22 15:48, Yassine Oudjana wrote:
>> From: Yassine Oudjana <y.oudjana@protonmail.com>
>> 
>> Commit bf7571c00dca ("extcon: usbc-tusb320: Add USB TYPE-C support")
>> added an optional Type-C interface to the driver but missed to check
>> if it is in use when calling the IRQ handler. This causes an oops on
>> devices currently using the old extcon interface. Check if a Type-C
>> port is registered before calling the Type-C IRQ handler.
>> 
>> Fixes: bf7571c00dca ("extcon: usbc-tusb320: Add USB TYPE-C support")
>> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
>> ---
>>   drivers/extcon/extcon-usbc-tusb320.c | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/extcon/extcon-usbc-tusb320.c 
>> b/drivers/extcon/extcon-usbc-tusb320.c
>> index 41041ff0fadb..037bc11b2a48 100644
>> --- a/drivers/extcon/extcon-usbc-tusb320.c
>> +++ b/drivers/extcon/extcon-usbc-tusb320.c
>> @@ -327,7 +327,14 @@ static irqreturn_t tusb320_irq_handler(int irq, 
>> void *dev_id)
>>   		return IRQ_NONE;
>>     	tusb320_extcon_irq_handler(priv, reg);
>> -	tusb320_typec_irq_handler(priv, reg);
>> +
>> +	/*
>> +	 * Type-C support is optional for backward compatibility.
> 
> It's the other way around, extcon is the legacy, type-c is the new, 
> right ?

Type-C is the new one, yes. This comment is somewhat similar to the one 
in tusb320_typec_probe():

/* The Type-C connector is optional, for backward compatibility. */

Perhaps a better way to say this in both comments would be "to 
maintain" instead of "for".

> 
>> +	 * Only call the Type-C handler if a port had been registered
>> +	 * previously.
>> +	 */
>> +	if (priv->port)
>> +		tusb320_typec_irq_handler(priv, reg);
>>     	regmap_write(priv->regmap, TUSB320_REG9, reg);
> 
> Reviewed-by: Marek Vasut <marex@denx.de>
> 
> Thanks!

Thanks for the quick review!
Yassine