Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Nov 2022 16:30:27 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Fei Li <fei1.li@intel.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org, peterz@infradead.org,
        dave.hansen@intel.com, gregkh@linuxfoundation.org,
        tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        hpa@zytor.com, Yu1.Wang@intel.com, conghui.chen@intel.com,
        fengwei.yin@intel.com
Subject: Re: [PATCH v2] x86/acrn: Set X86_FEATURE_TSC_KNOWN_FREQ
Message-ID: <Y2kkk+XqBP3u6ObI@zn.tnic>
References: <20221101053019.174948-1-fei1.li@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221101053019.174948-1-fei1.li@intel.com>
Precedence: bulk

On Tue, Nov 01, 2022 at 01:30:19PM +0800, Fei Li wrote:
> If the TSC frequency is known from the acrn_get_tsc_khz(),
> the TSC frequency does not need to be recalibrated.

What if the HV has unstable TSCs? How do you handle that?

> Avoiding recalibration by setting X86_FEATURE_TSC_KNOWN_FREQ.

Pls read section "2) Describe your changes" in
Documentation/process/submitting-patches.rst for more details on how to
write your commit message.

> This patch also removes `inline` for acrn_get_tsc_khz() since
> it doesn't make sense.

Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.

Also, do

$ git grep 'This patch' Documentation/process

for more details.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette