Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1998816rwb; Mon, 7 Nov 2022 08:04:16 -0800 (PST) X-Google-Smtp-Source: AMsMyM4FfOi5decwemWxT4IJExsyAlXJcasZ0Pt9XG8kRuqJwpHrVf8DCY9XEycWqw1K61aDFBEI X-Received: by 2002:a17:903:268c:b0:186:f81d:3358 with SMTP id jf12-20020a170903268c00b00186f81d3358mr51591210plb.129.1667837056054; Mon, 07 Nov 2022 08:04:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667837056; cv=none; d=google.com; s=arc-20160816; b=GqBJWwiUL/G9k5qqyJfaI0LloJ4VVCgzDHf7bOuBfuDBzvxXznrdDzEAAT1LfLR3+S l2LjNyVO0QR9NdqwtI9y/yvMw8nOx0zm4i5Tx9gG7gGHw4f3NBj5xNJucdzDEFeRZhMl 7yI0DOMs5qR9Pdq5ZbeybV311rv0Ng1oiq+EtsS1XkeRlNmPWS9YO04tOPdrEW2JTGnn sPuKOmTki6smFSX91asYdAcUoIL8figdYtjMaQ/MysnGHW2W6MjjKNTdmBIEttTTycdF x5cepypm/QQqYd0MbHBZ4wfQjGvQxd3+TwClTyc6/fIyuF2NwgyA3OycTzLjwEn4ufrV 1FEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=c2CoTYYkSpK+sQj3p0R6Cfi101yt3YpQVds/7qZK0/E=; b=xaRUzjY2B0nQdxLWBSX3oyCSwshX1z4E5DRT3sOrOQCspIK8QrIFmCehCsH4xv0sWB DEChFlPjpdB2q/GdHWnHJ8vT81mrerUnKjp6pGX2YIMAXIcZyIPyP5lagZsdikEPgUjD 7YLoZE2aU5CLKyiuWPJTTbjB60oV1wrDcIfoXpWZ7us2E11uoy15NUZ2FKDrQgsL5N5m MM0clMUecSoRAQxoIeXHeyyaLFAklUkQeELfuEL1/6OqRwPc9L1KZlG7xKSRGNvU/Vi2 Y7EkCXQhPJ3GLLz0svRtQ7M/n7RJJoeVDTqWgX5xl/U6L1GUtToekZoQ9d7SGwgRWT/6 OkFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BC4wd+UV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d6-20020a63d646000000b00458085e9e70si10677203pgj.577.2022.11.07.08.03.54; Mon, 07 Nov 2022 08:04:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BC4wd+UV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232164AbiKGOoW (ORCPT + 93 others); Mon, 7 Nov 2022 09:44:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232152AbiKGOoS (ORCPT ); Mon, 7 Nov 2022 09:44:18 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ED12959C for ; Mon, 7 Nov 2022 06:44:17 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id ud5so30750376ejc.4 for ; Mon, 07 Nov 2022 06:44:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=c2CoTYYkSpK+sQj3p0R6Cfi101yt3YpQVds/7qZK0/E=; b=BC4wd+UVzNToFcbV2iVIZ9rGyRHo5M8PVDarYeufP55XrNjp8E1FCWyEVKl5CwoaY0 lR+2atWzyXzMT4A3XPzWTFWDeHC3PbLvpogP9fta5cjFa5fbBaxIkMw1HGIi4P3d4I0c cza+mPzRFrTO1Rt27xiHBYqwdjRL5KfCWBTXsVRvLCXieB2HMwTp2CgraQPvvydqRQZd 60i1wgkl4fnrTjNLVC5yiPE7Is22jItfeRhURFn6lCwPcOQxM0jk5dc+VfQ/tBUOZCmQ 64TuCMlV4E8PCMTg22qLzhIbbSAXqpPkwC5iRK3DKGCbpSfEXTrajEXqk0yF3bDgFQ4f mM1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c2CoTYYkSpK+sQj3p0R6Cfi101yt3YpQVds/7qZK0/E=; b=tiwjPRMGgjDI1aGRlIMuFmC/kc+QY58PoFde4rln7jjBkpgvv8ka6GvPnAMsthmZg6 0kbDoM3U9QpAykyZN75dkAWa6MK2vugYIZg8kIygBEcL0A1aGflTuCdF/SFNuNNSmP51 nlcOIgoR4wtLTGZV7b9zNukLnNwPgycy84HQdDsaZb08qIOTSQXoIT2TO6yrOPynhNNL lC/2RaV90hbrPXg3a27pZH+fXGQ0AApFV7vpHMBW/eIZTAqHNrs9Rd64OFL6Gb5ga/84 7S5c0mu1G3xQOQTDx3VqviRAXQPyHT7rumQ5KE0D/HrZkJ73SoI8wcupr+A6D+LGaWT/ qEug== X-Gm-Message-State: ACrzQf2Ysh4tDtgw2pVFu6BO1lWMc6jHAF9foPsfkKiYNMr0w/sRQBb7 1hgR435ST8L8a3KV68b+CgDBvXW+1+71EXZZHCjwPA== X-Received: by 2002:a17:907:c1e:b0:7ae:31a0:571e with SMTP id ga30-20020a1709070c1e00b007ae31a0571emr16653409ejc.690.1667832256100; Mon, 07 Nov 2022 06:44:16 -0800 (PST) MIME-Version: 1.0 References: <20221021084708.1109986-1-bchihi@baylibre.com> In-Reply-To: <20221021084708.1109986-1-bchihi@baylibre.com> From: Linus Walleij Date: Mon, 7 Nov 2022 15:44:05 +0100 Message-ID: Subject: Re: [v2, 0/2] Fix broken SET/CLR mode of a certain number of pins for MediaTek MT8385 SoC To: bchihi@baylibre.com Cc: sean.wang@kernel.org, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2022 at 10:47 AM wrote: > From: Balsam CHIHI > > On MT8365, the SET/CLR of the mode is broken and some pins won't set or clear the modes correctly. > To fix this issue, we add a specific callback mt8365_set_clr_mode() for this specific SoC. > This callback uses the main R/W register to read/update/write the modes instead of using the SET/CLR register. > > This is the original patch series proposed by Fabien Parent . > "https://lore.kernel.org/linux-arm-kernel/20220530123425.689459-1-fparent@baylibre.com/" > > Changelog: > Changes in v2 : > - Rebase on top of 6.1.0-rc1-next-20221020 > - Delete MTK_PINCTRL_MODE_SET_CLR_BROKEN quirk > - Add mt8365_set_clr_mode() callback Patches applied, no need to resend for small issues. Sorry for taking so long, I wanted some feedback from the Mediatek maintainers but haven't heard anything, so I just applied them. Yours, Linus Walleij