Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2042032rwb; Mon, 7 Nov 2022 08:30:11 -0800 (PST) X-Google-Smtp-Source: AMsMyM5IXbECM0fOJKq4tqbc0a/8ctzwHLD/B4WUKJ9uYDe54K3ODMr3wsRorExTrjSWo4SZfvYG X-Received: by 2002:a63:c14:0:b0:456:d887:c83 with SMTP id b20-20020a630c14000000b00456d8870c83mr44805097pgl.53.1667838611069; Mon, 07 Nov 2022 08:30:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667838611; cv=none; d=google.com; s=arc-20160816; b=0CC5TMOBSo0xQAOedXwzhVDviTkDQtS0oCpsEkPjZdnZ8n29DxOzoh/dZ5IlURVnlP 7rgbmmLW19vqhb4qI2gAQ1iTe2s4OcQCAIXlkso017pw+qRr//SebiQ9++/SF0r28FBG LdAJ8QAsl10+43xiFnQ0355on6Ed0YE2uO89vMZVqcs8y3970/2uUC8JU21guRnuBLxi 5mlanr/XF/bOI7OOC2o83O80abva1mudSgspFoKmEweiFlhc48YwoLKGUimziocCR5H0 KkD6g3lDQrVv3QiVnb3/HvfMDOOROOLL2zX313HRtIvtrUH84FRPGjLl+v+6Dk2/YqP3 2N/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UbbCBm1eBZ2zIHN3XWo9t4J+cAWKhV3lkE1Len3Ewko=; b=v/XEWJ51C0rYSh2QcGogKaiortSBtabukF7RDnVOxcoOP8OrbX+66dLtnUEsJ8g/Lf RpuoB20t++lkxf8MsJ7fry4TetP44ii0JwDM9VGp3cwSJ7zMxdkafY+Id3ry9vBtz56x yZkA9hWlOSdv/dmG/bNKlxzp6+SD8k3S/ZUN1pDB6GKNyrqOErFOAeamgh6R4C9i7vmz BMyuOHz76j4sU7ZRxBm91SGGSQZQS1sg7YSqhWUbl2m/FSg6AK9N/1qwjqrPb/4hCU2P hcZcVyWasdez8ldqaYXDDrMFaYa6VAaSTmEL1NyZikO0lOwanlraUbuv6lv6KKCLKUVN 5iFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Kium0O9P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nn4-20020a17090b38c400b0020ad8a730dbsi11659673pjb.58.2022.11.07.08.29.58; Mon, 07 Nov 2022 08:30:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Kium0O9P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231966AbiKGQV5 (ORCPT + 93 others); Mon, 7 Nov 2022 11:21:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232040AbiKGQVA (ORCPT ); Mon, 7 Nov 2022 11:21:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23A2F17898 for ; Mon, 7 Nov 2022 08:19:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667837977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UbbCBm1eBZ2zIHN3XWo9t4J+cAWKhV3lkE1Len3Ewko=; b=Kium0O9PEHW90zf1HwDFYb853eSD+zF1isjhXq1W2ip2+VpRBGxv+eo6qWo9A5Kl9jOTO3 7jLmfALRLKkyec+nd8EddVCifgphCanYxHwu5GTTANfwt0p4f76D0wtb/YPTfBcQ4P7JtJ UEKX1OAuhKzJwrIBFjZJgU3IB2pvwRQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-271-EWhylD7YPUCsp45VLDkKVw-1; Mon, 07 Nov 2022 11:19:33 -0500 X-MC-Unique: EWhylD7YPUCsp45VLDkKVw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D5D6038149A7; Mon, 7 Nov 2022 16:19:31 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.39.195.106]) by smtp.corp.redhat.com (Postfix) with ESMTP id 421834B3FC6; Mon, 7 Nov 2022 16:19:26 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-kselftest@vger.kernel.org, David Hildenbrand , Linus Torvalds , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Tomasz Figa , Marek Szyprowski , Mauro Carvalho Chehab Subject: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage Date: Mon, 7 Nov 2022 17:17:37 +0100 Message-Id: <20221107161740.144456-17-david@redhat.com> In-Reply-To: <20221107161740.144456-1-david@redhat.com> References: <20221107161740.144456-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org FOLL_FORCE is really only for debugger access. According to commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always writable"), the pinned pages are always writable. FOLL_FORCE in this case seems to be a legacy leftover. Let's just remove it. Cc: Tomasz Figa Cc: Marek Szyprowski Cc: Mauro Carvalho Chehab Signed-off-by: David Hildenbrand --- drivers/media/common/videobuf2/frame_vector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/media/common/videobuf2/frame_vector.c index 542dde9d2609..062e98148c53 100644 --- a/drivers/media/common/videobuf2/frame_vector.c +++ b/drivers/media/common/videobuf2/frame_vector.c @@ -50,7 +50,7 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames, start = untagged_addr(start); ret = pin_user_pages_fast(start, nr_frames, - FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, + FOLL_WRITE | FOLL_LONGTERM, (struct page **)(vec->ptrs)); if (ret > 0) { vec->got_ref = true; -- 2.38.1