Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2057068rwb; Mon, 7 Nov 2022 08:40:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf5F2F8sExY3j20QmvdElNCfgjc1Anzs9vywHmLT6YwxFWoXl6LmtfD1alqcLrjLv+WV14C0 X-Received: by 2002:a63:f844:0:b0:470:7d25:5c94 with SMTP id v4-20020a63f844000000b004707d255c94mr3973628pgj.603.1667839203488; Mon, 07 Nov 2022 08:40:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667839203; cv=none; d=google.com; s=arc-20160816; b=f0InSFbQGt2pZghLhkN9F3vRP5HV0yFakfe8RPNrYxZFe7RnE0WGj5Ab50ncfF6Wj8 mcVRZFuDR688xTRvpVEU7hooPIu8YD3nza7el2g5yBWt41opkKC+9GO1L4OrUDeW7Lqd 6rddYlg9ZOMuoF19wAOhAqafIDQpQWDZZQ+Yyhr+zCHgxgENuTEmFhwuhLTmtZ2ySHPC NcCucYHlIM0lwpcjHXfYeKSiL23kHNRj5Szr6NYoA5rJ7IVP0YV/GZ1dQdYO522ocsI8 tP+4rsCo6F9+5T5hFHiI1YOj9XIn0KoCqsRsc17hyxDIL/v8BIjTehea6LzjuZSp5MtS aXeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=s50hR/GCzmFQRvNbtM/53m/Jdy4zBTTllf2Oe2mGHDA=; b=uRkLsT7Xstc0QK3tvmQxwsH07/qGA5oEMpyvsawU+bQ6uXSfxkPASrwfgAZyJEmY7i VZ/XOEmthBiW9EqG58DpXUfwejny/4SEjJ9+Hmc7HUWa5O0aAZSxi1sLLSQIfwZXNSJA bd8aIpgCYhl+nHroKbvC0+G3wGdwUPuO48dbFsaX0H7lrg5Lh0g6IACUkyxrKGp7ZOOJ eJIxox9Ua/6iyLc6cng/NChhpiBn1aHfgftKnqbHqUJUEEqG3O7HZFXFqxcrc3UM2P3Z 9QOF0lHz149TG/3zeE94+zECgVkM2RSOEYNOc1XL6fShArxJLoh8e/qLTJlcda1FTEu7 QlPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="QigOjB/r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v21-20020a63b955000000b00470275bada8si11035899pgo.281.2022.11.07.08.39.50; Mon, 07 Nov 2022 08:40:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="QigOjB/r"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232528AbiKGQ2d (ORCPT + 92 others); Mon, 7 Nov 2022 11:28:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232702AbiKGQ2M (ORCPT ); Mon, 7 Nov 2022 11:28:12 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9E3224BE8 for ; Mon, 7 Nov 2022 08:25:17 -0800 (PST) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2A7CrqAV013913; Mon, 7 Nov 2022 16:24:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=s50hR/GCzmFQRvNbtM/53m/Jdy4zBTTllf2Oe2mGHDA=; b=QigOjB/rYStnzvlgyYK2BJof3turH6m6rO9epIxXz6AdxRNTOXAmrr25XjraelCQyAav PBL2UgdC+V5QqzfbW3LPSbIGLtJoi/n9i6H8LcyCWU9On9xoT/ghXbImvkEOgF+gMpfh JA5+v9mb3OkouZVbRqaYCski0PHLaN2cb61ZvAiupbeS2hX6TJFyNfJEoRQmLGKBKD/g onp4kQt5hwijqIxmsrAS/s+jrOa8zEJR2ejDYFXVZcHJ57sjm66LVr4i5TuQlpuce8Gn m8AjCYJwTO1XW5+GdyLFHCx/FQo2lja8qYo2gazo9MDye4JIIGmhqvJf6+FP0OMAmSoW 7w== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3kphj8j8qa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Nov 2022 16:24:56 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2A7GOtS3011461 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 7 Nov 2022 16:24:55 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 7 Nov 2022 08:24:53 -0800 Message-ID: <2537e41d-f863-4819-57d2-09b9554f801b@quicinc.com> Date: Mon, 7 Nov 2022 09:24:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [RFC PATCH v3 3/3] drm: initialize accel framework Content-Language: en-US To: Oded Gabbay , David Airlie , Daniel Vetter , Arnd Bergmann , Greg Kroah-Hartman , , , Jason Gunthorpe , John Hubbard , Alex Deucher CC: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Yuji Ishikawa , Jiho Chu , Daniel Stone , Tvrtko Ursulin , Christoph Hellwig , Kevin Hilman , Jagan Teki , Jacek Lawrynowicz , Maciej Kwapulinski , Stanislaw Gruszka , Randy Dunlap References: <20221106210225.2065371-1-ogabbay@kernel.org> <20221106210225.2065371-4-ogabbay@kernel.org> From: Jeffrey Hugo In-Reply-To: <20221106210225.2065371-4-ogabbay@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: -yaopUW5-8pXniYB_FOCekDEa0cF5-fA X-Proofpoint-ORIG-GUID: -yaopUW5-8pXniYB_FOCekDEa0cF5-fA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-07_08,2022-11-07_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 spamscore=0 impostorscore=0 adultscore=0 priorityscore=1501 phishscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211070131 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/6/2022 2:02 PM, Oded Gabbay wrote: > @@ -603,6 +626,14 @@ static int drm_dev_init(struct drm_device *dev, > /* no per-device feature limits by default */ > dev->driver_features = ~0u; > > + if (drm_core_check_feature(dev, DRIVER_COMPUTE_ACCEL) && > + (drm_core_check_feature(dev, DRIVER_RENDER) || > + drm_core_check_feature(dev, DRIVER_MODESET))) { Shouldn't the indentation for the 2nd and 3rd line be such that the start of the lines is aligned with the "(" on the first line?