Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Nov 2022 08:25:22 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     davem@davemloft.net, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        thomas.petazzoni@bootlin.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Robert Marko <robert.marko@sartura.hr>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH net-next v8 3/5] net: dsa: add out-of-band tagging
 protocol
Message-ID: <20221107082522.2e95bebc@kernel.org>
In-Reply-To: <20221107093950.74de3fa1@pc-8.home>
References: <20221104174151.439008-1-maxime.chevallier@bootlin.com>
        <20221104174151.439008-4-maxime.chevallier@bootlin.com>
        <20221104200530.3bbe18c6@kernel.org>
        <20221107093950.74de3fa1@pc-8.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 7 Nov 2022 09:39:50 +0100 Maxime Chevallier wrote:
> > Also the series doesn't build. =20
>=20
> Can you elaborate more ? I can't reproduce the build failure on my
> side, and I didn't get any reports from the kbuild bot, are you using a
> specific config file ?

../net/core/skbuff.c:4495:49: error: invalid application of =E2=80=98sizeof=
=E2=80=99 to incomplete type =E2=80=98struct dsa_oob_tag_info=E2=80=99
 4495 |         [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta=
g_info),
      |                                                 ^~~~~~
../include/uapi/linux/const.h:32:44: note: in definition of macro =E2=80=98=
__ALIGN_KERNEL_MASK=E2=80=99
   32 | #define __ALIGN_KERNEL_MASK(x, mask)    (((x) + (mask)) & ~(mask))
      |                                            ^
../include/linux/align.h:8:33: note: in expansion of macro =E2=80=98__ALIGN=
_KERNEL=E2=80=99
    8 | #define ALIGN(x, a)             __ALIGN_KERNEL((x), (a))
      |                                 ^~~~~~~~~~~~~~
../net/core/skbuff.c:4476:34: note: in expansion of macro =E2=80=98ALIGN=E2=
=80=99
 4476 | #define SKB_EXT_CHUNKSIZEOF(x)  (ALIGN((sizeof(x)), SKB_EXT_ALIGN_V=
ALUE) / SKB_EXT_ALIGN_VALUE)
      |                                  ^~~~~
../net/core/skbuff.c:4495:29: note: in expansion of macro =E2=80=98SKB_EXT_=
CHUNKSIZEOF=E2=80=99
 4495 |         [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta=
g_info),
      |                             ^~~~~~~~~~~~~~~~~~~
../net/core/skbuff.c:4495:49: error: invalid application of =E2=80=98sizeof=
=E2=80=99 to incomplete type =E2=80=98struct dsa_oob_tag_info=E2=80=99
 4495 |         [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta=
g_info),
      |                                                 ^~~~~~
../include/uapi/linux/const.h:32:50: note: in definition of macro =E2=80=98=
__ALIGN_KERNEL_MASK=E2=80=99
   32 | #define __ALIGN_KERNEL_MASK(x, mask)    (((x) + (mask)) & ~(mask))
      |                                                  ^~~~
../include/linux/align.h:8:33: note: in expansion of macro =E2=80=98__ALIGN=
_KERNEL=E2=80=99
    8 | #define ALIGN(x, a)             __ALIGN_KERNEL((x), (a))
      |                                 ^~~~~~~~~~~~~~
../net/core/skbuff.c:4476:34: note: in expansion of macro =E2=80=98ALIGN=E2=
=80=99
 4476 | #define SKB_EXT_CHUNKSIZEOF(x)  (ALIGN((sizeof(x)), SKB_EXT_ALIGN_V=
ALUE) / SKB_EXT_ALIGN_VALUE)
      |                                  ^~~~~
../net/core/skbuff.c:4495:29: note: in expansion of macro =E2=80=98SKB_EXT_=
CHUNKSIZEOF=E2=80=99
 4495 |         [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta=
g_info),
      |                             ^~~~~~~~~~~~~~~~~~~
../net/core/skbuff.c:4495:49: error: invalid application of =E2=80=98sizeof=
=E2=80=99 to incomplete type =E2=80=98struct dsa_oob_tag_info=E2=80=99
 4495 |         [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta=
g_info),
      |                                                 ^~~~~~
../include/uapi/linux/const.h:32:61: note: in definition of macro =E2=80=98=
__ALIGN_KERNEL_MASK=E2=80=99
   32 | #define __ALIGN_KERNEL_MASK(x, mask)    (((x) + (mask)) & ~(mask))
      |                                                             ^~~~
../include/linux/align.h:8:33: note: in expansion of macro =E2=80=98__ALIGN=
_KERNEL=E2=80=99
    8 | #define ALIGN(x, a)             __ALIGN_KERNEL((x), (a))
      |                                 ^~~~~~~~~~~~~~
../net/core/skbuff.c:4476:34: note: in expansion of macro =E2=80=98ALIGN=E2=
=80=99
 4476 | #define SKB_EXT_CHUNKSIZEOF(x)  (ALIGN((sizeof(x)), SKB_EXT_ALIGN_V=
ALUE) / SKB_EXT_ALIGN_VALUE)
      |                                  ^~~~~
../net/core/skbuff.c:4495:29: note: in expansion of macro =E2=80=98SKB_EXT_=
CHUNKSIZEOF=E2=80=99
 4495 |         [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta=
g_info),
      |                             ^~~~~~~~~~~~~~~~~~~


Also this:

drivers/net/ethernet/qualcomm/ipqess/ipqess.c:1172:22: warning: cast to sma=
ller integer type 'u32' (aka 'unsigned int') from 'void *' [-Wvoid-pointer-=
to-int-cast]
        netdev->base_addr =3D (u32)ess->hw_addr;
                            ^~~~~~~~~~~~~~~~~