Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     Maxime Chevallier <maxime.chevallier@bootlin.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Robert Marko <robert.marko@sartura.hr>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH net-next v8 3/5] net: dsa: add out-of-band tagging
 protocol
Thread-Topic: [PATCH net-next v8 3/5] net: dsa: add out-of-band tagging
 protocol
Thread-Index: AQHY8HTAfetHoGxM5E6HcRPQNrr8s64vpgIAgAOw8wCAABdsAIAAQokAgAAESoA=
Date:   Mon, 7 Nov 2022 17:04:55 +0000
Message-ID: <20221107170455.dqyf5lf55lot2hra@skbuf>
References: <20221104174151.439008-1-maxime.chevallier@bootlin.com>
 <20221104174151.439008-4-maxime.chevallier@bootlin.com>
 <20221104200530.3bbe18c6@kernel.org> <20221107112736.mbdfflh6z37sijwg@skbuf>
 <20221107125126.py5n244zk3inawsx@skbuf> <20221107084934.157becba@kernel.org>
In-Reply-To: <20221107084934.157becba@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?w9XC2G976XBUZIQEgAbyZN+UJ9feA7vB8yrQbXt3wYhFHNYBS6RIib80NktR?=
 =?us-ascii?Q?BPFWBn6akImTBPwcU9FhMSHZsUGwLXVqQfD5mr2fcHnnJlSLadYcoNroEaSG?=
 =?us-ascii?Q?Y3y2vS1zuNRKWv6/Hk2kdt2zOwygE9i94PpVlgwaEJ4PLwNDxuF6ZevRizzm?=
 =?us-ascii?Q?BtU1h/QYv0VGkkv7qcPxLKxfJFgEVSZ3U1ao5esu0Nxb3JrjC9YF+O17Rfaf?=
 =?us-ascii?Q?LormMzPVrj5j55SpGPjoKrvJ2Igguxnj+782tzU6bCaNOVrLJrrmwCYvrQ2c?=
 =?us-ascii?Q?E9p82gHMLMYx9Y5h5n/jNYG6q4Nf3nAgl/ccnJbfPj3BILG96KFJWE+m1vya?=
 =?us-ascii?Q?Hy3FtgU0G3dSe1nrAD/Ca06M+V62AVPQuxVRDR9lyUHtkEsnIyKfL+pQ5pos?=
 =?us-ascii?Q?qCrFz8SQZzvPFCVxq6xDyn4Qoj+SMD/eiLPKR9ZGnQjZfUhD4tdpT/PY7iSJ?=
 =?us-ascii?Q?t3Yjk4OOOb0/SqgBJZuu9TIAXgfXZNwW7wEltVI1ANTvl+njB/QQ0GryzI9j?=
 =?us-ascii?Q?ZH3iDWvVo89YNXxD50X/bQ8iKnWSG9S3KF+YBZ7GSg3fq9WRRt8X3q0ZZiIx?=
 =?us-ascii?Q?FNPszOpgR9oV7TIgApREOgsh1d/ALo1SpTMtHl6uan4cHnJ5YyzCXft0f3rg?=
 =?us-ascii?Q?rHOo1dDsNY3kE8+A+WH638iNThGevJhn1Q65aOrd/bEgFpLlHVZhnuHpzBn7?=
 =?us-ascii?Q?yK4ZiBrnUH8rPZe5AlraEjO6tWq3bHfLEE0LQZ2hI9VdoO0vfgL7/KyMfCOv?=
 =?us-ascii?Q?SAdnNdGAxQEP6XvDFgdeB3s5FJm3McWvEu+FMNc8e6td8hRhoYTDKU3z1BTN?=
 =?us-ascii?Q?kRm7XkvrkWWwG8OnhnzvSpPCkDnaFnt2szFWYCkXoRBNRkGgudAvsX0fvFIB?=
 =?us-ascii?Q?84JUVovP2Mj4EYxeBXF7q2uPAfcyNVgGucaI95Gg/dt6xA24UpULb3kEinTC?=
 =?us-ascii?Q?buaNYSinJ3mUEUgG4lE3+N0yswnIjE+CfLx/xa3oXx0lbTe5bO3fuhmrlaql?=
 =?us-ascii?Q?2V650IZiQVyj4zYU9pohWrTdr5gJj8Tfc7mdYtuOQZEsHqfZv5dg3Nv6IegE?=
 =?us-ascii?Q?P+7341RWaY5+ufs/kbMNkyznuWFNhquXhsAJQ9lzlpNSNimFNM7EmHhizLum?=
 =?us-ascii?Q?WW7hkpRVpccEtKvcmPTD03g1EOXErkaOdzJL3tEVbgspxb07sB54ekpVhnZs?=
 =?us-ascii?Q?mEtFDHUINq5twV+TxIkAladU97r/WP2wxwpKQ7fpbw1MMmg1Gx8nTZxudMQe?=
 =?us-ascii?Q?Itxv8gb57KMiNkEKwR+EYYsgXzlhyxYpJ82XjQlEJCM7+xYoj3I13ooqA51g?=
 =?us-ascii?Q?qRGYYNVKaN/49NWwZ6xoyBXd4nE+zJIUNmhKDGFdYjPO+coOVeP+xmTAFTGr?=
 =?us-ascii?Q?4jVIzmS36OhaWHwu9iP8t8CZ+E+bEEcVRgxTWIuKLarlLeNX8Dpg1Ul6Y4LN?=
 =?us-ascii?Q?RzHERCLKP0cKMZNTpYW575SDAom00aJpJqr+30D/nre874jvgZIyD86lAUT/?=
 =?us-ascii?Q?76xnWpXYVL7zbxcSNJ3C+vfh8FzKgOvohX7klPuLIw/CKdfqr1A7wD1DZujB?=
 =?us-ascii?Q?cZYFrEKRgqDy0H2oGXBIAn2SI2HlOhztp4+GQl4COtL7gxPe+tAjFbn+m7we?=
 =?us-ascii?Q?2A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <958660427AE74C4B86FBDB70EB012860@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e56b8ef1-16db-415d-bbfb-08dac0e231e7
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2022 17:04:55.8602
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z4pksT+NIR3s6TZNMmm+6AjmE/vi+tZPiOmgZjcTnLHtxjT76g3kttvCn7mCdqKAOWfieGFFPT2Ma5m9/SIOhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9552
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 07, 2022 at 08:49:34AM -0800, Jakub Kicinski wrote:
> On Mon, 7 Nov 2022 12:51:26 +0000 Vladimir Oltean wrote:
> > There is also another problem having to do with future extensibility of
> > METADATA_HW_PORT_MUX for DSA. I don't know how much of this is going to
> > be applicable for qca8k, but DSA tags might also carry such information
> > as trap reason (RX) or injection type (into forwarding plane or control
> > packet; the latter bypasses port STP state) and the FID to which the
> > packet should be classified by the hardware (TX). If we're going to
> > design a mechanism which only preallocates metadata dst's for ports,
> > it's going to be difficult to make that work for more information later=
 on.
>
> The entire patch we're commenting on is 100 LoC. Seems like a small
> thing, which can be rewritten later as needed. I don't think hand wave-y
> arguments are sufficient to go with a much heavier solution from the
> start.

I don't think it's as hand wavey as you think. Maxime did not present
the switch-side changes or device tree in this patch set. If it's going
to be based on drivers/net/dsa/qca/qca8k-common.c as I suspect, then it
might have some obscure features which are already supported by 'normal'
QCA8K DSA switches, like register read/write over Ethernet, and MIB
autocasting. If these features exist in hardware (they aren't exposed by
this patch set for sure), you'd be hard-pressed to fit them into the
METADATA_HW_PORT_MUX model, since it's pure management traffic consumed
by the switch driver and not delivered to the network stack, as opposed
to packets sent/received on behalf of any switch port.=