Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8ee17547-30ef-bc85-b163-f0d9efe70fcc@gmail.com>
Date:   Mon, 7 Nov 2022 09:31:55 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 06/23] arm64: dts: Update cache properties for broadcom
Content-Language: en-US
To:     Pierre Gondois <pierre.gondois@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        William Zhang <william.zhang@broadcom.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
References: <20221107155825.1644604-1-pierre.gondois@arm.com>
 <20221107155825.1644604-7-pierre.gondois@arm.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20221107155825.1644604-7-pierre.gondois@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

(way too many recipients, gmail's SMTP server would not allow me to 
respond unless I moved most people to BCC now done).

On 11/7/22 07:56, Pierre Gondois wrote:
> The DeviceTree Specification v0.3 specifies that the cache node
> 'compatible' and 'cache-level' properties are 'required'. Cf.
> s3.8 Multi-level and Shared Cache Nodes
> The 'cache-unified' property should be present if one of the
> properties for unified cache is present ('cache-size', ...).
> 
> Update the Device Trees accordingly.
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> Acked-by: William Zhang <william.zhang@broadcom.com>

This looks fine, but incomplete, you seem to have missed:

- adding 'cache-unified' to all of the cache nodes modified in this 
patch set that did not have one already

- bcm63148.dtsi, bcm63178.dtsi, bcm6756.dtsi, bcm6846.dtsi, 
bcm6855.dtsi, bcm6878.dtsi, bcm47622.dtsi

Thanks
-- 
Florian