Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2203623rwb; Mon, 7 Nov 2022 10:21:04 -0800 (PST) X-Google-Smtp-Source: AMsMyM6yeeSoIzJSEjXfJufmLKPPps6unlPSallDgT6qE+rO8CLa8FFhfnelN2iPoKlA0HxuDyaP X-Received: by 2002:a17:90b:1c8b:b0:203:dcf1:128a with SMTP id oo11-20020a17090b1c8b00b00203dcf1128amr67591678pjb.182.1667845263983; Mon, 07 Nov 2022 10:21:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667845263; cv=none; d=google.com; s=arc-20160816; b=X5NzavyihO6zmSIaAS3e17MPknKTSAXaVs2M7Fiw+jTmXM4d4k9K5G2EXz/6Dv2jtJ mcVV2qvooxxvog7XyVxOMDMpHdnKPuq6Kt0+vhWct2N1DLXxYjEeqzXFeLZdK6Pk/Xze MQBVzUm27BLy2n3GyW4VQJ9OH6N30z5zc2wJZDUunX5Ef8R1pvCXOpxmicAJ2kRnr4v9 Ys3SJEuRZ6qPa5Tzy+VVOnHEHmYDsgAY3ADOa2PPBAtSBYPQDtisECKwcPBA/HJ2w20D mRhab8ti55/UljsNf8ZQ3NCwNN4J+qgY/8jA3mpw/5j4TNIzbcrVuCYD7PnlP+HMUrD5 ZBaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Z+IpH1Q1dYPVKyLaxilWX5S98yicXsHBkC9S23qvx10=; b=1CzgxbEkqfwTOkaxu4wy58sHAgx4m667+eRkfAoIbQtYn4ewHeAcNlBdDX/yhYQkax InYRkmF9LY5G/tA8L+nCIYeSeARPJLmfOVzIOW5V9hxMz4bvdpRJfKACMuH+6gAaOVjq xEiLuvwUG3eXI/ASg1mJnjFg+38XG4Hun476gVAbixA0FYlNbDSMGd6T+W7a2Z59N4Rn j3BuHTG9LAoDqAh9gMEP9bYUo4G4T2DYAoPgPTs3MfadbqVjB7G0ynQLRIpfvIlm6wI7 8aAEt3ad6z6VqAsJLaDBoLJkufvhV8LfoPrj8hkPTa9tUyVCTS2jczRn20zuMOA0T7dS SMIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=0tiKwTfj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l191-20020a6391c8000000b0047018d5b375si11666208pge.561.2022.11.07.10.20.51; Mon, 07 Nov 2022 10:21:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=0tiKwTfj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231986AbiKGRvY (ORCPT + 92 others); Mon, 7 Nov 2022 12:51:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231969AbiKGRvV (ORCPT ); Mon, 7 Nov 2022 12:51:21 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E58121803 for ; Mon, 7 Nov 2022 09:51:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1667843472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z+IpH1Q1dYPVKyLaxilWX5S98yicXsHBkC9S23qvx10=; b=0tiKwTfjj4UhOpeAevLbvl402I7D2NMWgngf1Q/iHCa1FNymftekv38ReVkSCMcp2rxzwa IM3Zhe0MlmSK6UO4Xyh3Udg2YJvZeIfJF5lhtnGRf4QYf992QMXJNQTJXwNc2UzExMP9wJ a7UjBsnLWx/CAYHgDcoX6uCq4V8Gpp4= From: Paul Cercueil To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil Subject: [PATCH 01/26] drm: modeset-helper: Export dev_pm_ops for simple drivers Date: Mon, 7 Nov 2022 17:50:41 +0000 Message-Id: <20221107175106.360578-2-paul@crapouillou.net> In-Reply-To: <20221107175106.360578-1-paul@crapouillou.net> References: <20221107175106.360578-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Export a dev_pm_ops meant to be used with simple drivers, which have their struct drm_device registered as their struct device's drvdata, and only call drm_mode_config_pm_{suspend,resume}. The symbol is conditionally exported if IS_ENABLED(CONFIG_PM_SLEEP), and therefore it should always be referenced using the pm_sleep_ptr() macro. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/drm_modeset_helper.c | 32 ++++++++++++++++++++++++++++ include/drm/drm_modeset_helper.h | 4 ++++ 2 files changed, 36 insertions(+) diff --git a/drivers/gpu/drm/drm_modeset_helper.c b/drivers/gpu/drm/drm_modeset_helper.c index f858dfedf2cf..0bc9f9228a60 100644 --- a/drivers/gpu/drm/drm_modeset_helper.c +++ b/drivers/gpu/drm/drm_modeset_helper.c @@ -20,6 +20,9 @@ * OF THIS SOFTWARE. */ +#include +#include + #include #include #include @@ -244,3 +247,32 @@ int drm_mode_config_helper_resume(struct drm_device *dev) return ret; } EXPORT_SYMBOL(drm_mode_config_helper_resume); + +static int drm_mode_config_pm_suspend(struct device *dev) +{ + struct drm_device *drm = dev_get_drvdata(dev); + + return drm_mode_config_helper_suspend(drm); +} + +static int drm_mode_config_pm_resume(struct device *dev) +{ + struct drm_device *drm = dev_get_drvdata(dev); + + return drm_mode_config_helper_resume(drm); +} + +/** + * drm_mode_config_pm_ops - Exported dev_pm_ops helper for simple drivers + * + * This dev_pm_ops can be used for simple drivers that would otherwise only call + * drm_mode_config_helper_suspend / drm_mode_config_helper_resume in their PM + * callbacks. It is only valid if the driver's drm_device has been registered as + * the struct device's drvdata. + * + * The exported symbol must always be used with the pm_sleep_ptr() macro, like + * this: + * .pm = pm_sleep_ptr(&drm_mode_config_pm_ops), + */ +EXPORT_SIMPLE_DEV_PM_OPS(drm_mode_config_pm_ops, + drm_mode_config_pm_suspend, drm_mode_config_pm_resume); diff --git a/include/drm/drm_modeset_helper.h b/include/drm/drm_modeset_helper.h index 995fd981cab0..85f29637e9c1 100644 --- a/include/drm/drm_modeset_helper.h +++ b/include/drm/drm_modeset_helper.h @@ -23,6 +23,8 @@ #ifndef __DRM_KMS_HELPER_H__ #define __DRM_KMS_HELPER_H__ +#include + struct drm_crtc; struct drm_crtc_funcs; struct drm_device; @@ -41,4 +43,6 @@ int drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, int drm_mode_config_helper_suspend(struct drm_device *dev); int drm_mode_config_helper_resume(struct drm_device *dev); +extern const struct dev_pm_ops drm_mode_config_pm_ops; + #endif -- 2.35.1