Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <40da21f7-19d7-142f-0380-41abd0d47d1d@meta.com>
Date:   Mon, 7 Nov 2022 10:45:34 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: [PATCH bpf] bpf: Add explicit cast to 'void *' for
 __BPF_DISPATCHER_UPDATE()
Content-Language: en-US
To:     Nathan Chancellor <nathan@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>
Cc:     John Fastabend <john.fastabend@gmail.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        patches@lists.linux.dev, kernel test robot <lkp@intel.com>,
        "kernelci.org bot" <bot@kernelci.org>
References: <20221107170711.42409-1-nathan@kernel.org>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <20221107170711.42409-1-nathan@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkI0Z2JmUzdvcUpRN2ZXSTd4dm9jV3E3cTZnZUFlOS96bzFzRUwrMXIxazJI?=
 =?utf-8?B?Umw3K3lXUnQ4VU5CbEZocEtNOXV5Q0FXc1JyUENEUWRQYXluZmk2eGdyU0Qw?=
 =?utf-8?B?U1FhQ0lBc0l3VDFRc2JFNHRMblo1amRreE5INWJYbHhhRHRaQWd1QUpuQWdI?=
 =?utf-8?B?STNjVHNqSzJYMTY2dytZTDZKajU4d1huNW1TMlpBZkRWbU9xVk1XcjdSTmM3?=
 =?utf-8?B?NlJLOUdTMWZSMUlEK1NZaFNxbDEvT3Y3MVg1dzkybU5XQkdVUUpTemJuMGhR?=
 =?utf-8?B?enJiZEtVRXZtazNLVXJDZHRVOVAxUkJTY210ZE5UeDVnemFlWjlSZEdneXpm?=
 =?utf-8?B?YlhJclllaVZIZXNpQWxFQkxFRTZtR2N5ZzNINmtRZE5MbE5TUzg3NmRrUWFk?=
 =?utf-8?B?T2xjNXhiOVFwL1ovUjdmNkttU2xhamt3YUNmU0t5ekg4a0RBK1EyZE9kL2M1?=
 =?utf-8?B?cHltcnpUNHE3eGRuRVhUOWQ1aVZhNDFXTDhScW9wVDVoZWpCdG1BUVV0bnVG?=
 =?utf-8?B?MXBtamNPMmpYNjRDdGx6bG0xdSszeWNKdGM1YzQxeFN1dHZxUXVTYVJnMlo3?=
 =?utf-8?B?ZytmdU5qdUdPY1FheWIvMENTT0J6R3Yxb2NKVFFrOUZjOVRjanJETzFjTWFS?=
 =?utf-8?B?SStFKzhKUE81UEJTM0lkWHdaMmFMN0NvNmNDS01ieEpNNmFKZ2xOUlExTUF6?=
 =?utf-8?B?SEd4VUtkNzhHWWVrd255YmNNc1lzSjMvYkZPcFd5SlBBbWhEQm5BM2E5Zm1I?=
 =?utf-8?B?OGdRSFV2U00xTTN5U1gzQmpoa3lteENhQXlFSzU4MkdSVC9OUlp2V1IwVkp1?=
 =?utf-8?B?R0xUZTE0aUV6TVh1ZkpQa2RPd0Jac2NPanFkUW9NcGtLejRxVURQcjkybXRM?=
 =?utf-8?B?dUFKMHR2Yzd0VVhHcEFtVU5QOEVJL3J5WjdBR1l2Y2p5RE1kb2VwOWZ5YVdu?=
 =?utf-8?B?YUNXNUM1NnRMZG4yZnRhK1hPcmxRMVJWdHA3STJTaXZTWkYxNnZrUTN5Zng2?=
 =?utf-8?B?RnNDRUkvQU9PUzZqY1YzL2o5eVYwK0VkSWlrSFZlUE10WThEdXdoYXZhY2U5?=
 =?utf-8?B?NmRxa2dxSCs3TmNYNjBxTmJCVG4zd1BtMWJiT0l6eEd5V2RVZTNyeVBETXVL?=
 =?utf-8?B?NFJBVUdtOVI0RlhZMGVlcDd5TGJLZnVJajkwb3Jld3VDVjZZNFp4VHlXSGFm?=
 =?utf-8?B?UjdidWhDM2g2WlZ2SWJvcjVCOGxYWkU4MWtvUmVDcWRqOWZBZDBOUHl6Y2g5?=
 =?utf-8?B?V3lydWFENDQ0TmhleGlQeWthbktlcDg5SjhSVDRZMWYyZnQ0VGpWWkZLWjJt?=
 =?utf-8?B?T2ZwY3pyaVgveEJoWEtsNS9VTStGL0t2RDF6S050WUY5VFBhK3hDMzVvaTN3?=
 =?utf-8?B?Sk5kVGN3VC9ITXovQlNSWmJyNENFV3M2S01MYi9uTU03ZHNsS20ydm5QUGgv?=
 =?utf-8?B?SDV4TmVPeGR4UGJOU1BPclBpcEZmL1o4WGdjUjBsdkhEVFZXK0NoYmlzSERC?=
 =?utf-8?B?UksrcTNnYS96WGU0NTc0ZnYwZnoyZDlScWMzNXV3UHM3K081VDFrb2NweGZG?=
 =?utf-8?B?Ukg2SjBOQ1QwcnVaY3hrdXZJdVdFdEU3VEJMejZjUHh4RWJCZTg3T1M2SnNu?=
 =?utf-8?B?djFqVVBSc2hlOHRPWVg0K3FwOUcrelQrOGlncG9rK3o2bm1RMUQxM1cxc0pH?=
 =?utf-8?B?a2Q0SUhWTlNPU3VVS0ZSZllPVnRpYU9tVElZUmtIdFBJNHZSQW5ocHBqeG41?=
 =?utf-8?B?U1B2V0ZwU2RLMElLaFVCVStxd0d2N2szamg4WWhwWHNvUnE5Qzh5K2x3S0c2?=
 =?utf-8?B?NTZPYzJJQXdPaVF3Y054SDVaNW11TlY0dHV5OWlyUFY4MnJxTW1ORlBWRzRh?=
 =?utf-8?B?eDFSRG5wYXQvYk8rZURzMzhUTFBJc0NMcXJheTNoN2s1MEthS0kwUVk3R3c1?=
 =?utf-8?B?VFZGMFZmZytUczZlMGNnZFZOSG5VNTYraUhvb0o5a1N2TVJvZkxrUXc1ZEhX?=
 =?utf-8?B?SXQ0R0t5cDBGUVNJM2YvUVJKL0w2d3d6aTBGUWRwaFhDM2xvUUcrN1ZmeXZv?=
 =?utf-8?B?OEROZ1l1cVhGenpiSVl2QjJsdDE2RzZZY3JILzVaTU53c0tYeUtaSnB6QWth?=
 =?utf-8?B?Mkp1M1FVY1lPOHV3OUNJMG9HalplWlZTU0IvM3pIMFVUYk9pdXdERng5MnBS?=
 =?utf-8?B?bEE9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d88578c-bff9-4d85-1d9a-08dac0f042c7
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 18:45:37.2625
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1b1OQ+9xCGjxJ8MqNMR3k9lTFdUsR9N0HI8vn/8VSXI2CUB26UACT7OWbRP9mfvn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR15MB2814
X-Proofpoint-GUID: BDCL2ezEdYabYccZt2iAF10mlhRH8Dsf
X-Proofpoint-ORIG-GUID: BDCL2ezEdYabYccZt2iAF10mlhRH8Dsf
Content-Transfer-Encoding: 7bit
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-07_11,2022-11-07_02,2022-06-22_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/7/22 9:07 AM, Nathan Chancellor wrote:
> When building with clang:
> 
>    kernel/bpf/dispatcher.c:126:33: error: pointer type mismatch ('void *' and 'unsigned int (*)(const void *, const struct bpf_insn *, bpf_func_t)' (aka 'unsigned int (*)(const void *, const struct bpf_insn *, unsigned int (*)(const void *, const struct bpf_insn *))')) [-Werror,-Wpointer-type-mismatch]
>            __BPF_DISPATCHER_UPDATE(d, new ?: &bpf_dispatcher_nop_func);
>                                       ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~
>    ./include/linux/bpf.h:1045:54: note: expanded from macro '__BPF_DISPATCHER_UPDATE'
>            __static_call_update((_d)->sc_key, (_d)->sc_tramp, (_new))
>                                                                ^~~~
>    1 error generated.
> 
> The warning is pointing out that the type of new ('void *') and
> &bpf_dispatcher_nop_func are not compatible, which could have side
> effects coming out of a conditional operator due to promotion rules.
> 
> Add the explicit cast to 'void *' to make it clear that this is
> expected, as __BPF_DISPATCHER_UPDATE() expands to a call to
> __static_call_update(), which expects a 'void *' as its final argument.
> 
> Fixes: c86df29d11df ("bpf: Convert BPF_DISPATCHER to use static_call() (not ftrace)")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1755
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Acked-by: Yonghong Song <yhs@fb.com>