Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2250249rwb; Mon, 7 Nov 2022 10:57:54 -0800 (PST) X-Google-Smtp-Source: AMsMyM5VpvKqqwxRFMnZk3GDpkFaaiVnRdMpqU6cf6U/66hPiEhht/O8SF/Z4MeArzE7Brwp1PEB X-Received: by 2002:a17:90b:3c8a:b0:213:e48a:3ac5 with SMTP id pv10-20020a17090b3c8a00b00213e48a3ac5mr44413569pjb.48.1667847474744; Mon, 07 Nov 2022 10:57:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667847474; cv=none; d=google.com; s=arc-20160816; b=hvmvJrr26osBgpidhy4Pk8dPetUbeDyeBH4AXdJrG/m7ffIb/SR2E7YgdWWZqgwVKP DbUgLirkKxn2ir+9tlEPddbA8gxwYLf+pEx7MZ+yGbodgpc0ed14lrczlYHna/ptiPp1 Ak2DIwdtFLD1SIvRZHnESBPAO3LwpIKzF12F/mIZEfB5rMbUbJTgDZ+bp2pGI5rZ5njE HMGutoPdQ/zUZYf80NHfSlMNSYlbCx3zb20WOmWiBQ7WR1iQAs/Kk/14sB3lRFiKTALf f62qLm+KJzkkS7YBMycLbgvjE4jkyNFBXFABWTDO2usOenA6qhhW4tWz5U7awQ3I5HB/ MUNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=nYfREh02uFhu5a7Npuc623PJyBQ84xQUEQ1muUCGdKU=; b=vSOD0pgvpfXyXyBUdBTdKtWSVhyfQj/Gs9LAnkVfwDWcnqAYuQbyMAAfWdENTlxwoE UhEAcDc4M9Z7eHpQmRf/s/Fcum3uS+dfv2Tqcu9S0nVKmT7lOdqa25OWlodACx3LI7wD 3A/BnJOU+WnH9WYCvxm8/QzQcrr0YGEll9T8r3XS8yq8McDoTGmAJJdeWSZ7FSexTDvl SSZ2tt/z5A4Dvtss48FfkGQYeIc0ZJ69ehIUASeLFNuREJ2Xgf+d8cCW40W3birJInWR OzQIYZgHUdjj/u+na5GuXSexIKxTy6EJ5bSPWbZg49arKEo+qm7oaOvSPiJnAZh9DOiv zn6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=H9DqZmp6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o11-20020a056a0015cb00b0056c7cc1f23fsi12172993pfu.132.2022.11.07.10.57.42; Mon, 07 Nov 2022 10:57:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=H9DqZmp6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232381AbiKGSC2 (ORCPT + 92 others); Mon, 7 Nov 2022 13:02:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233182AbiKGSCH (ORCPT ); Mon, 7 Nov 2022 13:02:07 -0500 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7DBB275C4; Mon, 7 Nov 2022 09:58:18 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id ABDF780079; Mon, 7 Nov 2022 18:58:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1667843896; bh=nYfREh02uFhu5a7Npuc623PJyBQ84xQUEQ1muUCGdKU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=H9DqZmp6CSBkQyQgUWXIxosZzK6ub89tzQJaQ0h+cBcOKLwxa1qyXcitJmVTb7w4/ /nE3plO1c+KqA7vMuSYgU2+nH+ThSd1PfqRoN4+Rg0ASOHFKD7d838ruTduAtT35Pc d6nBdWDTE8LkhRE/KFtHbOXLEeyDL/6JiWLSS0AnBEBZTwXsSNXv0OGtWKLBhcWdF4 4TqfOpCgGDXjoTxnr/dYiq26nnSh4GMnHrySIFLWJQqfNMvIVfEfWPFn7hBst3KjcX C3yHM6+/NLLCpqkIJThHWl3Ai97Y/8AC4QBvz5ICgunNibnQd+XavIQEySH6fgF0+5 IBp8n0tfrZFOw== Message-ID: <50130fa2-e15a-a043-94c8-002ac0817135@denx.de> Date: Mon, 7 Nov 2022 18:58:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2] extcon: usbc-tusb320: Call the Type-C IRQ handler only if a port is registered Content-Language: en-US To: Heikki Krogerus , Yassine Oudjana Cc: MyungJoo Ham , Chanwoo Choi , =?UTF-8?Q?Alvin_=c5=a0ipraga?= , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Yassine Oudjana References: <20221107153317.657803-1-y.oudjana@protonmail.com> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/7/22 17:28, Heikki Krogerus wrote: > On Mon, Nov 07, 2022 at 06:33:17PM +0300, Yassine Oudjana wrote: >> From: Yassine Oudjana >> >> Commit bf7571c00dca ("extcon: usbc-tusb320: Add USB TYPE-C support") >> added an optional Type-C interface to the driver but missed to check >> if it is in use when calling the IRQ handler. This causes an oops on >> devices currently using the old extcon interface. Check if a Type-C >> port is registered before calling the Type-C IRQ handler. >> >> Fixes: bf7571c00dca ("extcon: usbc-tusb320: Add USB TYPE-C support") >> Signed-off-by: Yassine Oudjana >> Reviewed-by: Marek Vasut > > Looks good to me. FWIW: > > Reviewed-by: Heikki Krogerus Likewise, looks good. You already have my RB. Thanks !