Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <30690bad-e3f4-36ee-c957-a2cf750b7775@amd.com>
Date:   Mon, 7 Nov 2022 12:18:09 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH v3 6/8] cpufreq: amd-pstate: implement suspend and resume
 callbacks
Content-Language: en-US
To:     Perry Yuan <Perry.Yuan@amd.com>, rafael.j.wysocki@intel.com,
        ray.huang@amd.com, viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221107175705.2207842-1-Perry.Yuan@amd.com>
 <20221107175705.2207842-7-Perry.Yuan@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20221107175705.2207842-7-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDNJYUw0NytmREEzeTY1K2xONUJEWlArZGFPNVJvR0ZvNS95dysxd1duOWh1?=
 =?utf-8?B?ejRpMHNENW1TN2pWd1Y4bGg2MktTT2NVWTFvQXlvdDM3SFE3Qm5VZGhqZEUx?=
 =?utf-8?B?MXVCbHZQMFI4RDA2NWtxNTN0REZiUHZybTVPKyttTHNwSWxRbFJ3NnpnTk9S?=
 =?utf-8?B?RU1QWThNR1o5NDdwZGFVaVowdm1pdE1tNUFLeThlWHY5UEdYUU1icHA0ME1M?=
 =?utf-8?B?bTdVY0owcTdCVlM0T0dRUm5BSmpsSUtFbktIa29HUXg4eHdpaWV2eE5ZU0k1?=
 =?utf-8?B?MG03MFpkSEp6K3ZQbnZBSEZRTWpZeGxYT3pZOXlrSVlxc2VsTGZjNXUzSWhi?=
 =?utf-8?B?b213Q0dlakE2OHp4Nk9xTnI2OEd2WHpDSVkvNnd3cGljRW5QS2tULy81aUJI?=
 =?utf-8?B?aVVIN2w4SUZGNXZVR1pTdXR2LzZvYzNqUWNwUUZ5dWM4ck9BeWRxSWs0K2VZ?=
 =?utf-8?B?eFhhMWYra0M1SlRJSCt4b1pDUCt3MkdZbFA4b21Fa2hpekZ2RGVyNTdleTJM?=
 =?utf-8?B?T0U3dkhYaUMvMnRJaFNpN2hNeWI5ckc2VElvb3JPNVpUaUFrMS84WEgvcEQr?=
 =?utf-8?B?c3lQdDAwNTB3Vk9JblUwZTlPekJRcGpCTDNtWk1LbkxLcXRLNlFFTGJFRHZ5?=
 =?utf-8?B?cklUZ3gvRDZlSlJ4emtBVjUySncrNFk0UEpJTXRMTi9tSTZPaDJpVFN2cE5w?=
 =?utf-8?B?cEh2eEZUTXBqQWIzanZhYitueWlnZlVxc2dFV291bmxSSkJyUHk3Nm5GTUla?=
 =?utf-8?B?WjdidkFYNTg5OFNUL3BCNDU0RFh3QzVVcmFESUNHM1BIVzlUN0ZhRVd4UzV3?=
 =?utf-8?B?bWVuTGNidHZaZFZreHJ6K0pLZitlK3RMaFFPZkdBY1RvU0xEM2hCZ3N6OHlJ?=
 =?utf-8?B?UU0rRk43dEZyNk9IQ2xZZDVkZU12ZnJFbkc5bFRYZ3NhdzFKMmZOb1F6M3Vs?=
 =?utf-8?B?akNaTW9ydWp6UjRRVjFiQlJCRWFCU0g3UWZvUUhRY28rTEtFQXR1Y2wwc0Rz?=
 =?utf-8?B?N0JUZGtiY1c3OFJpU2w2UC9KZEl3cjErazJrcGJBVG0vSTZRY0t1TmRBdy9Y?=
 =?utf-8?B?dnF2MGJGNWhjZFVBcUZtcCt4U1YyTUwxTVE2TENoMGFVRkg0c0tvd3A5b1NU?=
 =?utf-8?B?bkR6NEJWcTVNN3Mrc2xSdUpjNnl2ZEFxcGpPZE9kM09CTU85ZzJjOHlXQXQ2?=
 =?utf-8?B?ZDNZM0V2UmZ6cDM0ZjlxZkdBaElKTVA3ZFlDUFNUTjA5OEN5OW8vamhtZlRW?=
 =?utf-8?B?VnlVZERNNS8xYXg5V3VKeFVrdkloVlJ4U1BKNnV1WW5sN0wwbCtvQ0gzcmgr?=
 =?utf-8?B?YUtTQ3pFNGhjOTQ4Nk84eVRJWVFLU1R4ZXgzcVZHdzh1MnkzdTdoQmlYV3Ju?=
 =?utf-8?B?QTV5WkZMSnN1MU9Pd2l3bVlCUlM0aHU3WUt3YTRQNTIyQjFTWmQ0c095cC8v?=
 =?utf-8?B?dStpRm4zVUpTbTd0QmZMT2ExcnpEbHdEbk5hMzh2aFlxRzI1R2h2YUFXSkh3?=
 =?utf-8?B?eXZsVjVKc3RrT0FHQWV3NTE2VlhaT3kvdW8vTWxMTk9Qdkhqd3E1bXdXSHll?=
 =?utf-8?B?b2NRMUZEdzBkRGxBYWFOYUxOZW1JU3NvU1lJMXhOZ0FUSEZGdm9FTDJlSkQx?=
 =?utf-8?B?ZEloU0VlZU8vdXEwT2xJVjlMbkhFQzFnUWJrUkZvZnI5d0x5U1RqaGI3ZTlN?=
 =?utf-8?B?V29WbHpPUDlGcE9RQW9wVzgwdkVyNVpUL3NSR2xweWhseExTK0ZOdno2VW14?=
 =?utf-8?B?K1VHeS9nTGFrdlkwSU5oZFBWQXo4RldSTjd3ak9HNERDL1lPdlEza0MvV3BJ?=
 =?utf-8?B?OGRWRmpwQ0lYWmdvSWNiL2xBVWJzR1g5WmxkRVF0SnpDZGQzU1I3RVhldmQw?=
 =?utf-8?B?U3BjRHFtbVI3TTh2dG5BVk5sMmE0MTkvamgxejY2OHVUZlhCTmdVREJSVUI2?=
 =?utf-8?B?Y2RmWGNOOUpGS1d1aUhaamMvWjFKL2xpOXRrUEgveEhtbWg1UGl6Wll5cXNJ?=
 =?utf-8?B?aHBYZFdGRXU5QS9ER1M5d201M1NJS2JKZWZ0WDJOSVFVRVpwd1FDbjh4c29P?=
 =?utf-8?B?OVhyQzAwWEZ2VDI4eGg3eS9rWTgreUtXd1Y0ZWFVeDVpRUd4dmE2V1h3T0xk?=
 =?utf-8?Q?OwrLq3j6ooWe8OIvOvvDdDY7c?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 520170b1-647c-4862-2abd-08dac0ec6ec4
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 18:18:13.0760
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: blmvPNbYFObLVrQLLJiglwq1cjT1fu/Y+JZCfT3yYW/uW6lX5vuabOBcKfSyfYaRv1zkfDjZBbawlM549r+zCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4146
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/2022 11:57, Perry Yuan wrote:
> add suspend and resume support for the AMD processors by amd_pstate_epp
> driver instance.
> 
> When the CPPC is suspended, EPP driver will set EPP profile to 'power'
> profile and set max/min perf to lowest perf value.
> When resume happens, it will restore the MSR registers with
> previous cached value.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/cpufreq/amd-pstate.c | 40 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 40 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6ce9fca0a128..841b1e2383b8 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1282,6 +1282,44 @@ static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy)
>   	return amd_pstate_cpu_offline(policy);
>   }
>   
> +static int amd_pstate_epp_suspend(struct cpufreq_policy *policy)
> +{
> +	struct amd_cpudata *cpudata = all_cpu_data[policy->cpu];
> +	int ret;
> +
> +	/* avoid suspending when EPP is not enabled */
> +	if (!cppc_active)
> +		return 0;
> +
> +	/* set this flag to avoid setting core offline*/
> +	cpudata->suspended = true;
> +
> +	/* disable CPPC in lowlevel firmware */
> +	ret = amd_pstate_enable(false);
> +	if (ret)
> +		pr_err("failed to suspend, return %d\n", ret);
> +
> +	return 0;
> +}
> +
> +static int amd_pstate_epp_resume(struct cpufreq_policy *policy)
> +{
> +	struct amd_cpudata *cpudata = all_cpu_data[policy->cpu];
> +
> +	if (cpudata->suspended) {
> +		mutex_lock(&amd_pstate_limits_lock);
> +
> +		/* enable amd pstate from suspend state*/
> +		amd_pstate_epp_reenable(cpudata);
> +
> +		mutex_unlock(&amd_pstate_limits_lock);
> +
> +		cpudata->suspended = false;
> +	}
> +
> +	return 0;
> +}
> +
>   static void amd_pstate_verify_cpu_policy(struct amd_cpudata *cpudata,
>   					   struct cpufreq_policy_data *policy)
>   {
> @@ -1318,6 +1356,8 @@ static struct cpufreq_driver amd_pstate_epp_driver = {
>   	.update_limits	= amd_pstate_epp_update_limits,
>   	.offline	= amd_pstate_epp_cpu_offline,
>   	.online		= amd_pstate_epp_cpu_online,
> +	.suspend	= amd_pstate_epp_suspend,
> +	.resume		= amd_pstate_epp_resume,
>   	.name		= "amd_pstate_epp",
>   	.attr		= amd_pstate_epp_attr,
>   };